From: Tejun Heo <tj@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jeff Mahoney <jeffm@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096
Date: Tue, 20 Oct 2009 05:21:21 +0000 [thread overview]
Message-ID: <4ADD48D1.1040701@kernel.org> (raw)
In-Reply-To: <alpine.LRH.2.00.0910200651510.20992@twin.jikos.cz>
Hello,
Jiri Kosina wrote:
> How about this one? (untested)
>
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: sched: move rq_weight data array out of .percpu
>
> Commit 34d76c41 introduced percpu array update_shares_data, size of which
> being proportional to NR_CPUS. Unfortunately this blows up ia64 for large
> NR_CPUS configuration, as ia64 allows only 64k for .percpu section.
>
> Fix this by allocating this array dynamically and keep only pointer to it
> percpu.
If the structure can be dynamically allocated at all, just using
percpu_alloc() to allocate the whole thing should solve it with the
correct numa locality.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jeff Mahoney <jeffm@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096
Date: Tue, 20 Oct 2009 14:21:21 +0900 [thread overview]
Message-ID: <4ADD48D1.1040701@kernel.org> (raw)
In-Reply-To: <alpine.LRH.2.00.0910200651510.20992@twin.jikos.cz>
Hello,
Jiri Kosina wrote:
> How about this one? (untested)
>
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: sched: move rq_weight data array out of .percpu
>
> Commit 34d76c41 introduced percpu array update_shares_data, size of which
> being proportional to NR_CPUS. Unfortunately this blows up ia64 for large
> NR_CPUS configuration, as ia64 allows only 64k for .percpu section.
>
> Fix this by allocating this array dynamically and keep only pointer to it
> percpu.
If the structure can be dynamically allocated at all, just using
percpu_alloc() to allocate the whole thing should solve it with the
correct numa locality.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-10-20 5:21 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 22:28 Commit 34d76c41 causes linker errors on ia64 with NR_CPUS=4096 Jeff Mahoney
2009-10-20 2:02 ` Jiri Kosina
2009-10-20 2:02 ` Jiri Kosina
2009-10-20 4:57 ` Jiri Kosina
2009-10-20 4:57 ` Jiri Kosina
2009-10-20 5:21 ` Tejun Heo [this message]
2009-10-20 5:21 ` Tejun Heo
2009-10-20 5:58 ` Jiri Kosina
2009-10-20 5:58 ` Jiri Kosina
2009-10-20 6:12 ` Tejun Heo
2009-10-20 6:12 ` Tejun Heo
2009-10-20 6:14 ` Tejun Heo
2009-10-20 6:14 ` Tejun Heo
2009-10-20 6:27 ` Jiri Kosina
2009-10-20 6:27 ` Jiri Kosina
2009-10-20 14:18 ` Jeff Mahoney
2009-10-20 14:18 ` Jeff Mahoney
2009-10-20 14:49 ` Jeff Mahoney
2009-10-20 14:49 ` Jeff Mahoney
2009-10-21 6:11 ` Ingo Molnar
2009-10-21 6:11 ` Ingo Molnar
2009-10-21 15:19 ` Tejun Heo
2009-10-21 15:19 ` Tejun Heo
2009-10-21 22:11 ` Luck, Tony
2009-10-21 22:11 ` Luck, Tony
2009-10-22 14:49 ` Jiri Kosina
2009-10-22 14:49 ` Jiri Kosina
2009-10-22 14:53 ` Jeff Mahoney
2009-10-22 14:53 ` Jeff Mahoney
2009-10-22 22:24 ` Luck, Tony
2009-10-22 22:24 ` Luck, Tony
2009-10-23 7:51 ` Ingo Molnar
2009-10-23 7:51 ` Ingo Molnar
2009-10-23 12:30 ` Jiri Kosina
2009-10-23 12:30 ` Jiri Kosina
2009-10-26 16:38 ` Jiri Kosina
2009-10-26 16:38 ` Jiri Kosina
2009-10-26 20:16 ` Ingo Molnar
2009-10-26 20:16 ` Ingo Molnar
2009-10-27 10:03 ` Jiri Kosina
2009-10-27 10:03 ` Jiri Kosina
2009-10-27 10:52 ` Jiri Kosina
2009-10-27 10:52 ` Jiri Kosina
2009-10-20 6:15 ` Ingo Molnar
2009-10-20 6:15 ` Ingo Molnar
2009-10-20 6:26 ` Jiri Kosina
2009-10-20 6:26 ` Jiri Kosina
2009-10-20 6:35 ` Ingo Molnar
2009-10-20 6:35 ` Ingo Molnar
2009-10-20 7:11 ` Eric Dumazet
2009-10-20 7:11 ` Eric Dumazet
2009-10-20 7:39 ` Tejun Heo
2009-10-20 7:39 ` Tejun Heo
2009-10-20 7:12 ` Tejun Heo
2009-10-20 7:12 ` Tejun Heo
2009-10-20 7:17 ` Jiri Kosina
2009-10-20 7:17 ` Jiri Kosina
2009-10-20 7:36 ` Tejun Heo
2009-10-20 7:36 ` Tejun Heo
2009-10-20 13:08 ` Jeff Mahoney
2009-10-20 13:08 ` Jeff Mahoney
2009-10-20 13:43 ` Ingo Molnar
2009-10-20 13:43 ` Ingo Molnar
2009-10-20 13:57 ` Tejun Heo
2009-10-20 13:57 ` Tejun Heo
2009-10-20 13:58 ` Tejun Heo
2009-10-20 13:58 ` Tejun Heo
2009-10-21 6:43 ` Christoph Lameter
2009-10-21 6:43 ` Christoph Lameter
2009-10-20 9:21 ` Peter Zijlstra
2009-10-20 9:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADD48D1.1040701@kernel.org \
--to=tj@kernel.org \
--cc=fenghua.yu@intel.com \
--cc=jeffm@suse.com \
--cc=jkosina@suse.cz \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.