From: Gerd Hoffmann <kraxel@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation
Date: Thu, 29 Oct 2009 09:47:19 +0100 [thread overview]
Message-ID: <4AE95697.6020602@redhat.com> (raw)
In-Reply-To: <20091029043708.GA3552@lst.de>
On 10/29/09 05:37, Christoph Hellwig wrote:
> - try to create generic scsi device/request structures that the hba
> driver can access, and which contain additional private data for
> scsi-disk/generic. Information in the generic one would include
> the information about the data transfer, the tag and the command
> block.
Agreed. For scsi device this did already happen as part of the
qdev-ification work. It certainly makes sense to do that for scsi
requests too. May also allow to kill some code duplication in
scsi-disk.c and scsi-generic.c
> - try to get rid of the tag indexing stuff by just using a pointer to
> the generic scsi request in the hba drivers. That should get rid
> of a lot of useless list searching.
Indeed.
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: virtualization@lists.linux-foundation.org,
Hannes Reinecke <hare@suse.de>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation
Date: Thu, 29 Oct 2009 09:47:19 +0100 [thread overview]
Message-ID: <4AE95697.6020602@redhat.com> (raw)
In-Reply-To: <20091029043708.GA3552@lst.de>
On 10/29/09 05:37, Christoph Hellwig wrote:
> - try to create generic scsi device/request structures that the hba
> driver can access, and which contain additional private data for
> scsi-disk/generic. Information in the generic one would include
> the information about the data transfer, the tag and the command
> block.
Agreed. For scsi device this did already happen as part of the
qdev-ification work. It certainly makes sense to do that for scsi
requests too. May also allow to kill some code duplication in
scsi-disk.c and scsi-generic.c
> - try to get rid of the tag indexing stuff by just using a pointer to
> the generic scsi request in the hba drivers. That should get rid
> of a lot of useless list searching.
Indeed.
cheers,
Gerd
next prev parent reply other threads:[~2009-10-29 8:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 15:26 [PATCH 0/4] megaraid_sas HBA emulation Hannes Reinecke
2009-10-27 15:26 ` [Qemu-devel] " Hannes Reinecke
2009-10-27 16:47 ` Gerd Hoffmann
2009-10-27 16:47 ` Gerd Hoffmann
2009-10-28 8:11 ` Hannes Reinecke
2009-10-28 8:11 ` Hannes Reinecke
2009-10-28 8:11 ` Hannes Reinecke
2009-10-28 8:20 ` Avi Kivity
2009-10-28 8:20 ` Avi Kivity
2009-10-28 8:20 ` Avi Kivity
2009-10-28 8:40 ` Christoph Hellwig
2009-10-28 8:40 ` Christoph Hellwig
2009-10-28 8:40 ` Christoph Hellwig
2009-10-28 10:54 ` Gerd Hoffmann
2009-10-28 10:54 ` Gerd Hoffmann
2009-10-28 10:54 ` Gerd Hoffmann
2009-10-28 13:58 ` Gerd Hoffmann
2009-10-28 13:58 ` Gerd Hoffmann
2009-10-28 19:25 ` Hannes Reinecke
2009-10-29 4:37 ` Christoph Hellwig
2009-10-29 4:37 ` Christoph Hellwig
2009-10-29 8:47 ` Gerd Hoffmann
2009-10-29 8:47 ` Gerd Hoffmann [this message]
2009-10-29 8:47 ` Gerd Hoffmann
2009-10-29 12:57 ` Gerd Hoffmann
2009-10-29 12:57 ` Gerd Hoffmann
2009-10-29 12:57 ` Gerd Hoffmann
2009-10-29 14:57 ` Christoph Hellwig
2009-10-29 14:57 ` Christoph Hellwig
2009-10-29 14:57 ` Christoph Hellwig
2009-10-29 15:14 ` Anthony Liguori
2009-10-29 15:14 ` Anthony Liguori
2009-10-29 15:14 ` Anthony Liguori
2009-10-29 15:15 ` Christoph Hellwig
2009-10-29 15:15 ` Christoph Hellwig
2009-10-29 15:25 ` Anthony Liguori
2009-10-29 15:25 ` Anthony Liguori
2009-10-29 15:25 ` Anthony Liguori
2009-10-30 8:55 ` Gerd Hoffmann
2009-10-30 8:55 ` Gerd Hoffmann
2009-10-30 8:55 ` Gerd Hoffmann
2009-10-29 15:15 ` Christoph Hellwig
2009-10-30 8:12 ` Hannes Reinecke
2009-10-30 8:12 ` Hannes Reinecke
2009-10-30 8:12 ` Hannes Reinecke
2009-11-03 21:03 ` Gerd Hoffmann
2009-11-03 21:03 ` Gerd Hoffmann
2009-11-03 21:03 ` Gerd Hoffmann
2009-10-29 4:37 ` Christoph Hellwig
2009-10-28 19:25 ` Hannes Reinecke
2009-10-27 16:47 ` Gerd Hoffmann
2009-11-11 1:49 ` Paul Brook
2009-11-11 1:49 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE95697.6020602@redhat.com \
--to=kraxel@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.