Re: [PATCH] mscan: add non-polling rx

Re: [PATCH] mscan: add non-polling rx

[Wolfgang Grandegger]

Wolfgang Grandegger wrote:
> Luotao Fu wrote:
>> This one adds an option to turn of napi and process rx directly in mscan isr. As
>> for mpc52xx this feature can be turned on by setting a rx-irq property int the
>> device tree, e.g:
>> can@980 {
>>     compatible = "fsl,mpc5200b-mscan","fsl,mpc5200-mscan";
>>     interrupts = <2 18 0>;
>>     rx-irq;
>>     reg = <0x980 0x80>;
>> };
>> Default is the polling rx.
>>
>> Signed-off-by: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> 
> This has little chance to be accepted as the device tree is about
> hardware. It should not be used to tell the driver what to do (software
> settings). I have CCed the devicetree-discuss ML for clarification.

Forgot the CC to devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org

Wolfgang.

Re: [Socketcan-users] [PATCH] mscan: add non-polling rx

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --]

On Fri, Oct 30, 2009 at 06:36:15PM +0100, Wolfgang Grandegger wrote:
> Wolfgang Grandegger wrote:
> > Luotao Fu wrote:
> >> This one adds an option to turn of napi and process rx directly in mscan isr. As
> >> for mpc52xx this feature can be turned on by setting a rx-irq property int the
> >> device tree, e.g:
> >> can@980 {
> >>     compatible = "fsl,mpc5200b-mscan","fsl,mpc5200-mscan";
> >>     interrupts = <2 18 0>;
> >>     rx-irq;
> >>     reg = <0x980 0x80>;
> >> };
> >> Default is the polling rx.
> >>
> >> Signed-off-by: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > 
> > This has little chance to be accepted as the device tree is about
> > hardware. It should not be used to tell the driver what to do (software
> > settings). I have CCed the devicetree-discuss ML for clarification.

I second Wolfgang's opinion. Pity I can't provide a suitable alternative.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss