* Re: [PATCH] mscan: add non-polling rx [not found] ` <4AEB2328.6090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> @ 2009-10-30 17:36 ` Wolfgang Grandegger [not found] ` <4AEB240F.1080408-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Wolfgang Grandegger @ 2009-10-30 17:36 UTC (permalink / raw) To: Luotao Fu Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, socketcan-users-0fE9KPoRgkgATYTw5x5z8w Wolfgang Grandegger wrote: > Luotao Fu wrote: >> This one adds an option to turn of napi and process rx directly in mscan isr. As >> for mpc52xx this feature can be turned on by setting a rx-irq property int the >> device tree, e.g: >> can@980 { >> compatible = "fsl,mpc5200b-mscan","fsl,mpc5200-mscan"; >> interrupts = <2 18 0>; >> rx-irq; >> reg = <0x980 0x80>; >> }; >> Default is the polling rx. >> >> Signed-off-by: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > > This has little chance to be accepted as the device tree is about > hardware. It should not be used to tell the driver what to do (software > settings). I have CCed the devicetree-discuss ML for clarification. Forgot the CC to devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Wolfgang. ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <4AEB240F.1080408-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>]
* Re: [Socketcan-users] [PATCH] mscan: add non-polling rx [not found] ` <4AEB240F.1080408-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> @ 2009-10-30 17:48 ` Wolfram Sang 0 siblings, 0 replies; 2+ messages in thread From: Wolfram Sang @ 2009-10-30 17:48 UTC (permalink / raw) To: Wolfgang Grandegger Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, socketcan-users-0fE9KPoRgkgATYTw5x5z8w, Luotao Fu [-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --] On Fri, Oct 30, 2009 at 06:36:15PM +0100, Wolfgang Grandegger wrote: > Wolfgang Grandegger wrote: > > Luotao Fu wrote: > >> This one adds an option to turn of napi and process rx directly in mscan isr. As > >> for mpc52xx this feature can be turned on by setting a rx-irq property int the > >> device tree, e.g: > >> can@980 { > >> compatible = "fsl,mpc5200b-mscan","fsl,mpc5200-mscan"; > >> interrupts = <2 18 0>; > >> rx-irq; > >> reg = <0x980 0x80>; > >> }; > >> Default is the polling rx. > >> > >> Signed-off-by: Luotao Fu <l.fu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > > > > This has little chance to be accepted as the device tree is about > > hardware. It should not be used to tell the driver what to do (software > > settings). I have CCed the devicetree-discuss ML for clarification. I second Wolfgang's opinion. Pity I can't provide a suitable alternative. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] [-- Attachment #2: Type: text/plain, Size: 192 bytes --] _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-30 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1256902073-22328-1-git-send-email-l.fu@pengutronix.de>
[not found] ` <4AEB2328.6090009@grandegger.com>
[not found] ` <4AEB2328.6090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-10-30 17:36 ` [PATCH] mscan: add non-polling rx Wolfgang Grandegger
[not found] ` <4AEB240F.1080408-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-10-30 17:48 ` [Socketcan-users] " Wolfram Sang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.