All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Radensky <felix@embedded-sol.com>
To: Michael Chan <mchan@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	mcarlson@broadcom.com,
	"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: tg3: link is permanently down after ifdown and ifup
Date: Sat, 21 Nov 2009 13:03:39 +0200	[thread overview]
Message-ID: <4B07C90B.5060708@embedded-sol.com> (raw)
In-Reply-To: <1258671053.14964.20.camel@nseg_linux_HP1.broadcom.com>

Hi,

Michael Chan wrote:
> On Thu, 2009-11-19 at 08:08 -0800, Felix Radensky wrote:
>   
>> Hi,
>>
>> The problem goes away if I remove the call to
>>
>> tg3_set_power_state(tp, PCI_D3hot);
>>
>> from tg3_close().
>>     
>
> Added Matt to CC.  He is on vacation and may not be able to look into
> this right away.  Thanks.
>
>   
Thanks, Michael. After digging some more into it, I've found that the
problem is in tg3_power_down_phy() routine. Apparently 57780 PHY
is not handled properly. If tg3_power_down_phy() is not invoked from
tg3_set_power_state(), the problem is not reproducible anymore. I don't
have enough information about  NIC internals to dig further.

Felix.

  reply	other threads:[~2009-11-21 11:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 15:16 tg3: link is permanently down after ifdown and ifup Felix Radensky
2009-11-19 16:08 ` Felix Radensky
2009-11-19 22:50   ` Michael Chan
2009-11-21 11:03     ` Felix Radensky [this message]
2009-12-09  8:43     ` Felix Radensky
2009-12-10  1:19       ` Matt Carlson
2009-12-10  1:45         ` Felix Radensky
2009-12-10  2:31           ` Matt Carlson
2009-12-10  5:09             ` Felix Radensky
2009-12-20 16:44         ` Felix Radensky
2009-12-21 18:19           ` Matt Carlson
2009-12-21 21:52             ` Felix Radensky
2010-01-04 13:41               ` Felix Radensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B07C90B.5060708@embedded-sol.com \
    --to=felix@embedded-sol.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.