From: rubisher <rubisher@scarlet.be>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Just a cosmetic question about grub_vprintf()?
Date: Sat, 28 Nov 2009 18:21:20 +0000 [thread overview]
Message-ID: <4B116A20.5030003@scarlet.be> (raw)
In-Reply-To: <20091123144428.GA9295@thorin>
Robert Millan wrote:
> On Sun, Nov 22, 2009 at 01:10:11PM +0000, rubisher wrote:
>> But as far as the 1st parameter of grub_vsprintf is a pointer,
>> wouldn't it be better to write:
>> --- kern/misc.c.orig 2009-11-22 13:07:22.000000000 +0000
>> +++ kern/misc.c 2009-11-22 13:07:51.000000000 +0000
>> @@ -160,7 +160,7 @@
>> {
>> int ret;
>>
>> - ret = grub_vsprintf (0, fmt, args);
>> + ret = grub_vsprintf (NULL, fmt, args);
>> return ret;
>> }
>
> Yes. But we have many of those, so we don't go huntin' them. If you'd
> like to help us, a patch that does this change in bulk would be welcome.
>
> Thanks
>
It will be of great pleasure for me, but I didn't foreseen so much (the most difficult to me are 'opaque pointer') but I
hoppe that such 'sparse' would help me for the most ;<)
Hope to comeback soon,
J.
next prev parent reply other threads:[~2009-11-28 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 13:10 Just a cosmetic question about grub_vprintf()? rubisher
2009-11-23 14:44 ` Robert Millan
2009-11-28 18:21 ` rubisher [this message]
2009-11-29 9:19 ` Colin Watson
2009-12-05 21:58 ` rubisher
2009-12-09 21:36 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B116A20.5030003@scarlet.be \
--to=rubisher@scarlet.be \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.