All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
To: Mel Gorman <mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: pm list
	<linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kernel Testers List
	<kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Bisected: s2disk (uswsusp only) hangs just before poweroff
Date: Wed, 02 Dec 2009 11:11:13 +0000	[thread overview]
Message-ID: <4B164B51.6040203@tuffmail.co.uk> (raw)
In-Reply-To: <20091201214529.GA1457-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>

Mel Gorman wrote:
> On Tue, Dec 01, 2009 at 07:59:40PM +0000, Alan Jenkins wrote:
>   
>> Hi
>>
>> Suspend to disk is (sometimes) hanging for me in 2.6.32-rc.  I finally  
>> got around to bisecting it, which blamed the following commit by Mel:
>>
>> 5f8dcc2 "page-allocator: split per-cpu list into one-list-per-migrate-type"
>>
>> I was able to confirm this by reverting the commit, which fixed the  
>> hang.  I had to revert one other commit first to avoid a conflict:
>>
>> a6f9edd "page-allocator: maintain rolling count of pages to free from  
>> the PCP"
>>
>>     
>
> Which RC kernel? Specifically, are the commits
>
> cc4a6851466039a8a688c843962a05689059ff3b always wake kswapd when restarting an allocation attempt
> 9d0ed60fe9cd1fbf57f755cd27a23ae9114d7210 Do not allow interrupts to use ALLOC_HARDER
>
> applied?
>
> The latter one in particular might make a difference if s2disk is
> pushing the system far below the watermarks. I don't suppose you know
> where it's hanging? i.e. is it hanging in the allocator itself?
>   

After enabling "suspend loglevel = 8" in uswsusp.conf (grr), I saw a 
pair of hung task backtraces.

<http://picasaweb.google.com/Alan.Christopher.Jenkins/Screenshots#5410594126006567282>


> would you mind trying the following patch?
> Unfortunately, it's totally untested. The intention of the patch is to
> use other PCP lists if the desired one cannot be refilled.
>
> Thanks.
>   

Sure, will do.

Thanks
Alan

WARNING: multiple messages have this Message-ID (diff)
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Mel Gorman <mel@csn.ul.ie>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kernel Testers List <kernel-testers@vger.kernel.org>
Subject: Re: Bisected: s2disk (uswsusp only) hangs just before poweroff
Date: Wed, 02 Dec 2009 11:11:13 +0000	[thread overview]
Message-ID: <4B164B51.6040203@tuffmail.co.uk> (raw)
In-Reply-To: <20091201214529.GA1457@csn.ul.ie>

Mel Gorman wrote:
> On Tue, Dec 01, 2009 at 07:59:40PM +0000, Alan Jenkins wrote:
>   
>> Hi
>>
>> Suspend to disk is (sometimes) hanging for me in 2.6.32-rc.  I finally  
>> got around to bisecting it, which blamed the following commit by Mel:
>>
>> 5f8dcc2 "page-allocator: split per-cpu list into one-list-per-migrate-type"
>>
>> I was able to confirm this by reverting the commit, which fixed the  
>> hang.  I had to revert one other commit first to avoid a conflict:
>>
>> a6f9edd "page-allocator: maintain rolling count of pages to free from  
>> the PCP"
>>
>>     
>
> Which RC kernel? Specifically, are the commits
>
> cc4a6851466039a8a688c843962a05689059ff3b always wake kswapd when restarting an allocation attempt
> 9d0ed60fe9cd1fbf57f755cd27a23ae9114d7210 Do not allow interrupts to use ALLOC_HARDER
>
> applied?
>
> The latter one in particular might make a difference if s2disk is
> pushing the system far below the watermarks. I don't suppose you know
> where it's hanging? i.e. is it hanging in the allocator itself?
>   

After enabling "suspend loglevel = 8" in uswsusp.conf (grr), I saw a 
pair of hung task backtraces.

<http://picasaweb.google.com/Alan.Christopher.Jenkins/Screenshots#5410594126006567282>


> would you mind trying the following patch?
> Unfortunately, it's totally untested. The intention of the patch is to
> use other PCP lists if the desired one cannot be refilled.
>
> Thanks.
>   

Sure, will do.

Thanks
Alan

  parent reply	other threads:[~2009-12-02 11:11 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 19:59 Bisected: s2disk (uswsusp only) hangs just before poweroff Alan Jenkins
2009-12-01 19:59 ` Alan Jenkins
2009-12-01 20:24 ` Justin P. Mattock
2009-12-01 21:45 ` Mel Gorman
     [not found] ` <4B1575AC.6080904-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-12-01 20:24   ` Justin P. Mattock
2009-12-01 20:24     ` Justin P. Mattock
     [not found]     ` <4B157B81.9050703-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-12-01 20:27       ` Alan Jenkins
2009-12-01 20:27         ` Alan Jenkins
2009-12-01 21:14         ` Justin P. Mattock
2009-12-01 21:14         ` Justin P. Mattock
2009-12-01 20:27     ` Alan Jenkins
2009-12-01 21:45   ` Mel Gorman
2009-12-01 21:45     ` Mel Gorman
2009-12-01 21:53     ` Rafael J. Wysocki
2009-12-02 11:49       ` Alan Jenkins
     [not found]       ` <200912012253.08522.rjw-KKrjLPT3xs0@public.gmane.org>
2009-12-02 11:49         ` Alan Jenkins
2009-12-02 11:49           ` Alan Jenkins
2009-12-02 12:20           ` Mel Gorman
     [not found]           ` <4B16545B.3090703-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-12-02 12:20             ` Mel Gorman
2009-12-02 12:20               ` Mel Gorman
2009-12-02 14:25               ` Alan Jenkins
2009-12-02 14:25               ` Alan Jenkins
2009-12-02 14:28               ` [PATCH] uswsusp: automatically free the in-memory image once s2disk has finished with it Alan Jenkins
     [not found]               ` <20091202122019.GD1457-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-02 14:28                 ` Alan Jenkins
2009-12-02 14:28                   ` Alan Jenkins
2009-12-02 21:11                   ` Pavel Machek
     [not found]                   ` <4B16797C.3010304-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-12-02 21:11                     ` Pavel Machek
2009-12-02 21:11                       ` Pavel Machek
     [not found]                       ` <20091202211107.GA20830-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-12-02 22:07                         ` Mel Gorman
2009-12-02 22:07                           ` Mel Gorman
2009-12-02 22:15                           ` Pavel Machek
     [not found]                             ` <20091202221524.GB20830-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2009-12-02 22:25                               ` Mel Gorman
2009-12-02 22:25                                 ` Mel Gorman
2009-12-02 23:22                                 ` Rafael J. Wysocki
     [not found]                                 ` <20091202222516.GD26702-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-02 23:22                                   ` Rafael J. Wysocki
2009-12-02 23:22                                     ` Rafael J. Wysocki
2009-12-03  7:53                                   ` Pavel Machek
2009-12-03  7:53                                     ` Pavel Machek
2009-12-03 12:57                                     ` Alan Jenkins
2009-12-03 12:57                                       ` Alan Jenkins
     [not found]                                       ` <4B17B5B8.1060105-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-12-03 14:50                                         ` Mel Gorman
2009-12-03 14:50                                           ` Mel Gorman
     [not found]                                           ` <20091203145018.GG26702-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-08  0:37                                             ` Alan Jenkins
2009-12-08  0:37                                               ` Alan Jenkins
     [not found]                                               ` <9b2b86520912071637v6957ed24ie0f67acf6785ab08-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-11 10:53                                                 ` Mel Gorman
2009-12-11 10:53                                                   ` Mel Gorman
2009-12-14 11:08                                                   ` Pavel Machek
     [not found]                                                   ` <20091211105352.GB30670-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-14 11:08                                                     ` Pavel Machek
2009-12-14 11:08                                                       ` Pavel Machek
2009-12-11 10:53                                               ` Mel Gorman
2009-12-08  0:37                                           ` Alan Jenkins
2009-12-03 20:16                                         ` Pavel Machek
2009-12-03 20:16                                           ` Pavel Machek
2009-12-03 14:50                                       ` Mel Gorman
2009-12-03 19:50                                       ` Rafael J. Wysocki
2009-12-03 19:50                                       ` Rafael J. Wysocki
2009-12-03 20:16                                       ` Pavel Machek
2009-12-03  7:53                                 ` Pavel Machek
2009-12-02 22:25                             ` Mel Gorman
2009-12-02 22:15                           ` Pavel Machek
2009-12-02 22:07                       ` Mel Gorman
2009-12-02 21:47                     ` Rafael J. Wysocki
2009-12-02 21:47                       ` Rafael J. Wysocki
2009-12-02 21:47                   ` Rafael J. Wysocki
2009-12-01 21:53     ` Bisected: s2disk (uswsusp only) hangs just before poweroff Rafael J. Wysocki
2009-12-02  8:57     ` Alan Jenkins
2009-12-02 11:11     ` Alan Jenkins
     [not found]     ` <20091201214529.GA1457-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-02  8:57       ` Alan Jenkins
2009-12-02  8:57         ` Alan Jenkins
2009-12-02 10:35         ` Mel Gorman
     [not found]         ` <4B162BE1.7070709-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-12-02 10:35           ` Mel Gorman
2009-12-02 10:35             ` Mel Gorman
     [not found]             ` <20091202103538.GB1457-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org>
2009-12-02 11:35               ` Alan Jenkins
2009-12-02 11:35                 ` Alan Jenkins
2009-12-02 11:35             ` Alan Jenkins
2009-12-02 11:11       ` Alan Jenkins [this message]
2009-12-02 11:11         ` Alan Jenkins
  -- strict thread matches above, loose matches on Subject: below --
2009-12-01 19:59 Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B164B51.6040203@tuffmail.co.uk \
    --to=alan-jenkins-ccz0lq7mmjm9fhfhhbbuya@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=mel-wPRd99KPJ+uzQB+pC5nmwQ@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.