[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking

[Jan Kiszka <jan.kiszka@siemens.com>]

Juan Quintela wrote:
> Jan Kiszka <jan.kiszka@web.de> wrote:
>> Seeking on vmstate save/load does not work if the underlying file is a
>> stream. We could try to make all QEMUFile* forward-seek-aware, but first
>> attempts in this direction indicated that it's saner to convert the few
>> qemu_fseek-on-vmstates users to plain reads/writes.
>>
>> This fixes various subtle vmstate corruptions where unused fields were
>> involved.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Something changed lately.  This used to work, and I also waste^spend
> yesterday trying to understand why it was failing to me.

I'm quite sure it never really worked. Maybe the bug was just papered over.

> 
> I am splitting the patch in virtio-net and savevm parts.  (In my tree
> virtio-net don't use fseek anymore).

OK, then I will drop this patch from my queue. BTW, where is your tree
hosted?

> 
> Thanks for finding the bug.
> 
> Later, Juan.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux