All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Liran Schour <LIRANS@il.ibm.com>,
	Pierre Riteau <Pierre.Riteau@irisa.fr>
Subject: [Qemu-devel] Re: [PATCH] vmstate: Avoid seeking
Date: Wed, 02 Dec 2009 11:05:33 +0100	[thread overview]
Message-ID: <m3eindn11u.fsf@neno.neno> (raw)
In-Reply-To: <4B15A8FA.5080804@web.de> (Jan Kiszka's message of "Wed, 02 Dec 2009 00:38:34 +0100")

Jan Kiszka <jan.kiszka@web.de> wrote:
> Seeking on vmstate save/load does not work if the underlying file is a
> stream. We could try to make all QEMUFile* forward-seek-aware, but first
> attempts in this direction indicated that it's saner to convert the few
> qemu_fseek-on-vmstates users to plain reads/writes.
>
> This fixes various subtle vmstate corruptions where unused fields were
> involved.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Something changed lately.  This used to work, and I also waste^spend
yesterday trying to understand why it was failing to me.

I am splitting the patch in virtio-net and savevm parts.  (In my tree
virtio-net don't use fseek anymore).

Thanks for finding the bug.

Later, Juan.

  parent reply	other threads:[~2009-12-02 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 23:38 [Qemu-devel] [PATCH] vmstate: Avoid seeking Jan Kiszka
2009-12-02  3:24 ` Ryan Harper
2009-12-02 10:05 ` Juan Quintela [this message]
2009-12-02 11:14   ` [Qemu-devel] " Jan Kiszka
2009-12-02 11:24     ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3eindn11u.fsf@neno.neno \
    --to=quintela@redhat.com \
    --cc=LIRANS@il.ibm.com \
    --cc=Pierre.Riteau@irisa.fr \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.