[Qemu-devel] Re: [PATCH] vmstate: Avoid seeking

[Juan Quintela <quintela@redhat.com>]

Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Juan Quintela wrote:
>> Jan Kiszka <jan.kiszka@web.de> wrote:
>>> Seeking on vmstate save/load does not work if the underlying file is a
>>> stream. We could try to make all QEMUFile* forward-seek-aware, but first
>>> attempts in this direction indicated that it's saner to convert the few
>>> qemu_fseek-on-vmstates users to plain reads/writes.
>>>
>>> This fixes various subtle vmstate corruptions where unused fields were
>>> involved.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> 
>> Something changed lately.  This used to work, and I also waste^spend
>> yesterday trying to understand why it was failing to me.
>
> I'm quite sure it never really worked. Maybe the bug was just papered over.
>
>> 
>> I am splitting the patch in virtio-net and savevm parts.  (In my tree
>> virtio-net don't use fseek anymore).
>
> OK, then I will drop this patch from my queue. BTW, where is your tree
> hosted?

http://repo.or.cz/w/qemu/quintela.git/shortlog/refs/heads/vmstate/virtio

This one has not still in upstream:
- the audio changes that I have just posted
- vmstate cleanups (yours and more)
- msix/virtio port to vmstate

I am splitting vmstate/cleanups at this moment to send the two series
upstream.  I am in the point where everything compiles and run,
i.e. only need to reorder patches.

Later, Juan.

>> 
>> Thanks for finding the bug.
>> 
>> Later, Juan.
>
> Jan