All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Grégoire Sutre" <gregoire.sutre@labri.fr>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Disable -Werror when error attribute generates warnings
Date: Sat, 02 Jan 2010 13:58:20 +0100	[thread overview]
Message-ID: <4B3F42EC.1010100@labri.fr> (raw)

Hi,

With an older version of gcc that does not understand the error 
attribute, gcc generates warnings when compiling files that include 
include/grub/list.h.  Since TARGET_CFLAGS contains -Werror by default, 
the build of modules fails.

The following patch checks whether the C compiler supports the error 
attribute without warning, and disables -Werror if that is not the case 
(as otherwise the build will fail).

http://pkgsrc-wip.cvs.sourceforge.net/viewvc/*checkout*/pkgsrc-wip/wip/grub2-current/patches/patch-gcc-warning-on-error-attribute

This is merely a suggestion.  I'm no autoconf expert, and I'm not even 
sure that this kind of check is a good idea, as configure has the option 
--disable-werror that can be used anyway.

Grégoire

p.s. I did not see this problem when I tested the patch discussed in the 
thread [1] as I focused on building utilities at that time, sorry.

[1] http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00324.html



             reply	other threads:[~2010-01-02 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02 12:58 Grégoire Sutre [this message]
2010-01-02 15:37 ` Disable -Werror when error attribute generates warnings Colin Watson
2010-01-02 18:05   ` Grégoire Sutre
2010-01-02 18:21   ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-03 16:47     ` Robert Millan
2010-01-03 21:48     ` Colin Watson
2010-01-03 16:46   ` Robert Millan
2010-01-03 21:55     ` Colin Watson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B3F42EC.1010100@labri.fr \
    --to=gregoire.sutre@labri.fr \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.