All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Grégoire Sutre" <gregoire.sutre@labri.fr>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Disable -Werror when error attribute generates warnings
Date: Sat, 02 Jan 2010 19:05:08 +0100	[thread overview]
Message-ID: <4B3F8AD4.7010005@labri.fr> (raw)
In-Reply-To: <20100102153738.GX5847@riva.ucam.org>

Colin Watson wrote:

> Instead of this, why not only use the attribute if it's available? I
> couldn't find an entry about it in GCC's human-readable change
> summaries, but support was committed on 2007-09-23 so I think it's
> available from GCC 4.3.
> 
> I use this GNUC_PREREQ approach in other projects and rather like it. It
> could be extended to cover our other uses of attributes quite easily.

Nice trick :-)

I confirm that this patch works with gcc 4.1.3 on NetBSD.  And it's 
definitely better than completely disabling -Werror...

Thanks,

Grégoire



  reply	other threads:[~2010-01-02 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02 12:58 Disable -Werror when error attribute generates warnings Grégoire Sutre
2010-01-02 15:37 ` Colin Watson
2010-01-02 18:05   ` Grégoire Sutre [this message]
2010-01-02 18:21   ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-03 16:47     ` Robert Millan
2010-01-03 21:48     ` Colin Watson
2010-01-03 16:46   ` Robert Millan
2010-01-03 21:55     ` Colin Watson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B3F8AD4.7010005@labri.fr \
    --to=gregoire.sutre@labri.fr \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.