All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: john cooper <john.cooper@redhat.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Przywara, Andre" <Andre.Przywara@amd.com>,
	qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..
Date: Thu, 21 Jan 2010 12:59:38 -0600	[thread overview]
Message-ID: <4B58A41A.5020209@codemonkey.ws> (raw)
In-Reply-To: <4B588448.7090303@redhat.com>

On 01/21/2010 10:43 AM, john cooper wrote:
> Anthony Liguori wrote:
>    
>> On 01/20/2010 07:18 PM, john cooper wrote:
>>      
>>> I can appreciate the concern of wanting to get this
>>> as "correct" as possible.
>>>
>>>        
>> This is the root of the trouble.  At the qemu layer, we try to focus on
>> being correct.
>>
>> Management tools are typically the layer that deals with being "correct".
>>
>> A good compromise is making things user tunable which means that a
>> downstream can make "correctness" decisions without forcing those
>> decisions on upstream.
>>      
> Conceptually I agree with such a malleable approach -- actually
> I prefer it.  I thought however it was too much infrastructure to
> foist on the problem just to add a few more models into the mix.
>    

See list for patches.  I didn't do the cpu bits but it should be very 
obvious how to do that now.

Regards,

Anthony Liguori

> The only reservation which comes to mind is that of logistics.
> This may ruffle the code some and impact others such as Andre
> who seem to have existing patches relative to the current structure.
> Anyone have strong objections to this approach before I have a
> look at an implementation?
>
> Thanks,
>
> -john
>
>
>    


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: john cooper <john.cooper@redhat.com>
Cc: "Przywara, Andre" <Andre.Przywara@amd.com>,
	KVM list <kvm@vger.kernel.org>,
	qemu-devel@nongnu.org, Chris Wright <chrisw@sous-sol.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..
Date: Thu, 21 Jan 2010 12:59:38 -0600	[thread overview]
Message-ID: <4B58A41A.5020209@codemonkey.ws> (raw)
In-Reply-To: <4B588448.7090303@redhat.com>

On 01/21/2010 10:43 AM, john cooper wrote:
> Anthony Liguori wrote:
>    
>> On 01/20/2010 07:18 PM, john cooper wrote:
>>      
>>> I can appreciate the concern of wanting to get this
>>> as "correct" as possible.
>>>
>>>        
>> This is the root of the trouble.  At the qemu layer, we try to focus on
>> being correct.
>>
>> Management tools are typically the layer that deals with being "correct".
>>
>> A good compromise is making things user tunable which means that a
>> downstream can make "correctness" decisions without forcing those
>> decisions on upstream.
>>      
> Conceptually I agree with such a malleable approach -- actually
> I prefer it.  I thought however it was too much infrastructure to
> foist on the problem just to add a few more models into the mix.
>    

See list for patches.  I didn't do the cpu bits but it should be very 
obvious how to do that now.

Regards,

Anthony Liguori

> The only reservation which comes to mind is that of logistics.
> This may ruffle the code some and impact others such as Andre
> who seem to have existing patches relative to the current structure.
> Anyone have strong objections to this approach before I have a
> look at an implementation?
>
> Thanks,
>
> -john
>
>
>    

  reply	other threads:[~2010-01-21 18:59 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 16:45 [PATCH] Add definitions for current cpu models john cooper
2010-01-18 16:45 ` [Qemu-devel] " john cooper
2010-01-19 19:39 ` Anthony Liguori
2010-01-19 19:39   ` Anthony Liguori
2010-01-19 20:03   ` Chris Wright
2010-01-19 22:12     ` Jamie Lokier
2010-01-19 22:12       ` Jamie Lokier
2010-01-19 22:20       ` Chris Wright
2010-01-19 22:20         ` Chris Wright
2010-01-19 22:25     ` Anthony Liguori
2010-01-20  0:15       ` Chris Wright
2010-01-20  0:15         ` Chris Wright
2010-01-20 14:21         ` Anthony Liguori
2010-01-20 14:27           ` Gleb Natapov
2010-01-20 14:27             ` Gleb Natapov
2010-01-20  1:38       ` Jamie Lokier
2010-01-20  1:38         ` Jamie Lokier
2010-01-20 20:09       ` john cooper
2010-01-20 20:26         ` Daniel P. Berrange
2010-01-20 20:26           ` Daniel P. Berrange
2010-01-20 20:53           ` Anthony Liguori
2010-01-20 20:53             ` Anthony Liguori
2010-01-21  0:25           ` Chris Wright
2010-01-21  0:25             ` Chris Wright
2010-01-21  1:18             ` john cooper
2010-01-21  1:18               ` john cooper
2010-01-21 14:39               ` Andre Przywara
2010-01-21 14:39                 ` Andre Przywara
2010-01-21 17:06                 ` Blue Swirl
2010-01-21 15:05               ` Anthony Liguori
2010-01-21 15:05                 ` Anthony Liguori
2010-01-21 16:43                 ` john cooper
2010-01-21 16:43                   ` john cooper
2010-01-21 18:59                   ` Anthony Liguori [this message]
2010-01-21 18:59                     ` Anthony Liguori
2010-01-25  9:08                 ` Dor Laor
2010-01-25  9:08                   ` Dor Laor
2010-01-25 11:27                   ` Jamie Lokier
2010-01-25 11:27                     ` Jamie Lokier
2010-01-25 14:21                   ` Anthony Liguori
2010-01-25 14:21                     ` Anthony Liguori
2010-01-25 22:35                     ` Dor Laor
2010-01-26  8:26                       ` Gerd Hoffmann
2010-01-26  8:26                         ` Gerd Hoffmann
2010-01-26 12:54                         ` Anthony Liguori
2010-01-26 12:54                           ` Anthony Liguori
2010-01-28  8:19                   ` Arnd Bergmann
2010-01-28  8:19                     ` Arnd Bergmann
2010-01-28  8:43                     ` Alexander Graf
2010-01-28  8:43                       ` Alexander Graf
2010-01-28 10:09                       ` Arnd Bergmann
2010-01-28 10:09                         ` Arnd Bergmann
2010-01-28 14:10                       ` Anthony Liguori
2010-01-28 14:10                         ` Anthony Liguori
2010-01-19 22:11   ` Jamie Lokier
2010-01-20 20:09     ` john cooper
2010-01-20 20:09       ` john cooper
2010-01-21 17:50       ` Jamie Lokier
2010-01-21 17:50         ` Jamie Lokier
2010-01-21 18:13       ` Jamie Lokier
2010-01-21 18:13         ` Jamie Lokier
2010-01-21 18:36         ` john cooper
2010-01-21 18:36           ` john cooper
2010-01-19 22:15 ` Jamie Lokier
2010-01-19 22:15   ` Jamie Lokier
2010-01-20 20:11   ` john cooper
2010-01-20 20:11     ` john cooper
2010-01-21 17:55     ` Jamie Lokier
2010-01-21 17:55       ` Jamie Lokier
2010-01-21 18:34       ` john cooper
2010-01-21 18:34         ` john cooper
2010-01-20 23:20 ` Arnd Bergmann
2010-01-20 23:20   ` [Qemu-devel] " Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2009-12-21  6:46 [Qemu-devel] " john cooper
2009-12-24 13:45 ` Avi Kivity
2009-12-31  3:13 ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B58A41A.5020209@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Andre.Przywara@amd.com \
    --cc=berrange@redhat.com \
    --cc=chrisw@sous-sol.org \
    --cc=john.cooper@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.