Re: [PATCH 4/4] KVM: Rework of guest debug state writing

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/4] KVM: Rework of guest debug state writing
Date: Thu, 04 Feb 2010 20:00:26 +0100	[thread overview]
Message-ID: <4B6B194A.90009@siemens.com> (raw)
In-Reply-To: <4B6B179A.3080704@siemens.com>

Jan Kiszka wrote:
> Marcelo Tosatti wrote:
>>
>> Unrelated to this problem, won't put_vcpu_events, which is executed 
>> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
> 
> Good point, SET_GUEST_DEBUG should be last in the writeback for that reason.

Actually, we no longer need the exception injection via SET_GUEST_DEBUG
now that we have full access via vcpu_events. So this needs a cleanup,
and I'm afraid quite a few cases are broken ATM with vcpu_events
writeback overwriting the reinjected exceptions.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)

From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing
Date: Thu, 04 Feb 2010 20:00:26 +0100	[thread overview]
Message-ID: <4B6B194A.90009@siemens.com> (raw)
In-Reply-To: <4B6B179A.3080704@siemens.com>

Jan Kiszka wrote:
> Marcelo Tosatti wrote:
>>
>> Unrelated to this problem, won't put_vcpu_events, which is executed 
>> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
> 
> Good point, SET_GUEST_DEBUG should be last in the writeback for that reason.

Actually, we no longer need the exception injection via SET_GUEST_DEBUG
now that we have full access via vcpu_events. So this needs a cleanup,
and I'm afraid quite a few cases are broken ATM with vcpu_events
writeback overwriting the reinjected exceptions.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

next prev parent reply	other threads:[~2010-02-04 19:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 21:29 [PATCH 0/4] KVM pull request: Various fixes and cleanups Jan Kiszka
2010-02-03 21:29 ` [Qemu-devel] " Jan Kiszka
2010-02-03 21:29 ` [PATCH 1/4] KVM: x86: Fix up misreported CPU features Jan Kiszka
2010-02-03 21:29   ` [Qemu-devel] " Jan Kiszka
2010-02-03 21:29 ` [PATCH 2/4] KVM: Make vmport KVM-compatible Jan Kiszka
2010-02-03 21:29   ` [Qemu-devel] " Jan Kiszka
2010-02-03 21:29 ` [PATCH 3/4] KVM: Move and rename regs_modified Jan Kiszka
2010-02-03 21:29   ` [Qemu-devel] " Jan Kiszka
2010-02-03 21:29 ` [PATCH 4/4] KVM: Rework of guest debug state writing Jan Kiszka
2010-02-03 21:29   ` [Qemu-devel] " Jan Kiszka
2010-02-03 23:49   ` Marcelo Tosatti
2010-02-03 23:49     ` [Qemu-devel] " Marcelo Tosatti
2010-02-04  0:33     ` Jan Kiszka
2010-02-04  0:33       ` [Qemu-devel] " Jan Kiszka
2010-02-04 13:00       ` Marcelo Tosatti
2010-02-04 13:00         ` [Qemu-devel] " Marcelo Tosatti
2010-02-04 15:04         ` Jan Kiszka
2010-02-04 15:04           ` [Qemu-devel] " Jan Kiszka
2010-02-04 15:41           ` Jan Kiszka
2010-02-04 15:41             ` [Qemu-devel] " Jan Kiszka
2010-02-04 18:05             ` Marcelo Tosatti
2010-02-04 18:05               ` [Qemu-devel] " Marcelo Tosatti
2010-02-04 18:53               ` Jan Kiszka
2010-02-04 18:53                 ` [Qemu-devel] " Jan Kiszka
2010-02-04 19:00                 ` Jan Kiszka [this message]
2010-02-04 19:00                   ` Jan Kiszka
2010-02-08 15:52                   ` Marcelo Tosatti
2010-02-08 15:52                     ` [Qemu-devel] " Marcelo Tosatti
2010-02-08 16:07                     ` Jan Kiszka
2010-02-08 16:07                       ` [Qemu-devel] " Jan Kiszka
2010-02-04 19:21                 ` Jan Kiszka
2010-02-04 19:21                   ` [Qemu-devel] " Jan Kiszka
2010-02-04 20:50                   ` Marcelo Tosatti
2010-02-04 20:50                     ` [Qemu-devel] " Marcelo Tosatti
2010-02-08 15:52                   ` Marcelo Tosatti
2010-02-08 15:52                     ` [Qemu-devel] " Marcelo Tosatti
2010-02-03 21:35 ` [Qemu-devel] [PATCH 0/4] KVM pull request: Various fixes and cleanups Anthony Liguori
2010-02-03 21:54   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6B194A.90009@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.