From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfgang Grandegger <wg-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data
Date: Wed, 10 Feb 2010 11:53:55 +0100 [thread overview]
Message-ID: <4B729043.9080303@grandegger.com> (raw)
In-Reply-To: <20100210213203.48a9105e.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Stephen Rothwell wrote:
> Hi Wolfgang,
>
> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> wrote:
>>> __devinitdata goes at the end, immediately before the '='. Ditto
>>> throughout the file.
>> This made a difference and revealed section mismatches. "const" seems to
>> be incompatible with "__devinitdata".
>
> Maybe try no "const" and "__devinitconst" (I am not sure if both will
> work).
Yes, that works, even together with "const". To avoid rolling out the
whole patch series again, I can prepare a follow-up patch fixing this issue.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Devicetree-discuss@lists.ozlabs.org, Linux-i2c@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>,
Linuxppc-dev@lists.ozlabs.org, Wolfgang Grandegger <wg@denx.de>
Subject: Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data
Date: Wed, 10 Feb 2010 11:53:55 +0100 [thread overview]
Message-ID: <4B729043.9080303@grandegger.com> (raw)
In-Reply-To: <20100210213203.48a9105e.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Wolfgang,
>
> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger <wg@grandegger.com> wrote:
>>> __devinitdata goes at the end, immediately before the '='. Ditto
>>> throughout the file.
>> This made a difference and revealed section mismatches. "const" seems to
>> be incompatible with "__devinitdata".
>
> Maybe try no "const" and "__devinitconst" (I am not sure if both will
> work).
Yes, that works, even together with "const". To avoid rolling out the
whole patch series again, I can prepare a follow-up patch fixing this issue.
Wolfgang.
next prev parent reply other threads:[~2010-02-10 10:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 13:25 [PATCH v4 0/3] i2c-mpc: add support for the Freescale MPC512x and other fixes Wolfgang Grandegger
2010-01-28 13:25 ` Wolfgang Grandegger
[not found] ` <1264685141-26391-1-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-01-28 13:25 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Wolfgang Grandegger
2010-01-28 13:25 ` Wolfgang Grandegger
[not found] ` <1264685141-26391-2-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-01-28 13:25 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfgang Grandegger
2010-01-28 13:25 ` Wolfgang Grandegger
[not found] ` <1264685141-26391-3-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-01-28 13:25 ` [PATCH v4 3/3] powerpc: doc/dts-bindings: update doc of FSL I2C bindings Wolfgang Grandegger
2010-01-28 13:25 ` Wolfgang Grandegger
[not found] ` <1264685141-26391-4-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-01-29 16:26 ` Wolfram Sang
2010-01-29 16:26 ` Wolfram Sang
2010-02-09 17:50 ` Grant Likely
2010-02-09 17:50 ` Grant Likely
[not found] ` <fa686aa41002090950w2c3cd008k47784089dd3417d7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-09 18:57 ` Wolfgang Grandegger
2010-02-09 18:57 ` Wolfgang Grandegger
[not found] ` <4B71AFFC.3010301-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-02-09 19:23 ` Wolfgang Grandegger
2010-02-09 19:23 ` Wolfgang Grandegger
[not found] ` <4B71B618.6020807-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-02-09 22:15 ` Grant Likely
2010-02-09 22:15 ` Grant Likely
2010-01-29 16:24 ` [PATCH v4 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Wolfram Sang
2010-01-29 16:24 ` Wolfram Sang
2010-02-09 17:45 ` Grant Likely
2010-02-09 17:45 ` Grant Likely
2010-02-09 17:41 ` [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data Grant Likely
2010-02-09 17:41 ` Grant Likely
[not found] ` <fa686aa41002090941je3e4fdqbecf2616a8b90e42-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-10 10:09 ` Wolfgang Grandegger
2010-02-10 10:09 ` Wolfgang Grandegger
[not found] ` <4B7285D5.9060008-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-02-10 10:32 ` Stephen Rothwell
2010-02-10 10:32 ` Stephen Rothwell
[not found] ` <20100210213203.48a9105e.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2010-02-10 10:53 ` Wolfgang Grandegger [this message]
2010-02-10 10:53 ` Wolfgang Grandegger
[not found] ` <4B729043.9080303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-02-10 14:14 ` Grant Likely
2010-02-10 14:14 ` Grant Likely
[not found] ` <fa686aa41002100614l76bff396ved847c0b0a4c71ff-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-10 14:45 ` Wolfgang Grandegger
2010-02-10 14:45 ` Wolfgang Grandegger
2010-01-29 16:15 ` Wolfram Sang
2010-01-29 16:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B729043.9080303@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=Linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=wg-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.