From: Clemens Ladisch <clemens@ladisch.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] oxygen: clean up. make precedence explicit
Date: Fri, 19 Feb 2010 09:29:05 +0100 [thread overview]
Message-ID: <4B7E4BD1.3040106@ladisch.de> (raw)
> This doesn't change anything, but I think it makes the code clearer.
> It silences a smatch warning:
> sound/pci/oxygen/oxygen_mixer.c +91 dac_mute_put(7) warn: add some parenthesis here?
That message doesn't say why some parentheses should be added.
And it's a question; how do I give it the answer "no"? :-)
> - changed = !value->value.integer.value[0] != chip->dac_mute;
> + changed = (!value->value.integer.value[0]) != chip->dac_mute;
This doesn't look any clearer to me; I don't think that the unary
negation operator could be thought to have lower precedence than "!=".
Why does smatch warn about this combination? Do such errors actually
happen?
Regards,
Clemens
WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] oxygen: clean up. make precedence explicit
Date: Fri, 19 Feb 2010 08:29:05 +0000 [thread overview]
Message-ID: <4B7E4BD1.3040106@ladisch.de> (raw)
> This doesn't change anything, but I think it makes the code clearer.
> It silences a smatch warning:
> sound/pci/oxygen/oxygen_mixer.c +91 dac_mute_put(7) warn: add some parenthesis here?
That message doesn't say why some parentheses should be added.
And it's a question; how do I give it the answer "no"? :-)
> - changed = !value->value.integer.value[0] != chip->dac_mute;
> + changed = (!value->value.integer.value[0]) != chip->dac_mute;
This doesn't look any clearer to me; I don't think that the unary
negation operator could be thought to have lower precedence than "!=".
Why does smatch warn about this combination? Do such errors actually
happen?
Regards,
Clemens
next reply other threads:[~2010-02-19 8:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 8:29 Clemens Ladisch [this message]
2010-02-19 8:29 ` [patch] oxygen: clean up. make precedence explicit Clemens Ladisch
2010-02-19 10:10 ` Dan Carpenter
2010-02-19 10:10 ` Dan Carpenter
2010-02-19 10:33 ` Bernd Petrovitsch
2010-02-19 11:29 ` Dan Carpenter
2010-02-19 11:29 ` Dan Carpenter
2010-02-19 16:58 ` Dan Carpenter
2010-02-19 16:58 ` Dan Carpenter
2010-02-19 13:09 ` Bernd Petrovitsch
2010-02-19 17:24 ` Clemens Ladisch
2010-02-19 17:24 ` Clemens Ladisch
2010-02-19 20:08 ` Dan Carpenter
2010-02-19 20:08 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2010-02-19 6:58 Dan Carpenter
2010-02-19 6:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7E4BD1.3040106@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.