* Broken build
@ 2010-03-17 16:14 Bruce Dubbs
2010-03-17 23:12 ` Carles Pina i Estany
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Dubbs @ 2010-03-17 16:14 UTC (permalink / raw)
To: The development of GNU GRUB
With the addition of the internationalization code, building GRUB in a
separate directory fails.
mkdir build
cd build
../configure
make
cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 -o
../po/grub.pot -f ../po/POTFILES --keyword=_ --keyword=N_
/usr/bin/xgettext: error while opening "../po/POTFILES" for reading: No
such file or directory
make: *** [../po/grub.pot] Error 1
This is a regression from GRUB-1.97.2
-- Bruce
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Broken build
2010-03-17 16:14 Broken build Bruce Dubbs
@ 2010-03-17 23:12 ` Carles Pina i Estany
2010-03-18 0:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 8+ messages in thread
From: Carles Pina i Estany @ 2010-03-17 23:12 UTC (permalink / raw)
To: The development of GNU GRUB
Hi,
On Mar/17/2010, Bruce Dubbs wrote:
> With the addition of the internationalization code, building GRUB in
> a separate directory fails.
I'll take a look into it "soon" (next days or next week)
Probably it's an easy thing, if someone checks it before please report
:-)
Thanks for the report,
--
Carles Pina i Estany
http://pinux.info
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Broken build
2010-03-17 23:12 ` Carles Pina i Estany
@ 2010-03-18 0:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-03-18 0:55 ` Bruce Dubbs
0 siblings, 1 reply; 8+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-03-18 0:03 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
Carles Pina i Estany wrote:
> Hi,
>
> On Mar/17/2010, Bruce Dubbs wrote:
>
>> With the addition of the internationalization code, building GRUB in
>> a separate directory fails.
>>
>
> I'll take a look into it "soon" (next days or next week)
>
> Probably it's an easy thing, if someone checks it before please report
> :-)
>
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f $< --keyword=_ --keyword=N_
to
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f po/POTFILES --keyword=_ --keyword=N_
Feel free to test & commit
> Thanks for the report,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Broken build
2010-03-18 0:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2010-03-18 0:55 ` Bruce Dubbs
2010-03-26 14:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Dubbs @ 2010-03-18 0:55 UTC (permalink / raw)
To: The development of GNU GRUB
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Carles Pina i Estany wrote:
>> Hi,
>>
>> On Mar/17/2010, Bruce Dubbs wrote:
>>
>>> With the addition of the internationalization code, building GRUB in
>>> a separate directory fails.
>>>
>> I'll take a look into it "soon" (next days or next week)
>>
>> Probably it's an easy thing, if someone checks it before please report
>> :-)
>>
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f $< --keyword=_ --keyword=N_
> to
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f po/POTFILES --keyword=_ --keyword=N_
> Feel free to test & commit
I don't think so. When generated, the makefile has:
$(srcdir)/po/$(PACKAGE).pot: po/POTFILES po/POTFILES-shell
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ -f
$< --keyword=_ --keyword=N_
which when instantiated by make is:
../po/grub.pot: po/POTFILES po/POTFILES-shell
cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 \
-o ../po/grub.pot -f po/POTFILES --keyword=_ --keyword=N_
/usr/bin/xgettext: cannot create output file "../po/grub.pot": No such
file or directory
If I change this to:
po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
mkdir -p po
$(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ \
-f $< --keyword=_ --keyword=N
I get the error:
/usr/bin/xgettext: error while opening "commands/acpi.c" for reading:
No such file or directory
We need something like:
po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
mkdir -p po
DIR=$PWD
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 \
-o $(DIR)/$@ -f po/POTFILES --keyword=_ --keyword=N
The use of $< is wrong here because of the cd command.
-- Bruce
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Broken build
2010-03-18 0:55 ` Bruce Dubbs
@ 2010-03-26 14:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-03-26 14:45 ` richardvoigt
2010-03-27 4:10 ` Bruce Dubbs
0 siblings, 2 replies; 8+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-03-26 14:33 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 2500 bytes --]
Bruce Dubbs wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> Carles Pina i Estany wrote:
>>> Hi,
>>>
>>> On Mar/17/2010, Bruce Dubbs wrote:
>>>
>>>> With the addition of the internationalization code, building GRUB in
>>>> a separate directory fails.
>>>>
>>> I'll take a look into it "soon" (next days or next week)
>>>
>>> Probably it's an easy thing, if someone checks it before please report
>>> :-)
>>>
>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>> -f $< --keyword=_ --keyword=N_
>> to
>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>> -f po/POTFILES --keyword=_ --keyword=N_
>> Feel free to test & commit
>
> I don't think so.
Well you have a funny way of disagreeing arriving to the same result as
I told: replace
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f $< --keyword=_ --keyword=N_
with
cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f po/POTFILES --keyword=_ --keyword=N_
Have you tested it?
> When generated, the makefile has:
>
> $(srcdir)/po/$(PACKAGE).pot: po/POTFILES po/POTFILES-shell
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ -f
> $< --keyword=_ --keyword=N_
>
> which when instantiated by make is:
>
> ../po/grub.pot: po/POTFILES po/POTFILES-shell
> cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 \
> -o ../po/grub.pot -f po/POTFILES --keyword=_ --keyword=N_
>
> /usr/bin/xgettext: cannot create output file "../po/grub.pot": No such
> file or directory
>
> If I change this to:
>
> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
> mkdir -p po
> $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ \
> -f $< --keyword=_ --keyword=N
>
> I get the error:
>
> /usr/bin/xgettext: error while opening "commands/acpi.c" for
> reading: No such file or directory
>
> We need something like:
>
> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
> mkdir -p po
> DIR=$PWD
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 \
> -o $(DIR)/$@ -f po/POTFILES --keyword=_ --keyword=N
>
> The use of $< is wrong here because of the cd command.
>
>
> -- Bruce
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Broken build
2010-03-26 14:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2010-03-26 14:45 ` richardvoigt
2010-03-27 4:10 ` Bruce Dubbs
1 sibling, 0 replies; 8+ messages in thread
From: richardvoigt @ 2010-03-26 14:45 UTC (permalink / raw)
To: The development of GNU GRUB
2010/3/26 Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>:
> Bruce Dubbs wrote:
>> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> Carles Pina i Estany wrote:
>>>> Hi,
>>>>
>>>> On Mar/17/2010, Bruce Dubbs wrote:
>>>>
>>>>> With the addition of the internationalization code, building GRUB in
>>>>> a separate directory fails.
>>>>>
>>>> I'll take a look into it "soon" (next days or next week)
>>>>
>>>> Probably it's an easy thing, if someone checks it before please report
>>>> :-)
>>>>
>>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>>> -f $< --keyword=_ --keyword=N_
>>> to
>>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>>> -f po/POTFILES --keyword=_ --keyword=N_
>>> Feel free to test & commit
>>
>> I don't think so.
> Well you have a funny way of disagreeing arriving to the same result as
> I told: replace
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f $< --keyword=_ --keyword=N_
> with
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f po/POTFILES --keyword=_ --keyword=N_
> Have you tested it?
This is still clearly wrong. When building outside the source tree,
make should not create any files in the source tree. Write permission
to the source tree should not be required.
>
>> When generated, the makefile has:
>>
>> $(srcdir)/po/$(PACKAGE).pot: po/POTFILES po/POTFILES-shell
>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ -f
>> $< --keyword=_ --keyword=N_
>>
>> which when instantiated by make is:
>>
>> ../po/grub.pot: po/POTFILES po/POTFILES-shell
>> cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 \
>> -o ../po/grub.pot -f po/POTFILES --keyword=_ --keyword=N_
>>
>> /usr/bin/xgettext: cannot create output file "../po/grub.pot": No such
>> file or directory
>>
>> If I change this to:
>>
>> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
>> mkdir -p po
>> $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ \
>> -f $< --keyword=_ --keyword=N
>>
>> I get the error:
>>
>> /usr/bin/xgettext: error while opening "commands/acpi.c" for
>> reading: No such file or directory
>>
>> We need something like:
>>
>> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
>> mkdir -p po
>> DIR=$PWD
>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 \
>> -o $(DIR)/$@ -f po/POTFILES --keyword=_ --keyword=N
>>
>> The use of $< is wrong here because of the cd command.
This looks like a better fix, if gettext looks for files relative to
the current directory.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Broken build
2010-03-26 14:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-03-26 14:45 ` richardvoigt
@ 2010-03-27 4:10 ` Bruce Dubbs
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Dubbs @ 2010-03-27 4:10 UTC (permalink / raw)
To: The development of GNU GRUB
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Bruce Dubbs wrote:
>> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> Carles Pina i Estany wrote:
>>>> Hi,
>>>>
>>>> On Mar/17/2010, Bruce Dubbs wrote:
>>>>
>>>>> With the addition of the internationalization code, building GRUB in
>>>>> a separate directory fails.
>>>>>
>>>> I'll take a look into it "soon" (next days or next week)
>>>>
>>>> Probably it's an easy thing, if someone checks it before please report
>>>> :-)
>>>>
>>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>>> -f $< --keyword=_ --keyword=N_
>>> to
>>> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>>> -f po/POTFILES --keyword=_ --keyword=N_
>>> Feel free to test & commit
>> I don't think so.
> Well you have a funny way of disagreeing arriving to the same result as
> I told: replace
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f $< --keyword=_ --keyword=N_
> with
> cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
> -f po/POTFILES --keyword=_ --keyword=N_
> Have you tested it?
Yes, have you?
tar -xf grub-1.98.tar.gz
cd grub-1.98
mkdir build
cd build
../configure
#edit line 528 of Makefile as above
make
cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 -o
../po/grub.pot -f po/POTFILES --keyword=_ --keyword=N_
/usr/bin/xgettext: cannot create output file "../po/grub.pot": No such
file or directory
make: *** [../po/grub.pot] Error 1
As I said before, the error is that -o $@ is invalid because of the
change of directory.
-- Bruce
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <759fb688-e363-c442-e3cd-45b7b1a029ff@stlouisintegration.com>]
* Re: broken build
[not found] <759fb688-e363-c442-e3cd-45b7b1a029ff@stlouisintegration.com>
@ 2018-03-26 13:30 ` Wei Liu
0 siblings, 0 replies; 8+ messages in thread
From: Wei Liu @ 2018-03-26 13:30 UTC (permalink / raw)
To: Jacob Embree; +Cc: xen-devel, wei.liu2, ian.jackson
On Sat, Mar 24, 2018 at 04:20:14PM -0400, Jacob Embree wrote:
> This is a followup to https://xen.markmail.org/thread/6bzbtbbprexrli2f
>
> According to
> https://stackoverflow.com/questions/20369672/undefined-reference-to-dlsym
> a couple more flags are needed.
>
> commit 22c7e6d2204114c25625558e1f9634f264f9ac7c
> Author: Jacob Embree
> Date: Sat Mar 24 15:51:31 2018 -0400
>
> Fix LDFLAGS for libxenstore.so
>
> Signed-off-by: Jacob Embree
>
> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> index 69e55e7..1a636ee 100644
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -104,7 +104,7 @@ libxenstore.so.$(MAJOR): libxenstore.so.$(MAJOR).$(MINOR)
> xs.opic: CFLAGS += -DUSE_PTHREAD
> ifeq ($(CONFIG_Linux),y)
> xs.opic: CFLAGS += -DUSE_DLSYM
> -libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
> +libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -Wl,--no-as-needed,-ldl
> else
> PKG_CONFIG_REMOVE += -ldl
> endif
>
I think this is fixed by 1a3731949 with another method.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-26 13:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-17 16:14 Broken build Bruce Dubbs
2010-03-17 23:12 ` Carles Pina i Estany
2010-03-18 0:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-03-18 0:55 ` Bruce Dubbs
2010-03-26 14:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-03-26 14:45 ` richardvoigt
2010-03-27 4:10 ` Bruce Dubbs
[not found] <759fb688-e363-c442-e3cd-45b7b1a029ff@stlouisintegration.com>
2018-03-26 13:30 ` broken build Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.