To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: set proper level for printk in fs/super.c
Date: Mon, 22 Mar 2010 12:14:04 +0000 [thread overview]
Message-ID: <4BA75F0C.5050509@redflag-linux.com> (raw)
In-Reply-To: <20100320133848.GD5331@bicker>
On 03/20/2010 09:38 PM, Dan Carpenter wrote:
> On Sat, Mar 20, 2010 at 09:10:07PM +0800, "潘卫平(Peter Pan)" wrote:
>> Signed-off-by: Peter Pan(潘卫平)<wppan@redflag-linux.com>
>> ---
>> fs/super.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/super.c b/fs/super.c
>> index f35ac60..60d720f 100644
>> --- a/fs/super.c
>> +++ b/fs/super.c
>> @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb)
>>
>> /* Forget any remaining inodes */
>> if (invalidate_inodes(sb)) {
>> - printk("VFS: Busy inodes after unmount of %s. "
>> + printk(KERN_INFO "VFS: Busy inodes after unmount of %s. "
>> "Self-destruct in 5 seconds. Have a nice day...\n",
>
> I'm pretty sure that both of these should be a higher priority than
> KERN_INFO.
>
> regards,
> dan carpenter
>
>> sb->s_id);
>> }
>> @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct
>> *work)
>> }
>> spin_unlock(&sb_lock);
>> kfree(work);
>> - printk("Emergency Remount complete\n");
>> + printk(KERN_INFO "Emergency Remount complete\n");
>> }
>>
>> void emergency_remount(void)
>> --
>> 1.6.6
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Signed-off-by: 潘卫平(Peter Pan) <wppan@redflag-linux.com>
---
fs/super.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index f35ac60..baffd23 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb)
/* Forget any remaining inodes */
if (invalidate_inodes(sb)) {
- printk("VFS: Busy inodes after unmount of %s. "
+ printk(KERN_WARNING "VFS: Busy inodes after unmount of %s. "
"Self-destruct in 5 seconds. Have a nice day...\n",
sb->s_id);
}
@@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct
*work)
}
spin_unlock(&sb_lock);
kfree(work);
- printk("Emergency Remount complete\n");
+ printk(KERN_NOTICE "Emergency Remount complete\n");
}
void emergency_remount(void)
--
1.6.6
--
Peter Pan(潘卫平)
Red Flag Software Co.,Ltd
WARNING: multiple messages have this Message-ID (diff)
From: "\"潘卫平(Peter Pan)\"" <wppan@redflag-linux.com>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: set proper level for printk in fs/super.c
Date: Mon, 22 Mar 2010 20:14:04 +0800 [thread overview]
Message-ID: <4BA75F0C.5050509@redflag-linux.com> (raw)
In-Reply-To: <20100320133848.GD5331@bicker>
On 03/20/2010 09:38 PM, Dan Carpenter wrote:
> On Sat, Mar 20, 2010 at 09:10:07PM +0800, "潘卫平(Peter Pan)" wrote:
>> Signed-off-by: Peter Pan(潘卫平)<wppan@redflag-linux.com>
>> ---
>> fs/super.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/super.c b/fs/super.c
>> index f35ac60..60d720f 100644
>> --- a/fs/super.c
>> +++ b/fs/super.c
>> @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb)
>>
>> /* Forget any remaining inodes */
>> if (invalidate_inodes(sb)) {
>> - printk("VFS: Busy inodes after unmount of %s. "
>> + printk(KERN_INFO "VFS: Busy inodes after unmount of %s. "
>> "Self-destruct in 5 seconds. Have a nice day...\n",
>
> I'm pretty sure that both of these should be a higher priority than
> KERN_INFO.
>
> regards,
> dan carpenter
>
>> sb->s_id);
>> }
>> @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct
>> *work)
>> }
>> spin_unlock(&sb_lock);
>> kfree(work);
>> - printk("Emergency Remount complete\n");
>> + printk(KERN_INFO "Emergency Remount complete\n");
>> }
>>
>> void emergency_remount(void)
>> --
>> 1.6.6
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Signed-off-by: 潘卫平(Peter Pan) <wppan@redflag-linux.com>
---
fs/super.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index f35ac60..baffd23 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb)
/* Forget any remaining inodes */
if (invalidate_inodes(sb)) {
- printk("VFS: Busy inodes after unmount of %s. "
+ printk(KERN_WARNING "VFS: Busy inodes after unmount of %s. "
"Self-destruct in 5 seconds. Have a nice day...\n",
sb->s_id);
}
@@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct
*work)
}
spin_unlock(&sb_lock);
kfree(work);
- printk("Emergency Remount complete\n");
+ printk(KERN_NOTICE "Emergency Remount complete\n");
}
void emergency_remount(void)
--
1.6.6
--
Peter Pan(潘卫平)
Red Flag Software Co.,Ltd
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2010-03-22 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BA4C92F.5070007@redflag-linux.com>
[not found] ` <20100320133848.GD5331@bicker>
2010-03-22 12:14 ` [this message]
2010-03-22 12:14 ` [PATCH] vfs: set proper level for printk in fs/super.c "潘卫平(Peter Pan)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA75F0C.5050509@redflag-linux.com \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.