From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian
Date: Wed, 21 Apr 2010 11:15:13 +0000 [thread overview]
Message-ID: <4BCEDE41.1070100@redhat.com> (raw)
In-Reply-To: <20100420200043.956302db.yoshikawa.takuya@oss.ntt.co.jp>
On 04/20/2010 02:00 PM, Takuya Yoshikawa wrote:
> We are now using generic___set_le_bit() to make dirty bitmaps le.
> Though this works well, we have to replace __set_bit() to appropriate
> uaccess function to move dirty bitmaps to user space. So this patch
> splits generic___set_le_bit() and prepares for that.
>
>
> +static int __mark_page_dirty(unsigned long nr,
> + unsigned long *dirty_bitmap)
> +{
> +#ifdef __BIG_ENDIAN
> + nr = nr ^ BITOP_LE_SWIZZLE;
> +#endif
> + __set_bit(nr, dirty_bitmap);
>
Why not introduce __set_le_bit_user() along with __set_bit_user()? kvm
shouldn't do endian corrections when they can be done in generic code.
> +}
> +
> void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> {
> struct kvm_memory_slot *memslot;
> @@ -1203,11 +1212,8 @@ void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> if (memslot&& memslot->dirty_bitmap) {
> unsigned long rel_gfn = gfn - memslot->base_gfn;
>
> - /* avoid RMW */
> - if (!generic_test_le_bit(rel_gfn, memslot->dirty_bitmap)) {
> - generic___set_le_bit(rel_gfn, memslot->dirty_bitmap);
> - memslot->is_dirty = true;
> - }
>
You're also dropping the RMW avoidance. This is fine, but deserves at
least a note in the changelog (or a separate patch).
> + __mark_page_dirty(rel_gfn, memslot->dirty_bitmap);
> + memslot->is_dirty = true;
> }
> }
>
>
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
kvm-ia64@vger.kernel.org, kvm-ppc@vger.kernel.org,
fernando@oss.ntt.co.jp
Subject: Re: [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian
Date: Wed, 21 Apr 2010 11:15:13 +0000 [thread overview]
Message-ID: <4BCEDE41.1070100@redhat.com> (raw)
In-Reply-To: <20100420200043.956302db.yoshikawa.takuya@oss.ntt.co.jp>
On 04/20/2010 02:00 PM, Takuya Yoshikawa wrote:
> We are now using generic___set_le_bit() to make dirty bitmaps le.
> Though this works well, we have to replace __set_bit() to appropriate
> uaccess function to move dirty bitmaps to user space. So this patch
> splits generic___set_le_bit() and prepares for that.
>
>
> +static int __mark_page_dirty(unsigned long nr,
> + unsigned long *dirty_bitmap)
> +{
> +#ifdef __BIG_ENDIAN
> + nr = nr ^ BITOP_LE_SWIZZLE;
> +#endif
> + __set_bit(nr, dirty_bitmap);
>
Why not introduce __set_le_bit_user() along with __set_bit_user()? kvm
shouldn't do endian corrections when they can be done in generic code.
> +}
> +
> void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> {
> struct kvm_memory_slot *memslot;
> @@ -1203,11 +1212,8 @@ void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> if (memslot&& memslot->dirty_bitmap) {
> unsigned long rel_gfn = gfn - memslot->base_gfn;
>
> - /* avoid RMW */
> - if (!generic_test_le_bit(rel_gfn, memslot->dirty_bitmap)) {
> - generic___set_le_bit(rel_gfn, memslot->dirty_bitmap);
> - memslot->is_dirty = true;
> - }
>
You're also dropping the RMW avoidance. This is fine, but deserves at
least a note in the changelog (or a separate patch).
> + __mark_page_dirty(rel_gfn, memslot->dirty_bitmap);
> + memslot->is_dirty = true;
> }
> }
>
>
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
kvm-ia64@vger.kernel.org, kvm-ppc@vger.kernel.org,
fernando@oss.ntt.co.jp
Subject: Re: [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly
Date: Wed, 21 Apr 2010 14:15:13 +0300 [thread overview]
Message-ID: <4BCEDE41.1070100@redhat.com> (raw)
In-Reply-To: <20100420200043.956302db.yoshikawa.takuya@oss.ntt.co.jp>
On 04/20/2010 02:00 PM, Takuya Yoshikawa wrote:
> We are now using generic___set_le_bit() to make dirty bitmaps le.
> Though this works well, we have to replace __set_bit() to appropriate
> uaccess function to move dirty bitmaps to user space. So this patch
> splits generic___set_le_bit() and prepares for that.
>
>
> +static int __mark_page_dirty(unsigned long nr,
> + unsigned long *dirty_bitmap)
> +{
> +#ifdef __BIG_ENDIAN
> + nr = nr ^ BITOP_LE_SWIZZLE;
> +#endif
> + __set_bit(nr, dirty_bitmap);
>
Why not introduce __set_le_bit_user() along with __set_bit_user()? kvm
shouldn't do endian corrections when they can be done in generic code.
> +}
> +
> void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> {
> struct kvm_memory_slot *memslot;
> @@ -1203,11 +1212,8 @@ void mark_page_dirty(struct kvm *kvm, gfn_t gfn)
> if (memslot&& memslot->dirty_bitmap) {
> unsigned long rel_gfn = gfn - memslot->base_gfn;
>
> - /* avoid RMW */
> - if (!generic_test_le_bit(rel_gfn, memslot->dirty_bitmap)) {
> - generic___set_le_bit(rel_gfn, memslot->dirty_bitmap);
> - memslot->is_dirty = true;
> - }
>
You're also dropping the RMW avoidance. This is fine, but deserves at
least a note in the changelog (or a separate patch).
> + __mark_page_dirty(rel_gfn, memslot->dirty_bitmap);
> + memslot->is_dirty = true;
> }
> }
>
>
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-21 11:15 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 10:57 [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-20 11:00 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Takuya Yoshikawa
2010-04-20 10:57 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-20 11:00 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Alexander Graf
2010-04-20 11:00 ` Alexander Graf
2010-04-20 11:00 ` Alexander Graf
2010-04-20 11:20 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-20 11:20 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Takuya Yoshikawa
2010-04-20 11:20 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Takuya Yoshikawa
2010-04-21 11:15 ` Avi Kivity [this message]
2010-04-21 11:15 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian issues explicitly Avi Kivity
2010-04-21 11:15 ` [PATCH RFC v2 4/6] KVM: change mark_page_dirty() to handle endian Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2010-04-20 11:03 [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-20 11:03 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Takuya Yoshikawa
2010-04-20 11:03 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-20 11:15 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-20 11:15 ` Alexander Graf
2010-04-20 11:15 ` Alexander Graf
2010-04-20 11:33 ` Alexander Graf
2010-04-20 11:33 ` Alexander Graf
2010-04-20 11:33 ` Alexander Graf
2010-04-20 11:33 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-20 11:33 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Takuya Yoshikawa
2010-04-20 11:33 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-20 11:44 ` Takuya Yoshikawa
2010-04-20 11:44 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Takuya Yoshikawa
2010-04-20 11:44 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-21 8:29 `
2010-04-21 8:29 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Fernando Luis Vázquez Cao
2010-04-21 8:29 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty
2010-04-21 9:41 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-21 9:41 ` Alexander Graf
2010-04-21 9:41 ` Alexander Graf
2010-04-21 11:46 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-21 11:46 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-21 11:46 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-22 2:45 `
2010-04-22 2:45 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Fernando Luis Vázquez Cao
2010-04-22 2:45 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty
2010-04-22 6:09 `
2010-04-22 6:09 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Fernando Luis Vázquez Cao
2010-04-22 6:09 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty
2010-04-22 9:34 ` Takuya Yoshikawa
2010-04-22 9:34 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Takuya Yoshikawa
2010-04-22 9:34 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Takuya Yoshikawa
2010-04-22 23:29 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-22 23:29 ` Alexander Graf
2010-04-22 23:29 ` Alexander Graf
2010-04-23 10:17 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty
2010-04-23 10:17 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Fernando Luis Vázquez Cao
2010-04-23 10:17 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty
2010-04-23 10:20 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-23 10:20 ` Alexander Graf
2010-04-23 10:20 ` Alexander Graf
2010-04-23 11:57 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 11:57 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-23 11:57 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 11:58 ` Avi Kivity
2010-04-23 11:58 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-23 11:58 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 12:26 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-23 12:26 ` Alexander Graf
2010-04-23 12:26 ` Alexander Graf
2010-04-23 12:27 ` Arnd Bergmann
2010-04-23 12:27 ` Arnd Bergmann
2010-04-23 12:27 ` Arnd Bergmann
2010-04-23 12:42 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 12:42 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-23 12:42 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 12:46 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Arnd Bergmann
2010-04-23 12:46 ` Arnd Bergmann
2010-04-23 12:46 ` Arnd Bergmann
2010-04-23 12:53 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 12:53 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-23 12:53 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 12:59 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Alexander Graf
2010-04-23 12:59 ` Alexander Graf
2010-04-23 12:59 ` Alexander Graf
2010-04-23 13:12 ` Arnd Bergmann
2010-04-23 13:12 ` Arnd Bergmann
2010-04-23 13:12 ` Arnd Bergmann
2010-04-23 13:20 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-23 13:20 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty bitmaps Avi Kivity
2010-04-23 13:20 ` [PATCH RFC v2 6/6] KVM: introduce a new API for getting dirty Avi Kivity
2010-04-20 10:59 [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty Takuya Yoshikawa
2010-04-20 10:59 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Takuya Yoshikawa
2010-04-20 10:59 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty Takuya Yoshikawa
2010-04-21 11:12 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Avi Kivity
2010-04-21 11:12 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Avi Kivity
2010-04-21 11:12 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Avi Kivity
2010-04-22 8:57 ` Takuya Yoshikawa
2010-04-22 8:57 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Takuya Yoshikawa
2010-04-22 8:57 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Takuya Yoshikawa
2010-04-23 10:26 ` Avi Kivity
2010-04-23 10:26 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Avi Kivity
2010-04-23 10:26 ` [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Avi Kivity
2010-04-20 10:58 [PATCH RFC v2 5/6] KVM: moving dirty bitmaps to user space Takuya Yoshikawa
2010-04-20 11:02 ` Takuya Yoshikawa
2010-04-20 10:58 ` Takuya Yoshikawa
2010-04-20 11:10 ` Alexander Graf
2010-04-20 11:10 ` Alexander Graf
2010-04-20 11:10 ` Alexander Graf
2010-04-20 11:26 ` Takuya Yoshikawa
2010-04-20 11:26 ` Takuya Yoshikawa
2010-04-20 11:26 ` Takuya Yoshikawa
2010-04-21 11:26 ` Avi Kivity
2010-04-21 11:26 ` Avi Kivity
2010-04-21 11:26 ` Avi Kivity
2010-04-22 9:07 ` Takuya Yoshikawa
2010-04-22 9:07 ` Takuya Yoshikawa
2010-04-22 9:07 ` Takuya Yoshikawa
2010-04-23 10:28 ` Avi Kivity
2010-04-23 10:28 ` Avi Kivity
2010-04-23 10:28 ` Avi Kivity
2010-04-23 11:14 ` Takuya Yoshikawa
2010-04-23 11:14 ` Takuya Yoshikawa
2010-04-23 11:14 ` Takuya Yoshikawa
2010-04-23 11:29 ` Yoshiaki Tamura
2010-04-23 11:29 ` Yoshiaki Tamura
2010-04-23 11:29 ` Yoshiaki Tamura
2010-04-23 11:45 ` Avi Kivity
2010-04-23 11:45 ` Avi Kivity
2010-04-23 11:45 ` Avi Kivity
2010-04-20 10:57 [PATCH RFC v2 2/6] KVM: introduce wrapper functions to create and Takuya Yoshikawa
2010-04-20 10:57 ` [PATCH RFC v2 2/6] KVM: introduce wrapper functions to create and destroy dirty bitmaps Takuya Yoshikawa
2010-04-20 10:57 ` [PATCH RFC v2 2/6] KVM: introduce wrapper functions to create and Takuya Yoshikawa
2010-04-20 10:56 [PATCH RFC v2 1/6] KVM: introduce slot level dirty state management Takuya Yoshikawa
2010-04-20 10:56 ` Takuya Yoshikawa
2010-04-20 10:56 ` Takuya Yoshikawa
2010-04-20 10:53 [PATCH RFC v2 0/6] KVM: moving dirty gitmaps to user space! Takuya Yoshikawa
2010-04-20 10:53 ` Takuya Yoshikawa
2010-04-20 10:53 ` Takuya Yoshikawa
2010-04-20 10:54 ` Alexander Graf
2010-04-20 10:54 ` Alexander Graf
2010-04-20 10:54 ` Alexander Graf
2010-04-20 11:13 ` Takuya Yoshikawa
2010-04-20 11:13 ` Takuya Yoshikawa
2010-04-20 11:13 ` Takuya Yoshikawa
2010-04-20 12:05 ` Takuya Yoshikawa
2010-04-20 12:05 ` Takuya Yoshikawa
2010-04-20 12:05 ` Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCEDE41.1070100@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.