From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>
Subject: Re: [PATCHv2 0/4] Add "xl info" command
Date: Wed, 21 Apr 2010 15:56:58 +0100 [thread overview]
Message-ID: <4BCF123A.3000509@eu.citrix.com> (raw)
In-Reply-To: <1271859446-25892-1-git-send-email-andre.przywara@amd.com>
On 21/04/10 15:17, Andre Przywara wrote:
> The "info" subcommand is missing from the xl tool.
> The attached patchset adds support for this, extending libxl on the way
> to provide the necessary info only by using own functions.
> On my system the output of xm info and xl info was identical, I omitted
> the recent NUMA additions from xl info for now and will provide the
> necessary patches later.
>
> Reworked version due to comments from Ian and Vincent (thanks for the review!)
> Changes to version 1:
> - use Xen public headers for constants instead of (re-)defining them
> - comment the meaning of the return value of get_sched_id()
> - remove the masking feature for get_version_info
> - make the version_info structure a member of libxl_ctx and fill it
> on demand, omitting the need to free it manually
all patches:
Acked-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
Thanks for your contribution !
--
Vincent
prev parent reply other threads:[~2010-04-21 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 14:17 [PATCHv2 0/4] Add "xl info" command Andre Przywara
2010-04-21 14:17 ` [PATCHv2 1/4] libxl: extend physinfo structure Andre Przywara
2010-04-22 8:03 ` Paolo Bonzini
2010-04-22 11:14 ` Ian Jackson
2010-04-22 11:15 ` Ian Jackson
2010-04-22 15:26 ` Stefano Stabellini
2010-04-21 14:17 ` [PATCHv2 2/4] libxl: add sched_get_id function Andre Przywara
2010-04-21 14:17 ` [PATCHv2 3/4] libxl: add version_info function Andre Przywara
2010-04-21 15:01 ` Vincent Hanquez
2010-04-21 19:34 ` [PATCHv2a " Andre Przywara
2010-04-21 19:35 ` [PATCHv2 " Andre Przywara
2010-04-21 14:17 ` [PATCHv2 4/4] xl: add "xl info" command Andre Przywara
2010-04-21 14:56 ` Vincent Hanquez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCF123A.3000509@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.