From: Paolo Bonzini <pbonzini@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: vincent.hanquez@eu.citrix.com, xen-devel@lists.xensource.com,
Ian.Jackson@eu.citrix.com, Keir.Fraser@eu.citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCHv2 1/4] libxl: extend physinfo structure
Date: Thu, 22 Apr 2010 10:03:18 +0200 [thread overview]
Message-ID: <4BD002C6.5040701@redhat.com> (raw)
In-Reply-To: <1271859446-25892-2-git-send-email-andre.przywara@amd.com>
On 04/21/2010 04:17 PM, Andre Przywara wrote:
> The libxl version of the physinfo sysctl does not contain some
> fields like nr_nodes or capabilities needed for xl info output.
> Add them to the structure and the retrieving function.
Vincent, Stefano, is it okay to break the ABI?
If so, I suggest adding an initial member to be filled with sizeof() of
the structure, similar to many Win32 APIs like GetVersionEx.
http://msdn.microsoft.com/en-us/library/ms724451%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724834%28VS.85%29.aspx
http://msdn.microsoft.com/en-us/library/ms724833%28VS.85%29.aspx
Paolo
next prev parent reply other threads:[~2010-04-22 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 14:17 [PATCHv2 0/4] Add "xl info" command Andre Przywara
2010-04-21 14:17 ` [PATCHv2 1/4] libxl: extend physinfo structure Andre Przywara
2010-04-22 8:03 ` Paolo Bonzini [this message]
2010-04-22 11:14 ` Ian Jackson
2010-04-22 11:15 ` Ian Jackson
2010-04-22 15:26 ` Stefano Stabellini
2010-04-21 14:17 ` [PATCHv2 2/4] libxl: add sched_get_id function Andre Przywara
2010-04-21 14:17 ` [PATCHv2 3/4] libxl: add version_info function Andre Przywara
2010-04-21 15:01 ` Vincent Hanquez
2010-04-21 19:34 ` [PATCHv2a " Andre Przywara
2010-04-21 19:35 ` [PATCHv2 " Andre Przywara
2010-04-21 14:17 ` [PATCHv2 4/4] xl: add "xl info" command Andre Przywara
2010-04-21 14:56 ` [PATCHv2 0/4] Add " Vincent Hanquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD002C6.5040701@redhat.com \
--to=pbonzini@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vincent.hanquez@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.