Re: [PATCH] Fix Cygwin path handling

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

Christian Franke wrote:
> The Cywin path handling is broken since
> make_system_path_relative_to_its_root() functionality was moved from
> the lib script to misc.c.
>
> This patch should fix this. It reuses the Cygwin specific code from
> getroot.c:grub_get_prefix() which apparently is a different
> implementation of the same function.
>
> I would suggest to remove grub_get_prefix(), it is now only used in
> grub-emu.c and sparc64/ieee1275/grub-setup.c. Not included in the
> patch, should be done in a separate commit.
>
>
> 2010-04-14  Christian Franke<franke@computer.org>
>
>     * util/grub-mkconfig_lib.in (make_system_path_relative_to_its_root):
>     Remove broken Cygwin path conversion.
>     * util/misc.c: [__CYGWIN__] Add include and define.
>     [__CYGWIN__] (get_win32_path): Copy function from getroot.c, modify
>     for Cygwin 1.7.
>     (make_system_path_relative_to_its_root): Simplify loop, replace early
>     return by break.
>     [__CYGWIN__] Add conversion to win32 path.
>

+	  /* Include leading slash.  */
+	  offset = 0;
+	  break;
Why do you make this change? It seems to make the behaviour of make_path_relative_to_its root inconsistent since E.g.
/boot/grub -> grub
/etc -> /etc
Can we decide to either always include this slash or never to? I prefer never to include it since it's the way it is now and I prefer to keep it to avoid possible breakage.

>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]