Re: [PATCH] Fix Cygwin path handling

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Christian Franke wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> Christian Franke wrote:
>>   
>>>      
>> +      /* Include leading slash.  */
>> +      offset = 0;
>> +      break;
>> Why do you make this change? It seems to make the behaviour of
>> make_path_relative_to_its root inconsistent since E.g.
>> /boot/grub ->  grub
>> /etc ->  /etc
>>    
>
> Could not reproduce. Old and new code always include the leading slash
> (except "/" -> ''").
>
I actually seen the '/' case and have incorrectly assumed it's always
so. However there is still one case when you patch changes the behaviour:
$ grub-mkrelpath /

$ ./grub-mkrelpath /
/
Although:
$ ./grub-mkrelpath /mnt/boot/

$ grub-mkrelpath /mnt/boot/


A simple filter at the end of make_path_relative_to_its_root is enough.
Just it's better to avoid both inconsistency between mountpoint and root
and behaviour change

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]