* [PATCH 1/2] libata: don't flush dcache on slab pages
@ 2010-03-21 21:52 Sebastian Andrzej Siewior
2010-04-19 19:46 ` Sebastian Andrzej Siewior
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2010-03-21 21:52 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide
page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
with the according debuging turned on.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
drivers/ata/libata-sff.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 561dec2..83ecf48 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
do_write);
}
- if (!do_write)
+ if (!do_write && !PageSlab(page))
flush_dcache_page(page);
qc->curbytes += qc->sect_size;
--
1.6.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] libata: don't flush dcache on slab pages
2010-03-21 21:52 [PATCH 1/2] libata: don't flush dcache on slab pages Sebastian Andrzej Siewior
@ 2010-04-19 19:46 ` Sebastian Andrzej Siewior
2010-04-19 19:55 ` David Miller
2010-04-28 20:06 ` Sebastian Andrzej Siewior
2010-05-14 21:50 ` Jeff Garzik
2 siblings, 1 reply; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2010-04-19 19:46 UTC (permalink / raw)
To: David S. Miller; +Cc: Jeff Garzik, linux-ide
* Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]:
>page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
>with the according debuging turned on.
David, I've seen that you set this patch to "Not Applicable". May I know
why?
Sebastian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] libata: don't flush dcache on slab pages
2010-04-19 19:46 ` Sebastian Andrzej Siewior
@ 2010-04-19 19:55 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2010-04-19 19:55 UTC (permalink / raw)
To: sebastian; +Cc: jgarzik, linux-ide
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Mon, 19 Apr 2010 21:46:18 +0200
> * Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]:
>
>>page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
>>with the according debuging turned on.
>
> David, I've seen that you set this patch to "Not Applicable". May I know
> why?
Because the linux-ide patchwork is for IDE patches, not ATA
stuff.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] libata: don't flush dcache on slab pages
2010-03-21 21:52 [PATCH 1/2] libata: don't flush dcache on slab pages Sebastian Andrzej Siewior
2010-04-19 19:46 ` Sebastian Andrzej Siewior
@ 2010-04-28 20:06 ` Sebastian Andrzej Siewior
2010-04-29 0:16 ` Jeff Garzik
2010-05-14 21:50 ` Jeff Garzik
2 siblings, 1 reply; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2010-04-28 20:06 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide
* Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]:
>page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
>with the according debuging turned on.
>
>Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Jeff, a month passed since I posted this patch. Any reason why you
ignore it?
> drivers/ata/libata-sff.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
>index 561dec2..83ecf48 100644
>--- a/drivers/ata/libata-sff.c
>+++ b/drivers/ata/libata-sff.c
>@@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
> do_write);
> }
>
>- if (!do_write)
>+ if (!do_write && !PageSlab(page))
> flush_dcache_page(page);
>
> qc->curbytes += qc->sect_size;
>--
>1.6.6
Sebastian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] libata: don't flush dcache on slab pages
2010-04-28 20:06 ` Sebastian Andrzej Siewior
@ 2010-04-29 0:16 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-04-29 0:16 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-ide
On 04/28/2010 04:06 PM, Sebastian Andrzej Siewior wrote:
> * Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]:
>
>> page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
>> with the according debuging turned on.
>>
>> Signed-off-by: Sebastian Andrzej Siewior<sebastian@breakpoint.cc>
>
> Jeff, a month passed since I posted this patch. Any reason why you
> ignore it?
Typically I wait a couple weeks for the Architecture maintainers to
voice their objections, if any, on a patch like this.
No objections emerged that weren't addressed so far, we can probably
push this in.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] libata: don't flush dcache on slab pages
2010-03-21 21:52 [PATCH 1/2] libata: don't flush dcache on slab pages Sebastian Andrzej Siewior
2010-04-19 19:46 ` Sebastian Andrzej Siewior
2010-04-28 20:06 ` Sebastian Andrzej Siewior
@ 2010-05-14 21:50 ` Jeff Garzik
2 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-05-14 21:50 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-ide
On 03/21/2010 05:52 PM, Sebastian Andrzej Siewior wrote:
> page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
> with the according debuging turned on.
>
> Signed-off-by: Sebastian Andrzej Siewior<sebastian@breakpoint.cc>
> ---
> drivers/ata/libata-sff.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 561dec2..83ecf48 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
> do_write);
> }
>
> - if (!do_write)
> + if (!do_write&& !PageSlab(page))
> flush_dcache_page(page);
applied #upstream, cc'ing stable@kernel.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-14 21:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-21 21:52 [PATCH 1/2] libata: don't flush dcache on slab pages Sebastian Andrzej Siewior
2010-04-19 19:46 ` Sebastian Andrzej Siewior
2010-04-19 19:55 ` David Miller
2010-04-28 20:06 ` Sebastian Andrzej Siewior
2010-04-29 0:16 ` Jeff Garzik
2010-05-14 21:50 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.