Re: [patch] i915: missing unlock on error path

[Jiri Slaby <jirislaby@gmail.com>]

On 05/07/2010 10:37 AM, Dan Carpenter wrote:
> There was a missing mutex_unlock(&dev->struct_mutex) on this error path.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I thought Jiri sent this patch earlier but a google search for "stanse
> struct_mutex i965_reset" didn't find any patches, so I'm resending.

I don't remember either. I found I had only fixed potential NULL-deref
in i915_suspend.

> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 01e91ea..a605c87 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags)
>  		}
>  	} else {
>  		DRM_ERROR("Error occurred. Don't know how to reset this chip.\n");
> +		mutex_unlock(&dev->struct_mutex);
>  		return -ENODEV;
>  	}
>  


-- 
js

------------------------------------------------------------------------------

--