From: Eric Anholt <eric@anholt.net>
To: Dan Carpenter <error27@gmail.com>, David Airlie <airlied@linux.ie>
Cc: Høgsberg <krh@bitplanet.net>,
jirislaby@gmail.com, "Jesse Barnes" <jbarnes@virtuousgeek.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [patch] i915: missing unlock on error path
Date: Wed, 26 May 2010 14:18:30 -0700 [thread overview]
Message-ID: <87632al5uh.fsf@pollan.anholt.net> (raw)
In-Reply-To: <20100507083701.GW27064@bicker>
[-- Attachment #1.1: Type: text/plain, Size: 954 bytes --]
On Fri, 7 May 2010 10:37:01 +0200, Dan Carpenter <error27@gmail.com> wrote:
> There was a missing mutex_unlock(&dev->struct_mutex) on this error path.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> I thought Jiri sent this patch earlier but a google search for "stanse
> struct_mutex i965_reset" didn't find any patches, so I'm resending.
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 01e91ea..a605c87 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags)
> }
> } else {
> DRM_ERROR("Error occurred. Don't know how to reset this chip.\n");
> + mutex_unlock(&dev->struct_mutex);
> return -ENODEV;
> }
>
Heh, got another version of this patch from Daniel J Blueman and ended
up applying his first as I went through my tag:todo list. Thanks,
though!
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 80 bytes --]
------------------------------------------------------------------------------
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
prev parent reply other threads:[~2010-05-26 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 8:37 [patch] i915: missing unlock on error path Dan Carpenter
2010-05-07 8:43 ` Jiri Slaby
2010-05-26 21:18 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87632al5uh.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=error27@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jirislaby@gmail.com \
--cc=krh@bitplanet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.