All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, USB list <linux-usb@vger.kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Takashi Iwai <tiwai@suse.de>, Greg KH <gregkh@suse.de>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	iommu@lists.linux-foundation.org,
	Andi Kleen <andi@firstfloor.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Pedro Ribeiro <pedrib@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: USB transfer_buffer allocations on 64bit systems
Date: Fri, 07 May 2010 11:47:37 +0200	[thread overview]
Message-ID: <4BE3E1B9.5020602@ladisch.de> (raw)
In-Reply-To: <20100507074855.GF30801@buzzloop.caiaq.de>

Daniel Mack wrote:
> The problem is again (summarized):
> 
> On 64bit machines, with 4GB or more, the allocated buffers for USB
> transfers might be beyond the 32bit boundary. In this case, the IOMMU
> should take care and install DMA bounce buffer to copy over the buffer
> before the transfer actually happens. The problem is, however, that this
> copy mechanism takes place when the URB with its associated buffer is
> submitted, not when the EHCI will actually do the transfer.
> 
> In the particular case of audio drivers, though, the contents of the
> buffers are likely to change after the submission. What we do here
> is that we map the audio stream buffers which are used by ALSA to
> the output URBs, so they're filled asychronously. Once the buffer is
> actually sent out on the bus, it is believed to contain proper audio
> date. If it doesn't, that's due to too tight audio timing or other
> problems. This breaks once buffers are magically bounced in the
> background.

At least the audio class and ua101 drivers don't do this and fill the
buffers before they are submitted.

> So - long story short: these audio buffers need to be DMA coherent.

Does the USB API actually guarantee that all controllers use DMA, i.e.,
that the buffers can be filled after submission?


Regards,
Clemens

WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, Greg KH <gregkh@suse.de>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	USB list <linux-usb@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	iommu@lists.linux-foundation.org,
	Andi Kleen <andi@firstfloor.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Pedro Ribeiro <pedrib@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [alsa-devel] USB transfer_buffer allocations on 64bit systems
Date: Fri, 07 May 2010 11:47:37 +0200	[thread overview]
Message-ID: <4BE3E1B9.5020602@ladisch.de> (raw)
In-Reply-To: <20100507074855.GF30801@buzzloop.caiaq.de>

Daniel Mack wrote:
> The problem is again (summarized):
> 
> On 64bit machines, with 4GB or more, the allocated buffers for USB
> transfers might be beyond the 32bit boundary. In this case, the IOMMU
> should take care and install DMA bounce buffer to copy over the buffer
> before the transfer actually happens. The problem is, however, that this
> copy mechanism takes place when the URB with its associated buffer is
> submitted, not when the EHCI will actually do the transfer.
> 
> In the particular case of audio drivers, though, the contents of the
> buffers are likely to change after the submission. What we do here
> is that we map the audio stream buffers which are used by ALSA to
> the output URBs, so they're filled asychronously. Once the buffer is
> actually sent out on the bus, it is believed to contain proper audio
> date. If it doesn't, that's due to too tight audio timing or other
> problems. This breaks once buffers are magically bounced in the
> background.

At least the audio class and ua101 drivers don't do this and fill the
buffers before they are submitted.

> So - long story short: these audio buffers need to be DMA coherent.

Does the USB API actually guarantee that all controllers use DMA, i.e.,
that the buffers can be filled after submission?


Regards,
Clemens

  reply	other threads:[~2010-05-07  9:47 UTC|newest]

Thread overview: 221+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07  9:06 USB transfer_buffer allocations on 64bit systems Daniel Mack
2010-04-07  9:06 ` Daniel Mack
     [not found] ` <p2g581ef6d61004070220z1153d40ez955b356e01220848@mail.gmail.com>
2010-04-07  9:26   ` USB HID gadget driver (was: Re: USB transfer_buffer allocations on 64bit systems) Daniel Mack
2010-04-07  9:26     ` Daniel Mack
2010-04-07 14:59 ` USB transfer_buffer allocations on 64bit systems Alan Stern
2010-04-07 14:59   ` Alan Stern
2010-04-07 15:11   ` Daniel Mack
2010-04-07 15:11     ` Daniel Mack
2010-04-07 15:31     ` Greg KH
2010-04-07 15:31       ` Greg KH
2010-04-07 15:35       ` Daniel Mack
2010-04-07 15:35         ` Daniel Mack
2010-04-07 15:51         ` Greg KH
2010-04-07 15:51           ` Greg KH
     [not found]           ` <20100407155122.GA13974-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-04-07 16:04             ` Alan Stern
2010-04-07 16:04               ` Alan Stern
2010-04-08  6:09         ` Oliver Neukum
     [not found]           ` <201004080809.11756.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-04-08 11:07             ` Daniel Mack
2010-04-08 11:07               ` Daniel Mack
2010-04-07 15:55       ` Alan Stern
2010-04-07 15:55         ` Alan Stern
2010-04-07 16:16         ` Daniel Mack
2010-04-07 16:16           ` Daniel Mack
2010-04-07 16:47           ` Alan Stern
2010-04-07 16:47             ` Alan Stern
2010-04-07 17:55           ` Takashi Iwai
2010-04-07 17:55             ` Takashi Iwai
2010-04-07 17:59             ` Daniel Mack
2010-04-07 17:59               ` Daniel Mack
2010-04-07 18:06               ` Takashi Iwai
2010-04-07 18:06                 ` Takashi Iwai
2010-04-07 19:13             ` Alan Stern
2010-04-07 19:13               ` Alan Stern
2010-04-08  0:33               ` Greg KH
2010-04-08  0:33                 ` Greg KH
2010-04-09  0:01                 ` Robert Hancock
     [not found]                   ` <4BBE6E57.6020600-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-04-09 16:50                     ` Sarah Sharp
2010-04-09 16:50                       ` Sarah Sharp
2010-04-09 23:38                       ` Robert Hancock
2010-04-09 23:38                         ` Robert Hancock
2010-04-10  8:34                         ` Daniel Mack
2010-04-10  8:34                           ` [alsa-devel] " Daniel Mack
2010-04-10 17:02                           ` Robert Hancock
2010-04-12 18:56                             ` Sarah Sharp
2010-04-12 20:39                               ` Robert Hancock
2010-04-12 20:39                                 ` Robert Hancock
2010-04-12 20:58                                 ` Sarah Sharp
     [not found]               ` <Pine.LNX.4.44L0.1004071452560.5760-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-07 23:59                 ` Robert Hancock
2010-04-07 23:59                   ` Robert Hancock
2010-04-12 11:17                 ` [PATCH] USB: rename usb_buffer_alloc() and usb_buffer_free() Daniel Mack
2010-04-12 11:17                   ` Daniel Mack
     [not found]                   ` <1271071045-3112-1-git-send-email-daniel-rDUAYElUppE@public.gmane.org>
2010-04-13 18:16                     ` Daniel Mack
2010-04-13 18:16                       ` Daniel Mack
     [not found]                       ` <20100413181631.GT30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-13 19:27                         ` Alan Stern
2010-04-13 19:27                           ` Alan Stern
2010-04-13 20:26                           ` Greg KH
2010-04-13 21:47                             ` Daniel Mack
2010-04-13 21:47                               ` Daniel Mack
2010-04-07 17:52         ` USB transfer_buffer allocations on 64bit systems Takashi Iwai
2010-04-07 17:52           ` Takashi Iwai
2010-04-07 15:46     ` Alan Stern
2010-04-07 15:46       ` Alan Stern
2010-04-08  6:12       ` Oliver Neukum
     [not found]         ` <201004080812.04419.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-04-08 16:59           ` Alan Stern
2010-04-08 16:59             ` Alan Stern
2010-04-08 21:24             ` Oliver Neukum
2010-04-08 22:20               ` Alan Stern
2010-04-08 22:20                 ` Alan Stern
2010-04-09  6:04                 ` Oliver Neukum
     [not found]                   ` <201004090804.36213.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-04-09 14:41                     ` Alan Stern
2010-04-09 14:41                       ` Alan Stern
     [not found]                       ` <Pine.LNX.4.44L0.1004091033150.1852-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-09 14:50                         ` Oliver Neukum
2010-04-09 14:50                           ` Oliver Neukum
     [not found]                           ` <201004091650.31488.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-04-09 15:15                             ` Alan Stern
2010-04-09 15:15                               ` Alan Stern
     [not found]                               ` <Pine.LNX.4.44L0.1004091114500.1852-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-09 20:51                                 ` Oliver Neukum
2010-04-09 20:51                                   ` Oliver Neukum
2010-04-09 21:21                                   ` Alan Stern
2010-04-09 21:21                                     ` Alan Stern
     [not found]   ` <Pine.LNX.4.44L0.1004071036060.1779-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-07 16:54     ` Oliver Neukum
2010-04-07 16:54       ` Oliver Neukum
     [not found]       ` <201004071854.55530.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-04-07 17:00         ` Daniel Mack
2010-04-07 17:00           ` Daniel Mack
2010-04-07 23:55     ` Robert Hancock
2010-04-07 23:55       ` Robert Hancock
     [not found]       ` <4BBD1B6F.3000205-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-04-08  2:10         ` Alan Stern
2010-04-08  2:10           ` Alan Stern
2010-04-08  7:30           ` Daniel Mack
2010-04-08  7:30             ` Daniel Mack
     [not found]             ` <20100408073041.GO30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-08 16:57               ` Alan Stern
2010-04-08 16:57                 ` Alan Stern
2010-04-08 17:17                 ` Pedro Ribeiro
2010-04-08 18:17                   ` Alan Stern
     [not found]                 ` <Pine.LNX.4.44L0.1004081245330.1720-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-08 23:13                   ` Pedro Ribeiro
2010-04-08 23:13                     ` Pedro Ribeiro
2010-04-09 16:01                     ` Alan Stern
2010-04-09 16:01                       ` Alan Stern
2010-04-09 18:09                       ` Daniel Mack
     [not found]                         ` <20100409180942.GK30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-09 18:19                           ` Pedro Ribeiro
2010-04-09 18:19                             ` Pedro Ribeiro
     [not found]                             ` <w2r74fd948d1004091119j9f33d8a6kc1824d9243abf38b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-09 19:34                               ` Alan Stern
2010-04-09 19:34                                 ` Alan Stern
2010-04-09 20:14                                 ` Daniel Mack
2010-04-09 20:14                                   ` Daniel Mack
     [not found]                                 ` <Pine.LNX.4.44L0.1004091529240.1852-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-04-09 20:25                                   ` [LKML] " Konrad Rzeszutek Wilk
2010-04-09 20:25                                     ` Konrad Rzeszutek Wilk
     [not found]                                     ` <20100409202533.GA8983-6K5HmflnPlqSPmnEAIUT9EEOCMrvLtNR@public.gmane.org>
2010-04-09 21:23                                       ` Alan Stern
2010-04-09 21:23                                         ` Alan Stern
2010-04-09 22:11                                         ` Robert Hancock
2010-04-12 10:48                                           ` Daniel Mack
2010-04-12 10:48                                             ` Daniel Mack
2010-04-12 12:06                                             ` Pedro Ribeiro
2010-04-10 12:49                             ` Daniel Mack
2010-04-10 12:49                               ` Daniel Mack
     [not found]                               ` <20100410124912.GP30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-10 13:21                                 ` Pedro Ribeiro
2010-04-10 13:21                                   ` Pedro Ribeiro
2010-04-12  8:59   ` Andi Kleen
2010-04-12  8:59     ` Andi Kleen
2010-04-12 11:14     ` Daniel Mack
2010-04-12 11:14       ` Daniel Mack
     [not found]       ` <20100412111439.GU30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-12 11:53         ` Andi Kleen
2010-04-12 11:53           ` Andi Kleen
2010-04-12 12:11           ` Pedro Ribeiro
     [not found]             ` <q2z74fd948d1004120511hebf19eaauc41ee9ed25dea19e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-12 12:12               ` Andi Kleen
2010-04-12 12:12                 ` Andi Kleen
2010-04-12 12:32                 ` Daniel Mack
2010-04-12 12:47                   ` Andi Kleen
2010-04-12 12:54                     ` Daniel Mack
2010-04-12 12:54                       ` Daniel Mack
2010-04-12 15:43                       ` Andi Kleen
     [not found]                         ` <20100412154323.GP18855-qrUzlfsMFqo/4alezvVtWx2eb7JE58TQ@public.gmane.org>
2010-04-12 16:17                           ` Alan Stern
2010-04-12 16:17                             ` Alan Stern
2010-04-12 16:29                             ` Andi Kleen
2010-04-12 16:57                               ` Alan Stern
2010-04-12 16:57                                 ` Alan Stern
2010-04-12 17:15                                 ` Daniel Mack
2010-04-12 17:15                                   ` Daniel Mack
     [not found]                                   ` <20100412171507.GB30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-12 17:22                                     ` Andi Kleen
2010-04-12 17:22                                       ` Andi Kleen
2010-04-12 17:56                                       ` Daniel Mack
2010-04-12 17:56                                         ` Daniel Mack
2010-04-12 17:52                                     ` [LKML] " Konrad Rzeszutek Wilk
2010-04-12 17:52                                       ` Konrad Rzeszutek Wilk
2010-04-13 18:22                                 ` Daniel Mack
2010-04-13 18:22                                   ` Daniel Mack
     [not found]                                   ` <20100413182233.GR30807-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-13 23:46                                     ` Pedro Ribeiro
2010-04-13 23:46                                       ` Pedro Ribeiro
2010-04-14 10:09                                       ` Daniel Mack
2010-04-14 10:09                                         ` Daniel Mack
2010-04-14 10:47                                         ` Pedro Ribeiro
2010-04-14 11:02                                           ` Pedro Ribeiro
2010-04-14 13:18                                           ` [LKML] " Konrad Rzeszutek Wilk
     [not found]                                           ` <t2w74fd948d1004140347k3447bffapb73856eacddfde55-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-14 14:08                                             ` Alan Stern
2010-04-14 14:08                                               ` Alan Stern
2010-04-14 16:36                                               ` Daniel Mack
2010-04-14 16:36                                                 ` Daniel Mack
     [not found]                                                 ` <20100414163637.GV30807-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-04-14 17:21                                                   ` Pedro Ribeiro
2010-04-14 17:21                                                     ` Pedro Ribeiro
2010-04-14 18:23                                                     ` Alan Stern
2010-04-14 18:27                                                       ` Pedro Ribeiro
2010-04-14 18:53                                                         ` Alan Stern
2010-04-15  7:35                                                     ` Daniel Mack
2010-04-15  7:35                                                       ` Daniel Mack
2010-04-14 18:15                                                 ` Alan Stern
2010-04-14 18:36                                                   ` David Woodhouse
2010-04-14 21:12                                                     ` Pedro Ribeiro
2010-04-14 22:25                                                       ` Chris Wright
2010-04-14 22:56                                                         ` Pedro Ribeiro
2010-04-14 23:37                                                           ` Chris Wright
2010-04-15  1:20                                                             ` Pedro Ribeiro
2010-04-15 15:20                                                               ` Alan Stern
2010-04-20  0:16                                                                 ` Pedro Ribeiro
2010-05-07  7:48                                                                   ` Daniel Mack
2010-05-07  7:48                                                                     ` Daniel Mack
2010-05-07  9:47                                                                     ` Clemens Ladisch [this message]
2010-05-07  9:47                                                                       ` [alsa-devel] " Clemens Ladisch
2010-05-07 10:24                                                                       ` Daniel Mack
2010-05-07 10:24                                                                         ` [alsa-devel] " Daniel Mack
2010-05-07 14:51                                                                         ` Alan Stern
2010-05-07 14:51                                                                           ` Alan Stern
2010-05-10  2:50                                                                           ` FUJITA Tomonori
2010-05-10  9:21                                                                             ` David Woodhouse
2010-05-10  9:21                                                                               ` [alsa-devel] " David Woodhouse
     [not found]                                                                               ` <1273483265.372.3383.camel-uXGAPMMVk8bAQYKIod7YupZV94DADvEd@public.gmane.org>
2010-05-10 14:58                                                                                 ` Alan Stern
2010-05-10 14:58                                                                                   ` Alan Stern
     [not found]                                                                                   ` <Pine.LNX.4.44L0.1005101049100.1626-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-05-11  1:06                                                                                     ` FUJITA Tomonori
2010-05-11  1:06                                                                                       ` FUJITA Tomonori
     [not found]                                                                                       ` <20100511100637D.fujita.tomonori-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2010-05-11 14:00                                                                                         ` Alan Stern
2010-05-11 14:00                                                                                           ` Alan Stern
2010-05-11 14:22                                                                                           ` FUJITA Tomonori
2010-05-11 14:24                                                                                           ` Konrad Rzeszutek Wilk
2010-05-11 14:38                                                                                             ` FUJITA Tomonori
2010-05-11 15:04                                                                                               ` Alan Stern
2010-05-11 15:04                                                                                                 ` Alan Stern
2010-05-11 15:34                                                                                                 ` FUJITA Tomonori
2010-05-11 16:06                                                                                                   ` Alan Stern
2010-05-11 16:09                                                                                                     ` Daniel Mack
2010-05-11 16:48                                                                                                     ` Pedro Ribeiro
2010-05-11 17:10                                                                                                       ` Daniel Mack
2010-05-11 17:32                                                                                                         ` Pedro Ribeiro
2010-05-11 17:38                                                                                                           ` Daniel Mack
2010-05-12 23:50                                                                                                             ` Pedro Ribeiro
2010-05-13  9:36                                                                                                               ` Daniel Mack
2010-05-14  0:17                                                                                                                 ` Pedro Ribeiro
2010-05-11 14:57                                                                                             ` Alan Stern
2010-05-11 15:05                                                                                               ` Daniel Mack
     [not found]                                                                         ` <20100507102408.GM30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-05-10 14:31                                                                           ` Konrad Rzeszutek Wilk
2010-05-10 14:31                                                                             ` Konrad Rzeszutek Wilk
     [not found]                                                                       ` <4BE3E1B9.5020602-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2010-05-07 11:42                                                                         ` Oliver Neukum
2010-05-07 11:42                                                                           ` Oliver Neukum
     [not found]                                                                           ` <201005071342.34923.oneukum-l3A5Bk7waGM@public.gmane.org>
2010-05-07 11:47                                                                             ` Oliver Neukum
2010-05-07 11:47                                                                               ` Oliver Neukum
2010-05-07 11:58                                                                               ` Daniel Mack
2010-05-07 11:58                                                                                 ` [alsa-devel] " Daniel Mack
     [not found]                                                                                 ` <20100507115810.GN30801-ahpEBR4enfnCULTFXS99ULNAH6kLmebB@public.gmane.org>
2010-05-07 14:45                                                                                   ` Alan Stern
2010-05-07 14:45                                                                                     ` Alan Stern
2010-04-14 18:38                                                   ` Chris Wright
2010-04-14 20:29                                                     ` Alan Stern
2010-04-14 21:01                                                       ` Konrad Rzeszutek Wilk
2010-04-14 21:12                                                         ` Pedro Ribeiro
2010-04-15  1:50                                                           ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE3E1B9.5020602@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andi@firstfloor.org \
    --cc=chrisw@sous-sol.org \
    --cc=daniel@caiaq.de \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pedrib@gmail.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.