All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Peter Lieven <pl@dlh.net>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?
Date: Sun, 16 May 2010 17:47:46 +0300	[thread overview]
Message-ID: <4BF00592.5040403@redhat.com> (raw)
In-Reply-To: <m3iq6nc3hr.fsf@trasno.mitica>

On 05/16/2010 05:42 PM, Juan Quintela wrote:
>
>> Any idea why it fails?  And how to fix it?
>>      
> Lack of "proper" subsections.  IDE is something like:
>
> const VMStateDescription vmstate_ide_drive = {
>      .version_id = 4,
> ....
> }
>
> static const VMStateDescription vmstate_bmdma = {
>      .name = "ide bmdma",
>      .version_id = 4,
> ...
> }
>
> const VMStateDescription vmstate_ide_pci = {
>      .name = "ide",
>      .version_id = 4,
> ....
>          VMSTATE_STRUCT_ARRAY(bmdma, PCIIDEState, 2, 0,
>                       vmstate_bmdma, BMDMAState),
>          VMSTATE_IDE_DRIVES(bus[0].ifs, PCIIDEState),
>          VMSTATE_IDE_DRIVES(bus[1].ifs, PCIIDEState),
> ....
> }
>
>
> Notice that everything is at version 4.  It used to be everything at
> version 3.  Now the problem is that when migrating from v3 ->  v4.  We
> put in one place v3, But we only have a version number at the toplevel,
> rest of "subsections" don't sent a version number.  There is no way to
> fix it in the general case.  We can hack something around for ide, but
> that will just be a hack, or we can backport marcelo change and port it
> as a proper subsection (that is my plan).  I expect to have time at the
> end of next time to work on this.
>    

end of next week?

> So, to make the story short: I know what is happening, and I know how to
> fix it, just that fix is not trivial.  I just need time.
>    

Meanwhile, we have a broken 0.12.4.  Is there a quick'n'dirty workaround 
that will be forward compatible with the real fix that we can push out?

We've regressed from failing some migrations to failing all migrations.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Peter Lieven <pl@dlh.net>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken?
Date: Sun, 16 May 2010 17:47:46 +0300	[thread overview]
Message-ID: <4BF00592.5040403@redhat.com> (raw)
In-Reply-To: <m3iq6nc3hr.fsf@trasno.mitica>

On 05/16/2010 05:42 PM, Juan Quintela wrote:
>
>> Any idea why it fails?  And how to fix it?
>>      
> Lack of "proper" subsections.  IDE is something like:
>
> const VMStateDescription vmstate_ide_drive = {
>      .version_id = 4,
> ....
> }
>
> static const VMStateDescription vmstate_bmdma = {
>      .name = "ide bmdma",
>      .version_id = 4,
> ...
> }
>
> const VMStateDescription vmstate_ide_pci = {
>      .name = "ide",
>      .version_id = 4,
> ....
>          VMSTATE_STRUCT_ARRAY(bmdma, PCIIDEState, 2, 0,
>                       vmstate_bmdma, BMDMAState),
>          VMSTATE_IDE_DRIVES(bus[0].ifs, PCIIDEState),
>          VMSTATE_IDE_DRIVES(bus[1].ifs, PCIIDEState),
> ....
> }
>
>
> Notice that everything is at version 4.  It used to be everything at
> version 3.  Now the problem is that when migrating from v3 ->  v4.  We
> put in one place v3, But we only have a version number at the toplevel,
> rest of "subsections" don't sent a version number.  There is no way to
> fix it in the general case.  We can hack something around for ide, but
> that will just be a hack, or we can backport marcelo change and port it
> as a proper subsection (that is my plan).  I expect to have time at the
> end of next time to work on this.
>    

end of next week?

> So, to make the story short: I know what is happening, and I know how to
> fix it, just that fix is not trivial.  I just need time.
>    

Meanwhile, we have a broken 0.12.4.  Is there a quick'n'dirty workaround 
that will be forward compatible with the real fix that we can push out?

We've regressed from failing some migrations to failing all migrations.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-05-16 14:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 10:59 Qemu-KVM Livate Migration 0.12.2 -> 0.12.3/4 broken? Peter Lieven
2010-05-11 10:59 ` [Qemu-devel] " Peter Lieven
2010-05-11 23:11 ` Juan Quintela
2010-05-11 23:11   ` [Qemu-devel] " Juan Quintela
2010-05-12 13:42   ` Peter Lieven
2010-05-16 12:02   ` Avi Kivity
2010-05-16 12:02     ` [Qemu-devel] " Avi Kivity
2010-05-16 14:42     ` Juan Quintela
2010-05-16 14:42       ` [Qemu-devel] " Juan Quintela
2010-05-16 14:47       ` Avi Kivity [this message]
2010-05-16 14:47         ` Avi Kivity
2010-05-16 20:04         ` Juan Quintela
2010-05-16 20:04           ` [Qemu-devel] " Juan Quintela
2010-05-17  7:00           ` Avi Kivity
2010-05-17  7:00             ` [Qemu-devel] " Avi Kivity
2010-05-17  8:23             ` Michael Tokarev
2010-05-17  8:23               ` [Qemu-devel] " Michael Tokarev
2010-05-17  9:07               ` Juan Quintela
2010-05-17  9:07                 ` [Qemu-devel] " Juan Quintela
2010-05-17  9:11                 ` Michael Tokarev
2010-05-17  9:11                   ` [Qemu-devel] " Michael Tokarev
2010-05-17  9:38                   ` Alexander Graf
2010-05-17  9:38                     ` Alexander Graf
2010-05-16 18:03       ` Jan Kiszka
2010-05-16 18:03         ` [Qemu-devel] " Jan Kiszka
2010-05-16 20:06         ` Juan Quintela
2010-05-16 20:06           ` [Qemu-devel] " Juan Quintela
2010-05-17 10:35           ` Jan Kiszka
2010-05-17 10:35             ` [Qemu-devel] " Jan Kiszka
2010-06-08  9:54             ` Peter Lieven
2010-06-08  9:54               ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF00592.5040403@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=pl@dlh.net \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.