* [PATCH] xl: allow nameless domains to be named
@ 2010-05-25 20:44 Jeremy Fitzhardinge
2010-05-26 0:45 ` Yang Hongyang
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2010-05-25 20:44 UTC (permalink / raw)
To: Xen-devel; +Cc: Vincent Hanquez, Ian Jackson, Stefano Stabellini
At present, find_domain() will exit(2) if you specify a domain by
number, but that domain doesn't have a corresponding name. However,
nothing seem to critically depend on common_domname being set, and the
test prevents dom0 or other nameless domains from being named. So just
remove the check.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
diff -r ba7fdd53f44c tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Tue May 25 13:37:20 2010 -0700
+++ b/tools/libxl/xl_cmdimpl.c Tue May 25 13:40:53 2010 -0700
@@ -138,10 +138,6 @@
exit(2);
}
common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
- if (!common_domname) {
- fprintf(stderr, "%s is an invalid domain identifier.\n", p);
- exit(2);
- }
}
#define LOG(_f, _a...) dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] xl: allow nameless domains to be named
2010-05-25 20:44 [PATCH] xl: allow nameless domains to be named Jeremy Fitzhardinge
@ 2010-05-26 0:45 ` Yang Hongyang
0 siblings, 0 replies; 2+ messages in thread
From: Yang Hongyang @ 2010-05-26 0:45 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: Ian Jackson, Xen-devel, Vincent Hanquez, Stefano Stabellini
Hi jeremy,
On 05/26/2010 04:44 AM, Jeremy Fitzhardinge wrote:
> At present, find_domain() will exit(2) if you specify a domain by
> number, but that domain doesn't have a corresponding name. However,
> nothing seem to critically depend on common_domname being set, and the
> test prevents dom0 or other nameless domains from being named. So just
> remove the check.
Thank you, for now, remove the check seems to be the solution.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Acked-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>
> diff -r ba7fdd53f44c tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c Tue May 25 13:37:20 2010 -0700
> +++ b/tools/libxl/xl_cmdimpl.c Tue May 25 13:40:53 2010 -0700
> @@ -138,10 +138,6 @@
> exit(2);
> }
> common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
> - if (!common_domname) {
> - fprintf(stderr, "%s is an invalid domain identifier.\n", p);
> - exit(2);
> - }
> }
>
> #define LOG(_f, _a...) dolog(__FILE__, __LINE__, __func__, _f "\n", ##_a)
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
--
Regards
Yang Hongyang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-26 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-25 20:44 [PATCH] xl: allow nameless domains to be named Jeremy Fitzhardinge
2010-05-26 0:45 ` Yang Hongyang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.