All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board
Date: Wed, 26 May 2010 15:18:50 -0500	[thread overview]
Message-ID: <4BFD822A.3030705@freescale.com> (raw)
In-Reply-To: <20100526201014.97886EAC238@gemini.denx.de>

Wolfgang Denk wrote:

> There is exactly two entries in that table where it would make any
> difference, and if that's really that important to you, adding two
> spaces after the TAB would work wonders.

The column headers would be unaligned:

static const board_specific_parameters_t bsp[] = {
/*
 *      memory controller 0
 *	  lo|  hi|  num|  clk| cpo|wrdata|2T
 *       mhz| mhz|ranks|adjst|    | delay|
 */
	{  0, 333,    1,    5,  31,    3,  0},
	{334, 400,    1,    5,  31,    3,  0},
	{401, 549,    1,    5,  31,    3,  0},
	{550, 680,    1,    5,  31,    5,  0},
	{681, 850,    1,    5,  31,    5,  0},
	{  0, 333,    2,    5,  31,    3,  0},
	{334, 400,    2,    5,  31,    3,  0},
	{401, 549,    2,    5,  31,    3,  0},
	{550, 680,    2,    5,  31,    5,  0},
	{681, 850,    2,    5,  31,    5,  0},
};

>>> How about using get_ram_size() for autosizing / testing?
>>
>> It appears get_ram_size() has never been used on PowerPC before.   This
> 
> It appears you really haven't bothered checking. We have been using
> it on PowerPC since day 1 - for well over 10 years by now. On many,
> many systems. Get a clue!

Sorry, I must have used grep wrong or something.  I see what you're talking
about now.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2010-05-26 20:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 22:01 [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board Timur Tabi
2010-05-20 22:33 ` Wolfgang Denk
2010-05-20 23:13   ` Kumar Gala
2010-05-21  6:50     ` Wolfgang Denk
2010-05-20 23:23   ` Timur Tabi
2010-05-21  7:07     ` Wolfgang Denk
2010-05-21 13:45       ` Timur Tabi
2010-05-21 14:22         ` Wolfgang Denk
2010-05-21 14:33           ` Timur Tabi
2010-05-21 16:07           ` Timur Tabi
2010-05-26 18:12       ` Timur Tabi
2010-05-26 18:17         ` Scott Wood
2010-05-26 18:19           ` Timur Tabi
2010-05-26 19:04             ` Scott Wood
2010-05-26 19:34               ` Timur Tabi
2010-05-26 19:46                 ` Scott Wood
2010-05-26 21:59                   ` Timur Tabi
2010-05-25 18:30   ` Timur Tabi
2010-05-26 20:10     ` Wolfgang Denk
2010-05-26 20:18       ` Timur Tabi [this message]
2010-05-26 20:24       ` Timur Tabi
2010-05-27  7:02         ` Wolfgang Denk
2010-05-27 14:31           ` Timur Tabi
2010-05-27 18:11             ` Wolfgang Denk
2010-05-27 18:25               ` Timur Tabi
2010-05-27 19:03                 ` Scott Wood
2010-05-27 19:07                   ` Timur Tabi
2010-05-27 19:10                     ` Scott Wood
2010-05-27 19:54                       ` Wolfgang Denk
2010-05-27 19:53                     ` Wolfgang Denk
2010-05-27 20:11                       ` Timur Tabi
2010-05-27 21:10                         ` Wolfgang Denk
2010-05-27 19:53                   ` Wolfgang Denk
2010-05-27 20:03                     ` Timur Tabi
2010-05-27 20:59                       ` Wolfgang Denk
2010-05-27 20:05                     ` Scott Wood
2010-05-27 21:03                       ` Wolfgang Denk
2010-05-27 19:45                 ` Wolfgang Denk
2010-05-27 19:54                   ` Timur Tabi
2010-05-27 20:00                     ` Wolfgang Denk
2010-05-27 20:10                       ` Scott Wood
2010-05-21  0:26 ` [U-Boot] [PATCH] powerpc: add support for the FreescaleP1022DS " Liu Dave-R63238
2010-05-21 15:25   ` Timur Tabi
2010-05-21  9:46 ` [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS " Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFD822A.3030705@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.