* [PATCH]: i915: Fix missing linux/types.h warning in header
@ 2010-05-27 15:23 Prarit Bhargava
2010-05-27 15:29 ` Alan Coopersmith
0 siblings, 1 reply; 3+ messages in thread
From: Prarit Bhargava @ 2010-05-27 15:23 UTC (permalink / raw)
To: dri-devel, airlied; +Cc: Prarit Bhargava
Fixes warning:
/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index b64a8d7..5cf7f5b 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@ -27,6 +27,7 @@
#ifndef _I915_DRM_H_
#define _I915_DRM_H_
+#include <linux/types.h>
#include "drm.h"
/* Please note that modifications to all structs defined here are
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH]: i915: Fix missing linux/types.h warning in header 2010-05-27 15:23 [PATCH]: i915: Fix missing linux/types.h warning in header Prarit Bhargava @ 2010-05-27 15:29 ` Alan Coopersmith 2010-05-27 15:39 ` Prarit Bhargava 0 siblings, 1 reply; 3+ messages in thread From: Alan Coopersmith @ 2010-05-27 15:29 UTC (permalink / raw) To: Prarit Bhargava; +Cc: dri-devel Prarit Bhargava wrote: > Fixes warning: > > /usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h > index b64a8d7..5cf7f5b 100644 > --- a/include/drm/i915_drm.h > +++ b/include/drm/i915_drm.h > @@ -27,6 +27,7 @@ > #ifndef _I915_DRM_H_ > #define _I915_DRM_H_ > > +#include <linux/types.h> > #include "drm.h" drm.h includes it, safely tucked inside #ifdef __linux__ so it won't break BSD & OpenSolaris DRI builds - isn't that good enough? -- -Alan Coopersmith- alan.coopersmith@oracle.com Oracle Solaris Platform Engineering: X Window System ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: i915: Fix missing linux/types.h warning in header 2010-05-27 15:29 ` Alan Coopersmith @ 2010-05-27 15:39 ` Prarit Bhargava 0 siblings, 0 replies; 3+ messages in thread From: Prarit Bhargava @ 2010-05-27 15:39 UTC (permalink / raw) To: Alan Coopersmith; +Cc: dri-devel > > Prarit Bhargava wrote: > >> Fixes warning: >> >> /usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include<linux/types.h> >> >> Signed-off-by: Prarit Bhargava<prarit@redhat.com> >> >> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h >> index b64a8d7..5cf7f5b 100644 >> --- a/include/drm/i915_drm.h >> +++ b/include/drm/i915_drm.h >> @@ -27,6 +27,7 @@ >> #ifndef _I915_DRM_H_ >> #define _I915_DRM_H_ >> >> +#include<linux/types.h> >> #include "drm.h" >> > drm.h includes it, safely tucked inside #ifdef __linux__ so it won't > break BSD& OpenSolaris DRI builds - isn't that good enough? > Hmm ... it doesn't appear to be :/ From a week-old compile of linux-next /home/linux-next/usr/include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h> It could certainly be that the error check is busted ... P. > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-27 15:43 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-27 15:23 [PATCH]: i915: Fix missing linux/types.h warning in header Prarit Bhargava 2010-05-27 15:29 ` Alan Coopersmith 2010-05-27 15:39 ` Prarit Bhargava
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.