What's the rationale for change d1efaaee441b "xend: Dis-allow device assignment if PoD is enabled."?

What's the rationale for change d1efaaee441b "xend: Dis-allow device assignment if PoD is enabled."?

[Jeremy Fitzhardinge]

What's the rationale for changeset d1efaaee441b?  I'm seeing it when
trying to attach a pci device to a PV domain with xm.  I think the check
is triggering because the domain is ballooned down a bit, but I'm not
sure (is there some way to see what the static and dynamic memory sizes
are for a domain with the tools?).

As I understand it, PoD only applies to HVM domains.  Should this check
be made more specific?

Thanks,
    J

RE: What's the rationale for change d1efaaee441b "xend: Dis-allow device assignment if PoD is enabled."?

[Xu, Dongxiao]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

Jeremy Fitzhardinge wrote:
> What's the rationale for changeset d1efaaee441b?  I'm seeing it when
> trying to attach a pci device to a PV domain with xm.  I think the
> check is triggering because the domain is ballooned down a bit, but
> I'm not sure (is there some way to see what the static and dynamic
> memory sizes are for a domain with the tools?).
> 
> As I understand it, PoD only applies to HVM domains.  Should this
> check be made more specific?

Yes, you are right. 
The POD check should be for HVM domain only. 
I submitted a patch in the attachment to fix this issue.

Thanks,
Dongxiao

> 
> Thanks,
>     J


[-- Attachment #2: device-assign-pod.patch --]
[-- Type: application/octet-stream, Size: 638 bytes --]

PoD check should be for HVM domain only. 

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>

diff -r 96917cf25bf3 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Fri May 28 10:54:07 2010 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py	Mon May 31 11:12:54 2010 +0800
@@ -396,7 +396,7 @@ class XendDomainInfo:
         maxmem = self.info.get('memory_static_max', 0)
         memory = self.info.get('memory_dynamic_max', 0)
 
-        if maxmem > memory:
+        if self.info.is_hvm() and maxmem > memory:
             self.pod_enabled = True
         else:
             self.pod_enabled = False

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel