All of lore.kernel.org
 help / color / mirror / Atom feed
From: jason77.wang@gmail.com (jason)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 3/3] mx51/keypad: add keypad support for i.MX51 platforms
Date: Sat, 05 Jun 2010 22:13:34 +0800	[thread overview]
Message-ID: <4C0A5B8E.4020906@gmail.com> (raw)
In-Reply-To: <1275730558.3446.23.camel@realization>

Alberto Panizzo wrote:
> On gio, 2010-06-03 at 20:05 +0800, Jason Wang wrote:
>   
>> Add keypad controller device definition for all i.MX51 platforms,
>> add a dummy kpp clock for imx keypad driver and add keypad device
>> registration on i.MX51 3-stack board.
>>
>> Signed-off-by: Jason Wang <jason77.wang@gmail.com>
>> ---
>>  arch/arm/mach-mx5/board-mx51_3ds.c |   59 ++++++++++++++++++++++++++++++++++++
>>  arch/arm/mach-mx5/clock-mx51.c     |    5 +++
>>  arch/arm/mach-mx5/devices.c        |   19 +++++++++++
>>  arch/arm/mach-mx5/devices.h        |    1 +
>>  4 files changed, 84 insertions(+), 0 deletions(-)
>>     
>
> May you wont divide platform vs machine code in two different patches.
>   
Thanks for your comments, but here i don't really know what you mean,
should i divide this patch to 2 patches or ?
> and, Eric B?nard is working on imx_keypad suspend/resume features[1] and
> about it, he is going to modify the platform interface that make us able
> to register the device.. this patch could look old in a few.
>
> [1]http://thread.gmane.org/gmane.linux.ports.arm.kernel/80968/focus=13131
>
> Best regards,
> Alberto!
>
>   
Yes, reading this thread, my platform interface is old.
I just git pull the upstream, it seems that new interface change hasn't 
been merged,
i will modify this interface if it is merged into the upstream.

Thanks,
Jason.
>> diff --git a/arch/arm/mach-mx5/board-mx51_3ds.c b/arch/arm/mach-mx5/board-mx51_3ds.c
>> index 5da90e9..abc9f87 100644
>> --- a/arch/arm/mach-mx5/board-mx51_3ds.c
>> +++ b/arch/arm/mach-mx5/board-mx51_3ds.c
>> @@ -16,6 +16,7 @@
>>     
<snip>

  reply	other threads:[~2010-06-05 14:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 12:05 [V2 0/3]Add i.MX51 3-stack board support Jason Wang
2010-06-03 12:05 ` [V2 1/3] mxc: Add support for the imx51 3-stack board Jason Wang
2010-06-03 12:05   ` [V2 2/3] mxc/iomux: add GPIO bank offset for iomux v3 platforms Jason Wang
2010-06-03 12:05     ` [V2 3/3] mx51/keypad: add keypad support for i.MX51 platforms Jason Wang
2010-06-05  9:35       ` Alberto Panizzo
2010-06-05 14:13         ` jason [this message]
2010-06-06 18:11           ` Alberto Panizzo
2010-06-07 23:22             ` jason
2010-06-03 12:39   ` [V2 1/3] mxc: Add support for the imx51 3-stack board Amit Kucheria
2010-06-03 13:57     ` Sascha Hauer
2010-06-03 14:35       ` Amit Kucheria
2010-06-03 14:36       ` jason
2010-06-03 14:39     ` jason
2010-06-04  8:53   ` Sascha Hauer
2010-06-04  9:48     ` Alberto Panizzo
2010-06-04 15:22       ` Sascha Hauer
2010-06-04 10:53     ` Amit Kucheria
2010-06-04 14:09       ` [PATCH] mxc: Fix pad names for imx51 Amit Kucheria
2010-06-07 20:41         ` Troy Kisky
2010-06-07 21:04           ` Amit Kucheria
2010-06-07 21:15             ` Troy Kisky
2010-06-08  6:30               ` Sascha Hauer
2010-06-09 13:09                 ` Amit Kucheria
2010-06-10 11:49                   ` Sascha Hauer
2010-06-10 13:04                     ` jason
2010-06-10 13:59                       ` Sascha Hauer
2010-06-10 19:24                     ` Amit Kucheria
2010-06-04 12:50     ` [V2 1/3] mxc: Add support for the imx51 3-stack board jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0A5B8E.4020906@gmail.com \
    --to=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.