Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On 06/07/2010 06:58 PM, Colin Watson wrote:
> While writing documentation for booting GRUB over the network, I noticed
> that the code to handle (pxe:server_ip:gateway_ip) device names looks
> wrong.  Shouldn't it be like this?
>
>   
Go ahead.
> 2010-06-07  Colin Watson  <cjwatson@ubuntu.com>
>
> 	* fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip.
>
> === modified file 'fs/i386/pc/pxe.c'
> --- fs/i386/pc/pxe.c	2010-02-14 12:18:33 +0000
> +++ fs/i386/pc/pxe.c	2010-06-07 16:56:22 +0000
> @@ -114,7 +114,7 @@ grub_pxe_open (const char *name, grub_di
>  	return err;
>        if (*ptr == ':')
>  	{
> -	  err = parse_ip (ptr + 1, &(data->server_ip), 0);
> +	  err = parse_ip (ptr + 1, &(data->gateway_ip), 0);
>  	  if (err)
>  	    return err;
>  	}
>
> Thanks,
>
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]