Re: [PATCH] File name transformations (split into 7 diffs)

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2310 bytes --]

Regarding file-name-transformations_1.diff:
phcoder@debian.bg45.phnet:~$ /usr/local/bin/grub-mkfont --help
Usage: /usr/local/bin/grub-mkfont [OPTIONS] FONT_FILES

So I would prefer not to use basename for uniformity. Otherwise patch 1
is ok.

On 06/04/2010 01:42 AM, Grégoire Sutre wrote:
> Hi,
>
> This is the same patch as I sent before, but this time split into 7
> diffs (which must be successively applied in order) and with a cleaner
> changelog.  I hope that this will facilitate the review.
>
> This version does not include the --root-directory addition to
> grub-mkconfig, as this is quite orthognal to the goal of the patch (file
> name transformation).
>
> I welcome your comments,
>
> Grégoire
>
> --- mostly taken from my previous message ------------------------------
>
> The attached patch fixes problems with file name transformations, which
> are partly broken in trunk.  With this patch, several installations of
> grub can coexist with no conflict (at least they should), sharing
> however the same configuration directory (etc/grub.d).
>
> For instance:
>
> ./configure --program-transform-name=s,grub,aaa,
>
> will install bin/aaa-*, sbin/aaa-*, etc. The default grub directory will
> be /boot/aaa, modules will be installed there and grub-mkconfig will
> look for them there.
>
> The main changes in the patch are:
>
> - configure defines three new variables, accounting for transformations:
>   . pkgdatadir       (${datadir}/grub)
>   . pkglibrootdir    (${libdir}/grub)
>   . defaultbootdir   (/boot/grub, or /grub if OS is NetBSD or OpenBSD)
>
> - these variables are used in Makefile and in util/... scripts
>
> - output of --help and of --version in scripts uses `basename $0` and
>   the same format as the one in binaries.
>
> - in Makefile, the help2man, .info, and .mo rules also account for
>   file name transformations.
>
> - grub-mkconfig exports GRUB_DIR, which is used by grub-mkconfig_lib
>   and by 00_header.
>
> -----------------------------------------------------------------------
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #1.2: Type: text/html, Size: 3293 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]