From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: Cris Daniluk <cris.daniluk@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Xen 4.0 crashes with pvops kernel
Date: Thu, 24 Jun 2010 22:25:47 +0100 [thread overview]
Message-ID: <4C23CD5B.5010409@goop.org> (raw)
In-Reply-To: <4C235DED0200007800008058@vpn.id2.novell.com>
On 06/24/2010 12:30 PM, Jan Beulich wrote:
>> If the pte has _PAGE_IO set (which all ioremap ptes should), then it
>> will call xen_set_iomap_pte. This can't fail (not return code), so if
>>
> Ah, right, I apparently looked at the upstream (i.e. DomU-only)
> implementation rather than your tree.
>
Yes, that has no way to ioremap real hardware.
>> the hypercall fails then it will leave it unmapped. It should at least
>> print a warn-on in that case.
>>
> Yes, that's the minimal requirement I would say.
>
Currently its implemented as a batched multicall, so the site itself
can't check to see if the hypercall worked. I should check that it can
actually be called in a batched context.
J
prev parent reply other threads:[~2010-06-24 21:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 22:10 Xen 4.0 crashes with pvops kernel Cris Daniluk
2010-06-15 6:54 ` Jan Beulich
[not found] ` <AANLkTimslcbXQnihpIB0c-ceWbD7H-eyUY_BV2igyfzv@mail.gmail.com>
2010-06-15 12:50 ` Jan Beulich
2010-06-15 12:56 ` Keir Fraser
2010-06-15 13:20 ` Jan Beulich
2010-06-15 13:24 ` Cris Daniluk
2010-06-15 13:43 ` Jan Beulich
2010-06-15 13:49 ` Cris Daniluk
2010-06-15 14:13 ` Jan Beulich
2010-06-15 14:35 ` Cris Daniluk
2010-06-15 14:58 ` Jan Beulich
2010-06-15 15:01 ` Cris Daniluk
2010-06-15 15:21 ` Jan Beulich
2010-06-15 16:18 ` Boris Derzhavets
2010-06-15 14:17 ` Pasi Kärkkäinen
2010-06-15 15:11 ` Konrad Rzeszutek Wilk
2010-06-16 14:42 ` Jan Beulich
2010-06-15 13:57 ` Jan Beulich
2010-06-15 15:15 ` Konrad Rzeszutek Wilk
2010-06-16 14:36 ` Jan Beulich
2010-06-24 9:29 ` Jeremy Fitzhardinge
2010-06-24 11:30 ` Jan Beulich
2010-06-24 21:25 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C23CD5B.5010409@goop.org \
--to=jeremy@goop.org \
--cc=JBeulich@novell.com \
--cc=cris.daniluk@gmail.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.