All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kgene.kim@samsung.com, kyungmin.park@samsung.com,
	linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
	linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver
Date: Mon, 28 Jun 2010 17:39:39 +0900	[thread overview]
Message-ID: <4C285FCB.3070100@samsung.com> (raw)
In-Reply-To: <20100625083019.GD8546@core.coreip.homeip.net>

Hi, Dmitry.

On 6/25/2010 5:30 PM, Dmitry Torokhov wrote:
> Hi Joonyoung,
> 
> On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote:
>> This patch adds support for keypad driver running on Samsung cpus. This
>> driver is tested on GONI and Aquila board using S5PC110 cpu.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Following my conversation with Thomas Gleixner reagrding "long playing"
> threaded interrupt handlers I tried to convert your driver to use this
> concept. The idea is to keep polling within IRQ thread context instead
> of using additional work/timer structures to simplify code and ensure
> race-free shutdown/unbind.
> 
> I think it was based on v4 of your driver and I'd appreciate if you could
> give it a try.
> 
> Thank you.
> 

I have tested your patch on my v5 patchset and it is working after some
fixing. I will post v6 patchset appling your patch.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: jy0922.shim@samsung.com (Joonyoung Shim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver
Date: Mon, 28 Jun 2010 17:39:39 +0900	[thread overview]
Message-ID: <4C285FCB.3070100@samsung.com> (raw)
In-Reply-To: <20100625083019.GD8546@core.coreip.homeip.net>

Hi, Dmitry.

On 6/25/2010 5:30 PM, Dmitry Torokhov wrote:
> Hi Joonyoung,
> 
> On Mon, Jun 21, 2010 at 03:26:45PM +0900, Joonyoung Shim wrote:
>> This patch adds support for keypad driver running on Samsung cpus. This
>> driver is tested on GONI and Aquila board using S5PC110 cpu.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Following my conversation with Thomas Gleixner reagrding "long playing"
> threaded interrupt handlers I tried to convert your driver to use this
> concept. The idea is to keep polling within IRQ thread context instead
> of using additional work/timer structures to simplify code and ensure
> race-free shutdown/unbind.
> 
> I think it was based on v4 of your driver and I'd appreciate if you could
> give it a try.
> 
> Thank you.
> 

I have tested your patch on my v5 patchset and it is working after some
fixing. I will post v6 patchset appling your patch.

Thanks.

  parent reply	other threads:[~2010-06-28  8:39 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21  6:26 [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support Joonyoung Shim
2010-06-21  6:26 ` Joonyoung Shim
2010-06-21  6:26 ` [PATCH v5 2/3] ARM: S5PV210: Add keypad device helpers Joonyoung Shim
2010-06-21  6:26   ` Joonyoung Shim
2010-06-21  6:26 ` [PATCH v5 3/3] input: samsung-keypad - Add samsung keypad driver Joonyoung Shim
2010-06-21  6:26   ` Joonyoung Shim
2010-06-25  8:30   ` Dmitry Torokhov
2010-06-25  8:30     ` Dmitry Torokhov
2010-06-25 10:25     ` Joonyoung Shim
2010-06-25 10:25       ` Joonyoung Shim
2010-06-25 10:39       ` Joonyoung Shim
2010-06-25 10:39         ` Joonyoung Shim
2010-06-28  8:39     ` Joonyoung Shim [this message]
2010-06-28  8:39       ` Joonyoung Shim
2010-06-28  9:01       ` Dmitry Torokhov
2010-06-28  9:01         ` Dmitry Torokhov
2010-06-21  9:05 ` [PATCH v5 1/3] ARM: SAMSUNG: Add keypad device support Eric Miao
2010-06-21  9:05   ` Eric Miao
2010-06-21  9:19   ` Russell King - ARM Linux
2010-06-21  9:19     ` Russell King - ARM Linux
2010-06-21 10:39     ` Eric Miao
2010-06-21 10:39       ` Eric Miao
2010-06-21 11:16       ` Russell King - ARM Linux
2010-06-21 11:16         ` Russell King - ARM Linux
2010-06-21 14:15         ` Eric Miao
2010-06-21 14:15           ` Eric Miao
2010-06-22  0:48         ` Joonyoung Shim
2010-06-22  0:48           ` Joonyoung Shim
2010-06-22  3:02           ` Eric Miao
2010-06-22  3:02             ` Eric Miao
2010-06-22  3:27             ` Joonyoung Shim
2010-06-22  3:27               ` Joonyoung Shim
2010-06-22  3:38               ` Eric Miao
2010-06-22  3:38                 ` Eric Miao
2010-06-22  4:00                 ` Joonyoung Shim
2010-06-22  4:00                   ` Joonyoung Shim
2010-06-22  7:15                   ` Eric Miao
2010-06-22  7:15                     ` Eric Miao
2010-06-22  7:33                     ` Joonyoung Shim
2010-06-22  7:33                       ` Joonyoung Shim
2010-06-21  9:29   ` Marek Szyprowski
2010-06-21  9:29     ` Marek Szyprowski
2010-06-21 10:43     ` Eric Miao
2010-06-21 10:43       ` Eric Miao
2010-06-21 11:21   ` Joonyoung Shim
2010-06-21 11:21     ` Joonyoung Shim
2010-06-21 14:19     ` Eric Miao
2010-06-21 14:19       ` Eric Miao
2010-06-22  0:18       ` Kukjin Kim
2010-06-22  0:18         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C285FCB.3070100@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=ben-linux@fluff.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.