[PATCH] Fix vgremove to allow removal of VG with missing PVs.

[PATCH] Fix vgremove to allow removal of VG with missing PVs.

[Milan Broz]

Inroduced by vgremove check function split...
---
 WHATS_NEW                  |    1 +
 test/t-activate-partial.sh |    3 +++
 tools/vgremove.c           |    2 +-
 3 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/WHATS_NEW b/WHATS_NEW
index 0c415a3..b485a59 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
 Version 2.02.69 - 
 ================================
+  Fix vgremove to allow removal of VG with missing PVs. (2.02.52)
   Add {pv|vg}_mda_used_count which displays a count of mdas w/ignored bit clear.
   Add vg_mda_copies which displays the value of --vgmetadatacopies.
   Describe --vgmetadatacopies in lvm.conf and other man pages.
diff --git a/test/t-activate-partial.sh b/test/t-activate-partial.sh
index f0a95c5..15f5965 100644
--- a/test/t-activate-partial.sh
+++ b/test/t-activate-partial.sh
@@ -15,3 +15,6 @@ lvchange -v --refresh --partial $vg/mirror
 # also check that vgchange works
 vgchange -a n --partial $vg
 vgchange -a y --partial $vg
+
+# check vgremove
+vgremove -f $vg
\ No newline at end of file
diff --git a/tools/vgremove.c b/tools/vgremove.c
index b719ca2..56e18ef 100644
--- a/tools/vgremove.c
+++ b/tools/vgremove.c
@@ -49,7 +49,7 @@ static int vgremove_single(struct cmd_context *cmd, const char *vg_name,
 		}
 	}
 
-	if (!vg_remove_check(vg)) {
+	if (!force && !vg_remove_check(vg)) {
 		stack;
 		return ECMD_FAILED;
 	}
-- 
1.7.1

[PATCH] Fix vgremove to allow removal of VG with missing PVs.

[Petr Rockai]

Hi,

Milan Broz <mbroz@redhat.com> writes:
> diff --git a/WHATS_NEW b/WHATS_NEW
> index 0c415a3..b485a59 100644
> --- a/WHATS_NEW
> +++ b/WHATS_NEW
> @@ -1,5 +1,6 @@
>  Version 2.02.69 - 
>  ================================
> +  Fix vgremove to allow removal of VG with missing PVs. (2.02.52)
>    Add {pv|vg}_mda_used_count which displays a count of mdas w/ignored bit clear.
>    Add vg_mda_copies which displays the value of --vgmetadatacopies.
>    Describe --vgmetadatacopies in lvm.conf and other man pages.
> diff --git a/test/t-activate-partial.sh b/test/t-activate-partial.sh
> index f0a95c5..15f5965 100644
> --- a/test/t-activate-partial.sh
> +++ b/test/t-activate-partial.sh
> @@ -15,3 +15,6 @@ lvchange -v --refresh --partial $vg/mirror
>  # also check that vgchange works
>  vgchange -a n --partial $vg
>  vgchange -a y --partial $vg
> +
> +# check vgremove
> +vgremove -f $vg
> \ No newline at end of file
> diff --git a/tools/vgremove.c b/tools/vgremove.c
> index b719ca2..56e18ef 100644
> --- a/tools/vgremove.c
> +++ b/tools/vgremove.c
> @@ -49,7 +49,7 @@ static int vgremove_single(struct cmd_context *cmd, const char *vg_name,
>  		}
>  	}
>  
> -	if (!vg_remove_check(vg)) {
> +	if (!force && !vg_remove_check(vg)) {
>  		stack;
>  		return ECMD_FAILED;
>  	}

Looks OK as far as I can tell. Maybe just add "not vgremove $vg" just
before "vgremove -f $vg" in the test.

Yours,
    Petr.

[PATCH] Fix vgremove to allow removal of VG with missing PVs.

[Milan Broz]

On 06/30/2010 02:37 PM, Petr Rockai wrote:
> Looks OK as far as I can tell. Maybe just add "not vgremove $vg" just
> before "vgremove -f $vg" in the test.

then it asks interactively because -f is overloaded here to disable
lv removal question also:-)

There should be -y added, but it is for another patch probably.

Milan