From: Martyn Welch <martyn.welch@ge.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*
Date: Mon, 05 Jul 2010 10:38:24 +0000 [thread overview]
Message-ID: <4C31B620.4060301@ge.com> (raw)
In-Reply-To: <1277806577-31418-1-git-send-email-segooon@gmail.com>
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> if (dest->type = VME_DMA_VME) {
> entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> - vme_attr = (struct vme_dma_vme *)dest->private;
> - pci_attr = (struct vme_dma_pci *)src->private;
> + vme_attr = dest->private;
> + pci_attr = src->private;
> } else {
> - vme_attr = (struct vme_dma_vme *)src->private;
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + vme_attr = src->private;
> + pci_attr = dest->private;
> }
>
> /* Check we can do fullfill required attributes */
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
WARNING: multiple messages have this Message-ID (diff)
From: Martyn Welch <martyn.welch@ge.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
Julia Lawall <julia@diku.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*
Date: Mon, 05 Jul 2010 11:38:24 +0100 [thread overview]
Message-ID: <4C31B620.4060301@ge.com> (raw)
In-Reply-To: <1277806577-31418-1-git-send-email-segooon@gmail.com>
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> if (dest->type == VME_DMA_VME) {
> entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> - vme_attr = (struct vme_dma_vme *)dest->private;
> - pci_attr = (struct vme_dma_pci *)src->private;
> + vme_attr = dest->private;
> + pci_attr = src->private;
> } else {
> - vme_attr = (struct vme_dma_vme *)src->private;
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + vme_attr = src->private;
> + pci_attr = dest->private;
> }
>
> /* Check we can do fullfill required attributes */
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
next prev parent reply other threads:[~2010-07-05 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 10:16 [PATCH 21/25] vme_ca91cx42: remove casts from void* Kulikov Vasiliy
2010-06-29 10:16 ` Kulikov Vasiliy
2010-07-05 10:38 ` Martyn Welch [this message]
2010-07-05 10:38 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C31B620.4060301@ge.com \
--to=martyn.welch@ge.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.