* [PATCH 21/25] vme_ca91cx42: remove casts from void*
@ 2010-06-29 10:16 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-06-29 10:16 UTC (permalink / raw)
To: Kernel Janitors
Cc: Greg Kroah-Hartman, Martyn Welch, Julia Lawall, devel,
linux-kernel
Remove unnesessary casts from void*.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index 0c82eb4..ce05ffa 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
if (dest->type = VME_DMA_VME) {
entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
- vme_attr = (struct vme_dma_vme *)dest->private;
- pci_attr = (struct vme_dma_pci *)src->private;
+ vme_attr = dest->private;
+ pci_attr = src->private;
} else {
- vme_attr = (struct vme_dma_vme *)src->private;
- pci_attr = (struct vme_dma_pci *)dest->private;
+ vme_attr = src->private;
+ pci_attr = dest->private;
}
/* Check we can do fullfill required attributes */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 21/25] vme_ca91cx42: remove casts from void*
@ 2010-06-29 10:16 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-06-29 10:16 UTC (permalink / raw)
To: Kernel Janitors
Cc: Greg Kroah-Hartman, Martyn Welch, Julia Lawall, devel,
linux-kernel
Remove unnesessary casts from void*.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index 0c82eb4..ce05ffa 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
if (dest->type == VME_DMA_VME) {
entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
- vme_attr = (struct vme_dma_vme *)dest->private;
- pci_attr = (struct vme_dma_pci *)src->private;
+ vme_attr = dest->private;
+ pci_attr = src->private;
} else {
- vme_attr = (struct vme_dma_vme *)src->private;
- pci_attr = (struct vme_dma_pci *)dest->private;
+ vme_attr = src->private;
+ pci_attr = dest->private;
}
/* Check we can do fullfill required attributes */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*
2010-06-29 10:16 ` Kulikov Vasiliy
@ 2010-07-05 10:38 ` Martyn Welch
-1 siblings, 0 replies; 4+ messages in thread
From: Martyn Welch @ 2010-07-05 10:38 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, devel, Greg Kroah-Hartman, Julia Lawall,
linux-kernel
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> if (dest->type = VME_DMA_VME) {
> entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> - vme_attr = (struct vme_dma_vme *)dest->private;
> - pci_attr = (struct vme_dma_pci *)src->private;
> + vme_attr = dest->private;
> + pci_attr = src->private;
> } else {
> - vme_attr = (struct vme_dma_vme *)src->private;
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + vme_attr = src->private;
> + pci_attr = dest->private;
> }
>
> /* Check we can do fullfill required attributes */
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*
@ 2010-07-05 10:38 ` Martyn Welch
0 siblings, 0 replies; 4+ messages in thread
From: Martyn Welch @ 2010-07-05 10:38 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, devel, Greg Kroah-Hartman, Julia Lawall,
linux-kernel
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> if (dest->type == VME_DMA_VME) {
> entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> - vme_attr = (struct vme_dma_vme *)dest->private;
> - pci_attr = (struct vme_dma_pci *)src->private;
> + vme_attr = dest->private;
> + pci_attr = src->private;
> } else {
> - vme_attr = (struct vme_dma_vme *)src->private;
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + vme_attr = src->private;
> + pci_attr = dest->private;
> }
>
> /* Check we can do fullfill required attributes */
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-05 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 10:16 [PATCH 21/25] vme_ca91cx42: remove casts from void* Kulikov Vasiliy
2010-06-29 10:16 ` Kulikov Vasiliy
2010-07-05 10:38 ` Martyn Welch
2010-07-05 10:38 ` Martyn Welch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.