From: Nathan Fontenot <nfont@austin.ibm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@ozlabs.org
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH 3/5] v2 Change the mutex name in the memory_block struct
Date: Thu, 15 Jul 2010 13:39:56 -0500 [thread overview]
Message-ID: <4C3F55FC.4050205@austin.ibm.com> (raw)
In-Reply-To: <4C3F53D1.3090001@austin.ibm.com>
Change the name of the memory_block mutex since it is now used for
more than just gating changes to the status of the memory sections
covered by the memory sysfs directory.
Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
---
drivers/base/memory.c | 20 ++++++++++----------
include/linux/memory.h | 9 +--------
2 files changed, 11 insertions(+), 18 deletions(-)
Index: linux-2.6/drivers/base/memory.c
===================================================================
--- linux-2.6.orig/drivers/base/memory.c 2010-07-15 09:56:05.000000000 -0500
+++ linux-2.6/drivers/base/memory.c 2010-07-15 09:56:10.000000000 -0500
@@ -144,14 +144,14 @@
int ret = 1;
mem = container_of(dev, struct memory_block, sysdev);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
list_for_each_entry(mbs, &mem->sections, next) {
start_pfn = section_nr_to_pfn(mbs->phys_index);
ret &= is_mem_section_removable(start_pfn, PAGES_PER_SECTION);
}
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return sprintf(buf, "%d\n", ret);
}
@@ -263,7 +263,7 @@
struct memory_block_section *mbs;
int ret = 0;
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
list_for_each_entry(mbs, &mem->sections, next) {
if (mbs->state != from_state_req)
@@ -288,7 +288,7 @@
if (!ret)
mem->state = to_state;
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return ret;
}
@@ -531,12 +531,12 @@
return -ENOMEM;
mem->state = state;
- mutex_init(&mem->state_mutex);
+ mutex_init(&mem->mutex);
start_pfn = section_nr_to_pfn(__section_nr(section));
mem->phys_device = arch_get_memory_phys_device(start_pfn);
INIT_LIST_HEAD(&mem->sections);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
ret = register_memory(mem, section);
if (!ret)
@@ -555,13 +555,13 @@
}
} else {
kobject_put(&mem->sysdev.kobj);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
}
if (!ret)
ret = add_mem_block_section(mem, __section_nr(section), state);
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return ret;
}
@@ -573,7 +573,7 @@
int section_nr = __section_nr(section);
mem = find_memory_block(section);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
/* remove the specified section */
list_for_each_entry_safe(mbs, tmp, &mem->sections, next) {
@@ -583,7 +583,7 @@
}
}
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
if (list_empty(&mem->sections)) {
unregister_mem_sect_under_nodes(mem);
Index: linux-2.6/include/linux/memory.h
===================================================================
--- linux-2.6.orig/include/linux/memory.h 2010-07-15 09:56:05.000000000 -0500
+++ linux-2.6/include/linux/memory.h 2010-07-15 09:56:10.000000000 -0500
@@ -31,14 +31,7 @@
unsigned long state;
unsigned long start_phys_index;
unsigned long end_phys_index;
-
- /*
- * This serializes all state change requests. It isn't
- * held during creation because the control files are
- * created long after the critical areas during
- * initialization.
- */
- struct mutex state_mutex;
+ struct mutex mutex;
int phys_device; /* to which fru does this belong? */
void *hw; /* optional pointer to fw/hw data */
int (*phys_callback)(struct memory_block *);
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Fontenot <nfont@austin.ibm.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@ozlabs.org
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH 3/5] v2 Change the mutex name in the memory_block struct
Date: Thu, 15 Jul 2010 13:39:56 -0500 [thread overview]
Message-ID: <4C3F55FC.4050205@austin.ibm.com> (raw)
In-Reply-To: <4C3F53D1.3090001@austin.ibm.com>
Change the name of the memory_block mutex since it is now used for
more than just gating changes to the status of the memory sections
covered by the memory sysfs directory.
Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
---
drivers/base/memory.c | 20 ++++++++++----------
include/linux/memory.h | 9 +--------
2 files changed, 11 insertions(+), 18 deletions(-)
Index: linux-2.6/drivers/base/memory.c
===================================================================
--- linux-2.6.orig/drivers/base/memory.c 2010-07-15 09:56:05.000000000 -0500
+++ linux-2.6/drivers/base/memory.c 2010-07-15 09:56:10.000000000 -0500
@@ -144,14 +144,14 @@
int ret = 1;
mem = container_of(dev, struct memory_block, sysdev);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
list_for_each_entry(mbs, &mem->sections, next) {
start_pfn = section_nr_to_pfn(mbs->phys_index);
ret &= is_mem_section_removable(start_pfn, PAGES_PER_SECTION);
}
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return sprintf(buf, "%d\n", ret);
}
@@ -263,7 +263,7 @@
struct memory_block_section *mbs;
int ret = 0;
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
list_for_each_entry(mbs, &mem->sections, next) {
if (mbs->state != from_state_req)
@@ -288,7 +288,7 @@
if (!ret)
mem->state = to_state;
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return ret;
}
@@ -531,12 +531,12 @@
return -ENOMEM;
mem->state = state;
- mutex_init(&mem->state_mutex);
+ mutex_init(&mem->mutex);
start_pfn = section_nr_to_pfn(__section_nr(section));
mem->phys_device = arch_get_memory_phys_device(start_pfn);
INIT_LIST_HEAD(&mem->sections);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
ret = register_memory(mem, section);
if (!ret)
@@ -555,13 +555,13 @@
}
} else {
kobject_put(&mem->sysdev.kobj);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
}
if (!ret)
ret = add_mem_block_section(mem, __section_nr(section), state);
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
return ret;
}
@@ -573,7 +573,7 @@
int section_nr = __section_nr(section);
mem = find_memory_block(section);
- mutex_lock(&mem->state_mutex);
+ mutex_lock(&mem->mutex);
/* remove the specified section */
list_for_each_entry_safe(mbs, tmp, &mem->sections, next) {
@@ -583,7 +583,7 @@
}
}
- mutex_unlock(&mem->state_mutex);
+ mutex_unlock(&mem->mutex);
if (list_empty(&mem->sections)) {
unregister_mem_sect_under_nodes(mem);
Index: linux-2.6/include/linux/memory.h
===================================================================
--- linux-2.6.orig/include/linux/memory.h 2010-07-15 09:56:05.000000000 -0500
+++ linux-2.6/include/linux/memory.h 2010-07-15 09:56:10.000000000 -0500
@@ -31,14 +31,7 @@
unsigned long state;
unsigned long start_phys_index;
unsigned long end_phys_index;
-
- /*
- * This serializes all state change requests. It isn't
- * held during creation because the control files are
- * created long after the critical areas during
- * initialization.
- */
- struct mutex state_mutex;
+ struct mutex mutex;
int phys_device; /* to which fru does this belong? */
void *hw; /* optional pointer to fw/hw data */
int (*phys_callback)(struct memory_block *);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-15 18:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:30 [PATCH 0/5] v2 De-couple sysfs memory directories from memory section size Nathan Fontenot
2010-07-15 18:30 ` Nathan Fontenot
2010-07-15 18:37 ` [PATCH 1/5] v2 Split the memory_block structure Nathan Fontenot
2010-07-15 18:37 ` Nathan Fontenot
2010-07-16 0:06 ` KAMEZAWA Hiroyuki
2010-07-16 0:06 ` KAMEZAWA Hiroyuki
2010-07-16 0:06 ` KAMEZAWA Hiroyuki
2010-07-16 15:29 ` Nathan Fontenot
2010-07-16 15:29 ` Nathan Fontenot
2010-07-16 15:29 ` Nathan Fontenot
2010-07-16 17:15 ` Dave Hansen
2010-07-16 17:15 ` Dave Hansen
2010-07-16 17:15 ` Dave Hansen
2010-07-16 18:23 ` Nathan Fontenot
2010-07-16 18:23 ` Nathan Fontenot
2010-07-16 18:23 ` Nathan Fontenot
2010-07-16 18:33 ` Dave Hansen
2010-07-16 18:33 ` Dave Hansen
2010-07-16 18:33 ` Dave Hansen
2010-07-16 18:45 ` Dave Hansen
2010-07-16 18:45 ` Dave Hansen
2010-07-16 18:45 ` Dave Hansen
2010-07-15 18:38 ` [PATCH 2/5] v2 Create new 'end_phys_index' file Nathan Fontenot
2010-07-15 18:38 ` Nathan Fontenot
2010-07-16 0:08 ` KAMEZAWA Hiroyuki
2010-07-16 0:08 ` KAMEZAWA Hiroyuki
2010-07-16 0:08 ` KAMEZAWA Hiroyuki
2010-07-16 15:36 ` Nathan Fontenot
2010-07-16 15:36 ` Nathan Fontenot
2010-07-16 15:36 ` Nathan Fontenot
2010-07-15 18:39 ` Nathan Fontenot [this message]
2010-07-15 18:39 ` [PATCH 3/5] v2 Change the mutex name in the memory_block struct Nathan Fontenot
2010-07-16 17:16 ` Dave Hansen
2010-07-16 17:16 ` Dave Hansen
2010-07-16 17:16 ` Dave Hansen
2010-07-15 18:40 ` [PATCH 4/5] v2 Update sysfs node routines for new sysfs memory directories Nathan Fontenot
2010-07-15 18:40 ` Nathan Fontenot
2010-07-16 0:12 ` KAMEZAWA Hiroyuki
2010-07-16 0:12 ` KAMEZAWA Hiroyuki
2010-07-16 0:12 ` KAMEZAWA Hiroyuki
2010-07-16 15:40 ` Nathan Fontenot
2010-07-16 15:40 ` Nathan Fontenot
2010-07-16 15:40 ` Nathan Fontenot
2010-07-15 18:41 ` [PATCH 5/5] v2 Enable multiple sections per directory for ppc Nathan Fontenot
2010-07-15 18:41 ` Nathan Fontenot
2010-07-16 17:18 ` Dave Hansen
2010-07-16 17:18 ` Dave Hansen
2010-07-16 17:18 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3F55FC.4050205@austin.ibm.com \
--to=nfont@austin.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.