* Re: Bug#575252: grub-pc: black frame around the background image [not found] <20100324142320.4804.63311.reportbug@localhost> @ 2010-07-06 17:19 ` Colin Watson 2010-07-15 20:33 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 1 reply; 2+ messages in thread From: Colin Watson @ 2010-07-06 17:19 UTC (permalink / raw) To: grub-devel; +Cc: Francesco Muzio, 575252-forwarded On Wed, Mar 24, 2010 at 03:23:20PM +0100, Francesco Muzio wrote: > The last uploaded version of grub2 behaves bad with any resolution allowed by vbeinfo > > The default background image /usr/share/images/desktop-base/moreblue-orbit-grub.png > isn't showed in fullscreen but there is a black frame around the grub menu (grub-devel: This was originally filed at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575252.) Yes, I see the same thing. This is because grub_gfxterm_fullscreen hardcodes a 10-pixel border around the edge of the screen. If the background is just plain black, then this is fine, but it's not very helpful with a background image which tends to be designed for the full screen size. Of course designers *could* design for the full screen size minus 10 pixels all round, but it seems a rather odd requirement to place on them; the 10-pixel border should essentially be so that text isn't drawn too close to the edge of the screen, not so much to restrict the background image. And, if you're arranging for the background image to stay on the screen and transition relatively smoothly into an OS splash screen, then the border looks actively weird: see http://people.canonical.com/~cjwatson/tmp/fbcon-handoff.ogv around 0:13 for an example, as Plymouth repaints the whole background image without the black border. What's the best way to fix this? Perhaps the background_image command should disregard the border? -- Colin Watson [cjwatson@ubuntu.com] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug#575252: grub-pc: black frame around the background image 2010-07-06 17:19 ` Bug#575252: grub-pc: black frame around the background image Colin Watson @ 2010-07-15 20:33 ` Vladimir 'φ-coder/phcoder' Serbinenko 0 siblings, 0 replies; 2+ messages in thread From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-07-15 20:33 UTC (permalink / raw) To: grub-devel [-- Attachment #1: Type: text/plain, Size: 1837 bytes --] On 07/06/2010 07:19 PM, Colin Watson wrote: > On Wed, Mar 24, 2010 at 03:23:20PM +0100, Francesco Muzio wrote: > >> The last uploaded version of grub2 behaves bad with any resolution allowed by vbeinfo >> >> The default background image /usr/share/images/desktop-base/moreblue-orbit-grub.png >> isn't showed in fullscreen but there is a black frame around the grub menu >> > (grub-devel: This was originally filed at > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575252.) > > Yes, I see the same thing. This is because grub_gfxterm_fullscreen > hardcodes a 10-pixel border around the edge of the screen. If the > background is just plain black, then this is fine, but it's not very > helpful with a background image which tends to be designed for the full > screen size. > > Of course designers *could* design for the full screen size minus 10 > pixels all round, but it seems a rather odd requirement to place on > them; the 10-pixel border should essentially be so that text isn't drawn > too close to the edge of the screen, not so much to restrict the > background image. And, if you're arranging for the background image to > stay on the screen and transition relatively smoothly into an OS splash > screen, then the border looks actively weird: see > http://people.canonical.com/~cjwatson/tmp/fbcon-handoff.ogv around 0:13 > for an example, as Plymouth repaints the whole background image without > the black border. > > What's the best way to fix this? Perhaps the background_image command > should disregard the border? > > The clean way would be to show image on the whole screen. It would require some code restructuring. It's just not high enough on the list of my priorities but I'll gladly accept the patch -- Regards Vladimir 'φ-coder/phcoder' Serbinenko [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 294 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-16 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100324142320.4804.63311.reportbug@localhost>
2010-07-06 17:19 ` Bug#575252: grub-pc: black frame around the background image Colin Watson
2010-07-15 20:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.