* [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-15 18:51 ` Peter Huewe
0 siblings, 0 replies; 6+ messages in thread
From: Peter Huewe @ 2010-07-15 18:51 UTC (permalink / raw)
To: Kernel Janitors
Cc: Jens Axboe, Andrew Morton, Márton Németh,
Martin K. Petersen, Alexey Dobriyan, linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
.subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
PCI_VDEVICE macro, and thus improves readability.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/block/sx8.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index b70f0fc..15745e4 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -410,8 +410,8 @@ static void carm_remove_one (struct pci_dev *pdev);
static int carm_bdev_getgeo(struct block_device *bdev, struct hd_geometry *geo);
static const struct pci_device_id carm_pci_tbl[] = {
- { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
- { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
+ { PCI_VDEVICE(PROMISE, 0x8000), },
+ { PCI_VDEVICE(PROMISE, 0x8002), },
{ } /* terminate list */
};
MODULE_DEVICE_TABLE(pci, carm_pci_tbl);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-15 18:51 ` Peter Huewe
0 siblings, 0 replies; 6+ messages in thread
From: Peter Huewe @ 2010-07-15 18:51 UTC (permalink / raw)
To: Kernel Janitors
Cc: Jens Axboe, Andrew Morton, Márton Németh,
Martin K. Petersen, Alexey Dobriyan, linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
.subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
PCI_VDEVICE macro, and thus improves readability.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/block/sx8.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index b70f0fc..15745e4 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -410,8 +410,8 @@ static void carm_remove_one (struct pci_dev *pdev);
static int carm_bdev_getgeo(struct block_device *bdev, struct hd_geometry *geo);
static const struct pci_device_id carm_pci_tbl[] = {
- { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
- { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
+ { PCI_VDEVICE(PROMISE, 0x8000), },
+ { PCI_VDEVICE(PROMISE, 0x8002), },
{ } /* terminate list */
};
MODULE_DEVICE_TABLE(pci, carm_pci_tbl);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE
2010-07-15 18:51 ` Peter Huewe
@ 2010-07-15 19:03 ` Alexey Dobriyan
-1 siblings, 0 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2010-07-15 19:03 UTC (permalink / raw)
To: Peter Huewe
Cc: Kernel Janitors, Jens Axboe, Andrew Morton,
Márton Németh, Martin K. Petersen, linux-kernel
On Thu, Jul 15, 2010 at 08:51:17PM +0200, Peter Huewe wrote:
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
Well, it doesn't improve readability, and ## usage prevents grepping and
long term plan to switch to numbers instead of PCI_VENDOR_ID_*,
but whatever.
> - { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
> - { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
> + { PCI_VDEVICE(PROMISE, 0x8000), },
> + { PCI_VDEVICE(PROMISE, 0x8002), },
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-15 19:03 ` Alexey Dobriyan
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Dobriyan @ 2010-07-15 19:03 UTC (permalink / raw)
To: Peter Huewe
Cc: Kernel Janitors, Jens Axboe, Andrew Morton,
Márton Németh, Martin K. Petersen, linux-kernel
On Thu, Jul 15, 2010 at 08:51:17PM +0200, Peter Huewe wrote:
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
Well, it doesn't improve readability, and ## usage prevents grepping and
long term plan to switch to numbers instead of PCI_VENDOR_ID_*,
but whatever.
> - { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
> - { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
> + { PCI_VDEVICE(PROMISE, 0x8000), },
> + { PCI_VDEVICE(PROMISE, 0x8002), },
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE
2010-07-15 19:03 ` [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Alexey Dobriyan
@ 2010-07-16 0:51 ` Jeff Garzik
-1 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-07-16 0:51 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: Peter Huewe, Kernel Janitors, Jens Axboe, Andrew Morton,
Márton Németh, Martin K. Petersen, linux-kernel
On 07/15/2010 03:03 PM, Alexey Dobriyan wrote:
> On Thu, Jul 15, 2010 at 08:51:17PM +0200, Peter Huewe wrote:
>> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
>> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
>> PCI_VDEVICE macro, and thus improves readability.
>
> Well, it doesn't improve readability, and ## usage prevents grepping and
> long term plan to switch to numbers instead of PCI_VENDOR_ID_*,
> but whatever.
>
>> - { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> - { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> + { PCI_VDEVICE(PROMISE, 0x8000), },
>> + { PCI_VDEVICE(PROMISE, 0x8002), },
Switching to use hex numbers for _device ids_ is encouraged, because
history has proven its pointless to create named constants for
single-use ids. However, using named constants for PCI vendor ids makes
a lot of sense.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-16 0:51 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-07-16 0:51 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: Peter Huewe, Kernel Janitors, Jens Axboe, Andrew Morton,
Márton Németh, Martin K. Petersen, linux-kernel
On 07/15/2010 03:03 PM, Alexey Dobriyan wrote:
> On Thu, Jul 15, 2010 at 08:51:17PM +0200, Peter Huewe wrote:
>> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
>> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
>> PCI_VDEVICE macro, and thus improves readability.
>
> Well, it doesn't improve readability, and ## usage prevents grepping and
> long term plan to switch to numbers instead of PCI_VENDOR_ID_*,
> but whatever.
>
>> - { PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> - { PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
>> + { PCI_VDEVICE(PROMISE, 0x8000), },
>> + { PCI_VDEVICE(PROMISE, 0x8002), },
Switching to use hex numbers for _device ids_ is encouraged, because
history has proven its pointless to create named constants for
single-use ids. However, using named constants for PCI vendor ids makes
a lot of sense.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-16 0:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 18:51 [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Peter Huewe
2010-07-15 18:51 ` Peter Huewe
2010-07-15 19:03 ` [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE Alexey Dobriyan
2010-07-15 19:03 ` [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Alexey Dobriyan
2010-07-16 0:51 ` [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE Jeff Garzik
2010-07-16 0:51 ` [PATCH 11/25] block: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.