From: Doug Nazar <nazard.michi@gmail.com>
To: grub-devel@gnu.org
Subject: Re: Big Endian fix patch
Date: Wed, 28 Jul 2010 12:30:47 -0400 [thread overview]
Message-ID: <4C505B37.2020009@gmail.com> (raw)
In-Reply-To: <20100728155158.GE2632@caffeine.csclub.uwaterloo.ca>
On 2010-07-28 11:51 AM, Lennart Sorensen wrote:
> I was wondering a bit why tab completion for ls doesn't work on md 1.x
> devices. If I do:
> ls (md/0<tab>, I get
> ls (md/0,
> Well since I don't have any partitions, that doesn't help anything).
>
> Also if I do:
> ls (md/0)/<tab> I get nothing. ls (md/0)/ does work, but the tab
> completion refuses to believe it could work. I miss tab completition. :)
>
Think I spotted this by code review.
normal/completion.c:250
dir = grub_strchr (current_word, '/');
It looks for a starting '/' but I bet it's hitting the '/' in the
new-style md names. It should probably be
dir = grub_strchr (current_word + grub_strlen(device), '/');
or something similar. I've just started setting up a test since all my
arrays were under an LVM. It'll take me a little while to test with this
slow setup.
Doug
next prev parent reply other threads:[~2010-07-28 16:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 1:00 Big Endian fix patch (was: Re: Couple more fixes for Linux raid metadata 1.x support) Doug Nazar
2010-07-27 15:26 ` Lennart Sorensen
2010-07-27 23:58 ` Big Endian fix patch Doug Nazar
2010-07-28 14:52 ` Lennart Sorensen
2010-07-28 15:29 ` Doug Nazar
2010-07-28 8:51 ` Doug Nazar
2010-07-28 15:00 ` Lennart Sorensen
2010-07-28 15:51 ` Lennart Sorensen
2010-07-28 16:30 ` Doug Nazar [this message]
2010-07-28 17:01 ` Lennart Sorensen
2010-07-28 17:12 ` Doug Nazar
2010-07-28 17:40 ` Lennart Sorensen
2010-07-28 17:42 ` Lennart Sorensen
2010-07-28 17:52 ` Lennart Sorensen
2010-07-28 18:17 ` Doug Nazar
2010-07-28 18:49 ` Lennart Sorensen
2010-07-28 20:10 ` Doug Nazar
2010-07-28 22:25 ` Lennart Sorensen
2010-07-28 20:46 ` Doug Nazar
2010-07-29 15:30 ` Lennart Sorensen
2010-07-28 18:01 ` Doug Nazar
2010-07-28 18:50 ` Lennart Sorensen
2010-07-28 15:52 ` Doug Nazar
2010-07-28 15:55 ` Lennart Sorensen
2010-09-13 19:54 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C505B37.2020009@gmail.com \
--to=nazard.michi@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.