From: Doug Nazar <nazard.michi@gmail.com>
To: grub-devel@gnu.org
Subject: Re: Big Endian fix patch
Date: Wed, 28 Jul 2010 14:01:46 -0400 [thread overview]
Message-ID: <4C50708A.4030104@gmail.com> (raw)
In-Reply-To: <20100728174219.GI2632@caffeine.csclub.uwaterloo.ca>
On 2010-07-28 1:42 PM, Lennart Sorensen wrote:
> I wish the completion would realize that an md device without partitions
> (so no partition table) should not complete with a ','. Not sure how
> doable that is.
>
I was just looking at that. In disk/raid.c:129 we set the flag that
tells the system to try looking for partitions. I've been debating
whether to add code to disk/raid.c to detect if there actually is a
partition table (by probing for all known partition types) or fix the
tab completion code to offer a ')' also instead of assuming you want a
partition.
I'm not sure of the GRUB design philosophy, but the first option might
be considered a layering violation. Maybe grub_device_open() should
check and then clear the flag if it doesn't have a table.
Doug
next prev parent reply other threads:[~2010-07-28 18:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 1:00 Big Endian fix patch (was: Re: Couple more fixes for Linux raid metadata 1.x support) Doug Nazar
2010-07-27 15:26 ` Lennart Sorensen
2010-07-27 23:58 ` Big Endian fix patch Doug Nazar
2010-07-28 14:52 ` Lennart Sorensen
2010-07-28 15:29 ` Doug Nazar
2010-07-28 8:51 ` Doug Nazar
2010-07-28 15:00 ` Lennart Sorensen
2010-07-28 15:51 ` Lennart Sorensen
2010-07-28 16:30 ` Doug Nazar
2010-07-28 17:01 ` Lennart Sorensen
2010-07-28 17:12 ` Doug Nazar
2010-07-28 17:40 ` Lennart Sorensen
2010-07-28 17:42 ` Lennart Sorensen
2010-07-28 17:52 ` Lennart Sorensen
2010-07-28 18:17 ` Doug Nazar
2010-07-28 18:49 ` Lennart Sorensen
2010-07-28 20:10 ` Doug Nazar
2010-07-28 22:25 ` Lennart Sorensen
2010-07-28 20:46 ` Doug Nazar
2010-07-29 15:30 ` Lennart Sorensen
2010-07-28 18:01 ` Doug Nazar [this message]
2010-07-28 18:50 ` Lennart Sorensen
2010-07-28 15:52 ` Doug Nazar
2010-07-28 15:55 ` Lennart Sorensen
2010-09-13 19:54 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C50708A.4030104@gmail.com \
--to=nazard.michi@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.