From: Andi Kleen <ak@linux.intel.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] x86: mce: fix error handling
Date: Wed, 28 Jul 2010 17:20:11 +0000 [thread overview]
Message-ID: <4C5066CB.7010009@linux.intel.com> (raw)
In-Reply-To: <20100728171327.GA24149@albatros>
> I'm agree with you that if allocation fails at boot time, we are dead :)
> But this coding style breaking rules that result from some functions
> _must_ be checked for errors. Maybe we should add BUG_ON() here or
> indicate someway that we have no ideas how to handle error?
What rules exactly? I don't think any of those functions are declared
with __must_check
Coding style should never get in the way of what is right.
The classic way to explicitely discard a return value is a cast to void,
but that is generally considered
ugly in the Linux kernel.
One could possibly add a comment about this at least.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] x86: mce: fix error handling
Date: Wed, 28 Jul 2010 19:20:11 +0200 [thread overview]
Message-ID: <4C5066CB.7010009@linux.intel.com> (raw)
In-Reply-To: <20100728171327.GA24149@albatros>
> I'm agree with you that if allocation fails at boot time, we are dead :)
> But this coding style breaking rules that result from some functions
> _must_ be checked for errors. Maybe we should add BUG_ON() here or
> indicate someway that we have no ideas how to handle error?
What rules exactly? I don't think any of those functions are declared
with __must_check
Coding style should never get in the way of what is right.
The classic way to explicitely discard a return value is a cast to void,
but that is generally considered
ugly in the Linux kernel.
One could possibly add a comment about this at least.
-Andi
next prev parent reply other threads:[~2010-07-28 17:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 16:39 [PATCH 04/10] x86: mce: fix error handling Kulikov Vasiliy
2010-07-28 16:39 ` Kulikov Vasiliy
2010-07-28 16:48 ` Borislav Petkov
2010-07-28 16:48 ` Borislav Petkov
2010-07-28 17:07 ` Andi Kleen
2010-07-28 17:07 ` Andi Kleen
2010-07-28 17:13 ` Vasiliy Kulikov
2010-07-28 17:13 ` Vasiliy Kulikov
2010-07-28 17:20 ` Andi Kleen [this message]
2010-07-28 17:20 ` Andi Kleen
2010-07-29 9:35 ` Vasiliy Kulikov
2010-07-29 9:35 ` Vasiliy Kulikov
2010-07-29 9:51 ` Andi Kleen
2010-07-29 9:51 ` Andi Kleen
2010-07-29 10:10 ` walter harms
2010-07-29 10:10 ` walter harms
2010-07-31 18:18 ` Vasiliy Kulikov
2010-07-31 18:18 ` Vasiliy Kulikov
2010-07-31 19:07 ` Vasiliy Kulikov
2010-07-31 19:07 ` Vasiliy Kulikov
2010-07-29 10:16 ` Borislav Petkov
2010-07-29 10:16 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5066CB.7010009@linux.intel.com \
--to=ak@linux.intel.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=segooon@gmail.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.