OMAP DSS2 coming out of OFF mode without restoring context

OMAP DSS2 coming out of OFF mode without restoring context

[Laine Walker-Avina]

Hi,

I'm having a problem where the DSS driver isn't restoring the
framebuffer parameters after going in and out of blanking with OFF
mode enabled. The problem appears to be in dss_get_ctx_id() in that
pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
dss_need_ctx_restore() in dss_clk_enable() appears to do the right
thing. I'm using the current master branch of linux-omap.

-- 
Laine Walker-Avina
Firmware Engineer
PASCO scientific

OMAP DSS2 coming out of OFF mode without restoring context

[Laine Walker-Avina]

Hi,

I'm having a problem where the DSS driver isn't restoring the
framebuffer parameters after going in and out of blanking with OFF
mode enabled. The problem appears to be in dss_get_ctx_id() in that
pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
dss_need_ctx_restore() in dss_clk_enable() appears to do the right
thing. I'm using the current master branch of linux-omap.

-- 
Laine Walker-Avina
Firmware Engineer
PASCO scientific

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Tomi Valkeinen]

Hi,

On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> Hi,
> 
> I'm having a problem where the DSS driver isn't restoring the
> framebuffer parameters after going in and out of blanking with OFF
> mode enabled. The problem appears to be in dss_get_ctx_id() in that
> pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> thing. I'm using the current master branch of linux-omap.

You need to fill the func pointer in the board file:

static struct omap_dss_board_info xxx_dss_data = {
	.get_last_off_on_transaction_id = omap_pm_get_dev_context_loss_count,

 Tomi

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Tomi Valkeinen]

Hi,

On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> Hi,
> 
> I'm having a problem where the DSS driver isn't restoring the
> framebuffer parameters after going in and out of blanking with OFF
> mode enabled. The problem appears to be in dss_get_ctx_id() in that
> pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> thing. I'm using the current master branch of linux-omap.

You need to fill the func pointer in the board file:

static struct omap_dss_board_info xxx_dss_data = {
	.get_last_off_on_transaction_id = omap_pm_get_dev_context_loss_count,

 Tomi

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Menon, Nishanth]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1135 bytes --]


----- Original message -----
> Hi,
> 
> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > Hi,
> > 
> > I'm having a problem where the DSS driver isn't restoring the
> > framebuffer parameters after going in and out of blanking with OFF
> > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > thing. I'm using the current master branch of linux-omap.
> 
> You need to fill the func pointer in the board file:
> 
> static struct omap_dss_board_info xxx_dss_data = {
>                 .get_last_off_on_transaction_id > omap_pm_get_dev_context_loss_count,
> 
none of l-o board files seem to do this. I guess
with off capable master, we need this to be 
defaulted under CONFIG_PM within dss/core itself?
I mean the defaults prevent display function
at off, so why ask all boards to fill it up?

Regards,
Nishanth Menon
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Menon, Nishanth]

----- Original message -----
> Hi,
> 
> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > Hi,
> > 
> > I'm having a problem where the DSS driver isn't restoring the
> > framebuffer parameters after going in and out of blanking with OFF
> > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > thing. I'm using the current master branch of linux-omap.
> 
> You need to fill the func pointer in the board file:
> 
> static struct omap_dss_board_info xxx_dss_data = {
>                 .get_last_off_on_transaction_id =
> omap_pm_get_dev_context_loss_count,
> 
none of l-o board files seem to do this. I guess
with off capable master, we need this to be 
defaulted under CONFIG_PM within dss/core itself?
I mean the defaults prevent display function
at off, so why ask all boards to fill it up?

Regards,
Nishanth Menon

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Tomi Valkeinen]

On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
> ----- Original message -----
> > Hi,
> > 
> > On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > > Hi,
> > > 
> > > I'm having a problem where the DSS driver isn't restoring the
> > > framebuffer parameters after going in and out of blanking with OFF
> > > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > > thing. I'm using the current master branch of linux-omap.
> > 
> > You need to fill the func pointer in the board file:
> > 
> > static struct omap_dss_board_info xxx_dss_data = {
> >                 .get_last_off_on_transaction_id > > omap_pm_get_dev_context_loss_count,
> > 
> none of l-o board files seem to do this. I guess
> with off capable master, we need this to be 
> defaulted under CONFIG_PM within dss/core itself?
> I mean the defaults prevent display function
> at off, so why ask all boards to fill it up?

If the PM stuff in linux tree starts to be in working order, then yes,
we need some better solution.

I'm not quite sure what the options are, but I was told that the correct
way to get context loss count is as above, fill the platform_data in the
board file with a pointer to omap_pm_get_dev_context_loss_count().

So if that is still the proper way, then we need a "DSS platform
initialization" function that the board files can call, which then fills
the platform_data with correct data.

But this will still require modifying every board file that uses DSS.
Then again, every board file needs anyway DSS code, so perhaps that's
not such a big issue.

For this particular case there's not much benefit having a separate
initialization function. On the contrary, it'll just have more code
lines. But I think there will be some more platform DSS stuff (like
pinmuxing) which can then use the same mechanism.

 Tomi

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Tomi Valkeinen]

On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
> ----- Original message -----
> > Hi,
> > 
> > On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > > Hi,
> > > 
> > > I'm having a problem where the DSS driver isn't restoring the
> > > framebuffer parameters after going in and out of blanking with OFF
> > > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > > thing. I'm using the current master branch of linux-omap.
> > 
> > You need to fill the func pointer in the board file:
> > 
> > static struct omap_dss_board_info xxx_dss_data = {
> >                 .get_last_off_on_transaction_id =
> > omap_pm_get_dev_context_loss_count,
> > 
> none of l-o board files seem to do this. I guess
> with off capable master, we need this to be 
> defaulted under CONFIG_PM within dss/core itself?
> I mean the defaults prevent display function
> at off, so why ask all boards to fill it up?

If the PM stuff in linux tree starts to be in working order, then yes,
we need some better solution.

I'm not quite sure what the options are, but I was told that the correct
way to get context loss count is as above, fill the platform_data in the
board file with a pointer to omap_pm_get_dev_context_loss_count().

So if that is still the proper way, then we need a "DSS platform
initialization" function that the board files can call, which then fills
the platform_data with correct data.

But this will still require modifying every board file that uses DSS.
Then again, every board file needs anyway DSS code, so perhaps that's
not such a big issue.

For this particular case there's not much benefit having a separate
initialization function. On the contrary, it'll just have more code
lines. But I think there will be some more platform DSS stuff (like
pinmuxing) which can then use the same mechanism.

 Tomi

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Nishanth Menon]

Tomi Valkeinen had written, on 07/30/2010 06:17 AM, the following:
> On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
>> ----- Original message -----
>>> Hi,
>>>
>>> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
>>>> Hi,
>>>>
>>>> I'm having a problem where the DSS driver isn't restoring the
>>>> framebuffer parameters after going in and out of blanking with OFF
>>>> mode enabled. The problem appears to be in dss_get_ctx_id() in that
>>>> pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
>>>> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
>>>> thing. I'm using the current master branch of linux-omap.
>>> You need to fill the func pointer in the board file:
>>>
>>> static struct omap_dss_board_info xxx_dss_data = {
>>>                 .get_last_off_on_transaction_id >>> omap_pm_get_dev_context_loss_count,
>>>
>> none of l-o board files seem to do this. I guess
>> with off capable master, we need this to be 
>> defaulted under CONFIG_PM within dss/core itself?
>> I mean the defaults prevent display function
>> at off, so why ask all boards to fill it up?
> 
> If the PM stuff in linux tree starts to be in working order, then yes,
> we need some better solution.
> 
> I'm not quite sure what the options are, but I was told that the correct
> way to get context loss count is as above, fill the platform_data in the
> board file with a pointer to omap_pm_get_dev_context_loss_count().
> 
> So if that is still the proper way, then we need a "DSS platform
> initialization" function that the board files can call, which then fills
> the platform_data with correct data.
> 
> But this will still require modifying every board file that uses DSS.
> Then again, every board file needs anyway DSS code, so perhaps that's
> not such a big issue.
> 
> For this particular case there's not much benefit having a separate
> initialization function. On the contrary, it'll just have more code
> lines. But I think there will be some more platform DSS stuff (like
> pinmuxing) which can then use the same mechanism.
> 
>  Tomi
> 
> 

I was thinking more of the lines of this:
a) omap_pm_get_dev_context_loss_count is exported
OR
b) there is a file arch/arm/mach-omap2/dss.c which would take this..


diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index b3a498f..0b9041a 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -35,6 +35,7 @@

  #include <plat/display.h>
  #include <plat/clock.h>
+#include <plat/omap-pm.h>

  #include "dss.h"

@@ -502,6 +503,10 @@ static int omap_dss_probe(struct platform_device *pdev)

         core.pdev = pdev;

+       if (!core.pdev->get_last_off_on_transaction_id)
+               core.pdev->get_last_off_on_transaction_id +                       omap_pm_get_dev_context_loss_count;
+
         dss_init_overlay_managers(pdev);
         dss_init_overlays(pdev);



-- 
Regards,
Nishanth Menon

Re: OMAP DSS2 coming out of OFF mode without restoring context

[Nishanth Menon]

Tomi Valkeinen had written, on 07/30/2010 06:17 AM, the following:
> On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
>> ----- Original message -----
>>> Hi,
>>>
>>> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
>>>> Hi,
>>>>
>>>> I'm having a problem where the DSS driver isn't restoring the
>>>> framebuffer parameters after going in and out of blanking with OFF
>>>> mode enabled. The problem appears to be in dss_get_ctx_id() in that
>>>> pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
>>>> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
>>>> thing. I'm using the current master branch of linux-omap.
>>> You need to fill the func pointer in the board file:
>>>
>>> static struct omap_dss_board_info xxx_dss_data = {
>>>                 .get_last_off_on_transaction_id =
>>> omap_pm_get_dev_context_loss_count,
>>>
>> none of l-o board files seem to do this. I guess
>> with off capable master, we need this to be 
>> defaulted under CONFIG_PM within dss/core itself?
>> I mean the defaults prevent display function
>> at off, so why ask all boards to fill it up?
> 
> If the PM stuff in linux tree starts to be in working order, then yes,
> we need some better solution.
> 
> I'm not quite sure what the options are, but I was told that the correct
> way to get context loss count is as above, fill the platform_data in the
> board file with a pointer to omap_pm_get_dev_context_loss_count().
> 
> So if that is still the proper way, then we need a "DSS platform
> initialization" function that the board files can call, which then fills
> the platform_data with correct data.
> 
> But this will still require modifying every board file that uses DSS.
> Then again, every board file needs anyway DSS code, so perhaps that's
> not such a big issue.
> 
> For this particular case there's not much benefit having a separate
> initialization function. On the contrary, it'll just have more code
> lines. But I think there will be some more platform DSS stuff (like
> pinmuxing) which can then use the same mechanism.
> 
>  Tomi
> 
> 

I was thinking more of the lines of this:
a) omap_pm_get_dev_context_loss_count is exported
OR
b) there is a file arch/arm/mach-omap2/dss.c which would take this..


diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index b3a498f..0b9041a 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -35,6 +35,7 @@

  #include <plat/display.h>
  #include <plat/clock.h>
+#include <plat/omap-pm.h>

  #include "dss.h"

@@ -502,6 +503,10 @@ static int omap_dss_probe(struct platform_device *pdev)

         core.pdev = pdev;

+       if (!core.pdev->get_last_off_on_transaction_id)
+               core.pdev->get_last_off_on_transaction_id =
+                       omap_pm_get_dev_context_loss_count;
+
         dss_init_overlay_managers(pdev);
         dss_init_overlays(pdev);



-- 
Regards,
Nishanth Menon

RE: OMAP DSS2 coming out of OFF mode without restoring context

[Aguirre, Sergio]

Hi,

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Menon, Nishanth
> Sent: Friday, July 30, 2010 8:01 AM
> To: Tomi Valkeinen
> Cc: ext Laine Walker-Avina; linux-omap@vger.kernel.org; linux-
> fbdev@vger.kernel.org
> Subject: Re: OMAP DSS2 coming out of OFF mode without restoring context
> 
> Tomi Valkeinen had written, on 07/30/2010 06:17 AM, the following:
> > On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
> >> ----- Original message -----
> >>> Hi,
> >>>
> >>> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> >>>> Hi,
> >>>>
> >>>> I'm having a problem where the DSS driver isn't restoring the
> >>>> framebuffer parameters after going in and out of blanking with OFF
> >>>> mode enabled. The problem appears to be in dss_get_ctx_id() in that
> >>>> pdata->get_last_off_on_transaction_id is 0. Commenting out the call
> to
> >>>> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> >>>> thing. I'm using the current master branch of linux-omap.
> >>> You need to fill the func pointer in the board file:
> >>>
> >>> static struct omap_dss_board_info xxx_dss_data = {
> >>>                 .get_last_off_on_transaction_id > >>> omap_pm_get_dev_context_loss_count,
> >>>
> >> none of l-o board files seem to do this. I guess
> >> with off capable master, we need this to be
> >> defaulted under CONFIG_PM within dss/core itself?
> >> I mean the defaults prevent display function
> >> at off, so why ask all boards to fill it up?
> >
> > If the PM stuff in linux tree starts to be in working order, then yes,
> > we need some better solution.
> >
> > I'm not quite sure what the options are, but I was told that the correct
> > way to get context loss count is as above, fill the platform_data in the
> > board file with a pointer to omap_pm_get_dev_context_loss_count().
> >
> > So if that is still the proper way, then we need a "DSS platform
> > initialization" function that the board files can call, which then fills
> > the platform_data with correct data.
> >
> > But this will still require modifying every board file that uses DSS.
> > Then again, every board file needs anyway DSS code, so perhaps that's
> > not such a big issue.
> >
> > For this particular case there's not much benefit having a separate
> > initialization function. On the contrary, it'll just have more code
> > lines. But I think there will be some more platform DSS stuff (like
> > pinmuxing) which can then use the same mechanism.
> >
> >  Tomi
> >
> >
> 
> I was thinking more of the lines of this:
> a) omap_pm_get_dev_context_loss_count is exported
> OR
> b) there is a file arch/arm/mach-omap2/dss.c which would take this..

I'm curious about something...

Why this can't be part of the platform code per-cpu?

It makes no sense to me (unless I'm missing something here) to put this
In mach-omap2/ files... It should be on plat-omap/ somewhere.

What do you think?

Regards,
Sergio

> 
> 
> diff --git a/drivers/video/omap2/dss/core.c
> b/drivers/video/omap2/dss/core.c
> index b3a498f..0b9041a 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -35,6 +35,7 @@
> 
>   #include <plat/display.h>
>   #include <plat/clock.h>
> +#include <plat/omap-pm.h>
> 
>   #include "dss.h"
> 
> @@ -502,6 +503,10 @@ static int omap_dss_probe(struct platform_device
> *pdev)
> 
>          core.pdev = pdev;
> 
> +       if (!core.pdev->get_last_off_on_transaction_id)
> +               core.pdev->get_last_off_on_transaction_id > +                       omap_pm_get_dev_context_loss_count;
> +
>          dss_init_overlay_managers(pdev);
>          dss_init_overlays(pdev);
> 
> 
> 
> --
> Regards,
> Nishanth Menon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: OMAP DSS2 coming out of OFF mode without restoring context

[Aguirre, Sergio]

Hi,

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Menon, Nishanth
> Sent: Friday, July 30, 2010 8:01 AM
> To: Tomi Valkeinen
> Cc: ext Laine Walker-Avina; linux-omap@vger.kernel.org; linux-
> fbdev@vger.kernel.org
> Subject: Re: OMAP DSS2 coming out of OFF mode without restoring context
> 
> Tomi Valkeinen had written, on 07/30/2010 06:17 AM, the following:
> > On Fri, 2010-07-30 at 13:09 +0200, ext Menon, Nishanth wrote:
> >> ----- Original message -----
> >>> Hi,
> >>>
> >>> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> >>>> Hi,
> >>>>
> >>>> I'm having a problem where the DSS driver isn't restoring the
> >>>> framebuffer parameters after going in and out of blanking with OFF
> >>>> mode enabled. The problem appears to be in dss_get_ctx_id() in that
> >>>> pdata->get_last_off_on_transaction_id is 0. Commenting out the call
> to
> >>>> dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> >>>> thing. I'm using the current master branch of linux-omap.
> >>> You need to fill the func pointer in the board file:
> >>>
> >>> static struct omap_dss_board_info xxx_dss_data = {
> >>>                 .get_last_off_on_transaction_id =
> >>> omap_pm_get_dev_context_loss_count,
> >>>
> >> none of l-o board files seem to do this. I guess
> >> with off capable master, we need this to be
> >> defaulted under CONFIG_PM within dss/core itself?
> >> I mean the defaults prevent display function
> >> at off, so why ask all boards to fill it up?
> >
> > If the PM stuff in linux tree starts to be in working order, then yes,
> > we need some better solution.
> >
> > I'm not quite sure what the options are, but I was told that the correct
> > way to get context loss count is as above, fill the platform_data in the
> > board file with a pointer to omap_pm_get_dev_context_loss_count().
> >
> > So if that is still the proper way, then we need a "DSS platform
> > initialization" function that the board files can call, which then fills
> > the platform_data with correct data.
> >
> > But this will still require modifying every board file that uses DSS.
> > Then again, every board file needs anyway DSS code, so perhaps that's
> > not such a big issue.
> >
> > For this particular case there's not much benefit having a separate
> > initialization function. On the contrary, it'll just have more code
> > lines. But I think there will be some more platform DSS stuff (like
> > pinmuxing) which can then use the same mechanism.
> >
> >  Tomi
> >
> >
> 
> I was thinking more of the lines of this:
> a) omap_pm_get_dev_context_loss_count is exported
> OR
> b) there is a file arch/arm/mach-omap2/dss.c which would take this..

I'm curious about something...

Why this can't be part of the platform code per-cpu?

It makes no sense to me (unless I'm missing something here) to put this
In mach-omap2/ files... It should be on plat-omap/ somewhere.

What do you think?

Regards,
Sergio

> 
> 
> diff --git a/drivers/video/omap2/dss/core.c
> b/drivers/video/omap2/dss/core.c
> index b3a498f..0b9041a 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -35,6 +35,7 @@
> 
>   #include <plat/display.h>
>   #include <plat/clock.h>
> +#include <plat/omap-pm.h>
> 
>   #include "dss.h"
> 
> @@ -502,6 +503,10 @@ static int omap_dss_probe(struct platform_device
> *pdev)
> 
>          core.pdev = pdev;
> 
> +       if (!core.pdev->get_last_off_on_transaction_id)
> +               core.pdev->get_last_off_on_transaction_id =
> +                       omap_pm_get_dev_context_loss_count;
> +
>          dss_init_overlay_managers(pdev);
>          dss_init_overlays(pdev);
> 
> 
> 
> --
> Regards,
> Nishanth Menon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html