* [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-15 18:39 ` Peter Huewe
0 siblings, 0 replies; 4+ messages in thread
From: Peter Huewe @ 2010-07-15 18:39 UTC (permalink / raw)
To: Kernel Janitors
Cc: Jeff Garzik, Tejun Heo, Sergei Shtylyov, linux-ide, linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
.subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
PCI_VDEVICE macro, and thus improves readability.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/ata/pata_scc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
index d9db3f8..fe36966 100644
--- a/drivers/ata/pata_scc.c
+++ b/drivers/ata/pata_scc.c
@@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = {
};
static const struct pci_device_id scc_pci_tbl[] = {
- {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
- PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+ { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
{ } /* terminate list */
};
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-07-15 18:39 ` Peter Huewe
0 siblings, 0 replies; 4+ messages in thread
From: Peter Huewe @ 2010-07-15 18:39 UTC (permalink / raw)
To: Kernel Janitors
Cc: Jeff Garzik, Tejun Heo, Sergei Shtylyov, linux-ide, linux-kernel
From: Peter Huewe <peterhuewe@gmx.de>
This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
.subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
PCI_VDEVICE macro, and thus improves readability.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/ata/pata_scc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
index d9db3f8..fe36966 100644
--- a/drivers/ata/pata_scc.c
+++ b/drivers/ata/pata_scc.c
@@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = {
};
static const struct pci_device_id scc_pci_tbl[] = {
- {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
- PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+ { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
{ } /* terminate list */
};
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if
2010-07-15 18:39 ` Peter Huewe
@ 2010-08-01 23:48 ` Jeff Garzik
-1 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2010-08-01 23:48 UTC (permalink / raw)
To: Peter Huewe
Cc: Kernel Janitors, Tejun Heo, Sergei Shtylyov, linux-ide,
linux-kernel
On 07/15/2010 02:39 PM, Peter Huewe wrote:
> From: Peter Huewe<peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe<peterhuewe@gmx.de>
> ---
> drivers/ata/pata_scc.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
> index d9db3f8..fe36966 100644
> --- a/drivers/ata/pata_scc.c
> +++ b/drivers/ata/pata_scc.c
> @@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = {
> };
>
> static const struct pci_device_id scc_pci_tbl[] = {
> - {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> + { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
> { } /* terminate list */
applied
I would prefer to leave ata_piix as it is, though. It's nice and
manageable :)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
@ 2010-08-01 23:48 ` Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2010-08-01 23:48 UTC (permalink / raw)
To: Peter Huewe
Cc: Kernel Janitors, Tejun Heo, Sergei Shtylyov, linux-ide,
linux-kernel
On 07/15/2010 02:39 PM, Peter Huewe wrote:
> From: Peter Huewe<peterhuewe@gmx.de>
>
> This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
> .subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
> PCI_VDEVICE macro, and thus improves readability.
>
> Signed-off-by: Peter Huewe<peterhuewe@gmx.de>
> ---
> drivers/ata/pata_scc.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
> index d9db3f8..fe36966 100644
> --- a/drivers/ata/pata_scc.c
> +++ b/drivers/ata/pata_scc.c
> @@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = {
> };
>
> static const struct pci_device_id scc_pci_tbl[] = {
> - {PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> + { PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
> { } /* terminate list */
applied
I would prefer to leave ata_piix as it is, though. It's nice and
manageable :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-01 23:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 18:39 [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Peter Huewe
2010-07-15 18:39 ` Peter Huewe
2010-08-01 23:48 ` [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if Jeff Garzik
2010-08-01 23:48 ` [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.