From: Richard Henderson <rth@twiddle.net>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from
Date: Tue, 03 Aug 2010 20:09:05 +0000 [thread overview]
Message-ID: <4C587761.1040704@twiddle.net> (raw)
In-Reply-To: <AANLkTik0E6L_9Uz3zNmh+M2gHXnjJ6=ibYY-u=fcmcw8@mail.gmail.com>
On 08/02/2010 01:35 PM, Hollis Blanchard wrote:
>> Of those archs, only 2 actually use the return value of load_uimage
>> to decide where to place blobs. PPC and MB. MB doesn't want any
>> magic applied to the return value. That leaves us with _ONE_ single
>> arch that needs magic that IMO is broken. You are trying to guess the
>> size of the loaded image's .bss area by adding a 16th of the uimage size?
>
> Accounting for BSS hardly counts as "magic", I think. :)
A 1/16 factor is not "accounting", it's guessing i.e. magic.
I'm not sure why the u-image format doesn't include the size
of the bss, but my guess is that it's expecting the kernel to
zero its bss segment at startup. File a bug with either the
kernel and/or the u-boot project if you like.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, kvm-ppc@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage
Date: Tue, 03 Aug 2010 13:09:05 -0700 [thread overview]
Message-ID: <4C587761.1040704@twiddle.net> (raw)
In-Reply-To: <AANLkTik0E6L_9Uz3zNmh+M2gHXnjJ6=ibYY-u=fcmcw8@mail.gmail.com>
On 08/02/2010 01:35 PM, Hollis Blanchard wrote:
>> Of those archs, only 2 actually use the return value of load_uimage
>> to decide where to place blobs. PPC and MB. MB doesn't want any
>> magic applied to the return value. That leaves us with _ONE_ single
>> arch that needs magic that IMO is broken. You are trying to guess the
>> size of the loaded image's .bss area by adding a 16th of the uimage size?
>
> Accounting for BSS hardly counts as "magic", I think. :)
A 1/16 factor is not "accounting", it's guessing i.e. magic.
I'm not sure why the u-image format doesn't include the size
of the bss, but my guess is that it's expecting the kernel to
zero its bss segment at startup. File a bug with either the
kernel and/or the u-boot project if you like.
r~
next prev parent reply other threads:[~2010-08-03 20:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 1:48 [PATCH] PPC4xx: don't unregister RAM at reset Hollis Blanchard
2010-07-30 1:48 ` [Qemu-devel] " Hollis Blanchard
2010-07-30 1:48 ` [PATCH] loader: pad kernel size when loaded from a uImage Hollis Blanchard
2010-07-30 1:48 ` [Qemu-devel] " Hollis Blanchard
2010-07-30 6:31 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from malc
2010-07-30 6:31 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage malc
2010-07-30 22:56 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from Edgar E. Iglesias
2010-07-30 22:56 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Edgar E. Iglesias
2010-08-01 12:36 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from Edgar E. Iglesias
2010-08-01 12:36 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Edgar E. Iglesias
2010-08-02 17:59 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a Hollis Blanchard
2010-08-02 17:59 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Hollis Blanchard
2010-08-02 18:57 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from Edgar E. Iglesias
2010-08-02 18:57 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Edgar E. Iglesias
2010-08-02 19:33 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a Hollis Blanchard
2010-08-02 19:33 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Hollis Blanchard
2010-08-02 19:56 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from Edgar E. Iglesias
2010-08-02 19:56 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Edgar E. Iglesias
2010-08-02 20:35 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a Hollis Blanchard
2010-08-02 20:35 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Hollis Blanchard
2010-08-03 20:09 ` Richard Henderson [this message]
2010-08-03 20:09 ` Richard Henderson
2010-08-02 8:41 ` [PATCH] PPC4xx: don't unregister RAM at reset Alexander Graf
2010-08-02 8:41 ` [Qemu-devel] " Alexander Graf
2010-08-02 19:37 ` Hollis Blanchard
2010-08-02 19:37 ` [Qemu-devel] " Hollis Blanchard
2010-08-02 19:41 ` Alexander Graf
2010-08-02 19:41 ` [Qemu-devel] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C587761.1040704@twiddle.net \
--to=rth@twiddle.net \
--cc=edgar.iglesias@gmail.com \
--cc=hollis@penguinppc.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.