Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/11/2010 02:32 PM, Cam Macdonell wrote:
> On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil<weil@mail.berlios.de>  wrote:
>> Am 11.08.2010 20:16, schrieb Cam Macdonell:
>>>
>>> ---
>>> kvm-stub.c | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/kvm-stub.c b/kvm-stub.c
>>> index 3378bd3..d45f9fa 100644
>>> --- a/kvm-stub.c
>>> +++ b/kvm-stub.c
>>> @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,
>>> uint16_t val, bool assign)
>>> {
>>> return -ENOSYS;
>>> }
>>> +
>>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t adr, uint32_t val, bool
>>> assign)
>>> +{
>>> + return -ENOSYS;
>>> +}
>>
>> Your 2nd patch disables build of ivshmem.o on non-kvm systems.
>> Only ivshmem.c was using kvm_set_ioeventfd_mmio_long, so
>> up to now, no dummy function in kvm-stub.c is needed.
>
> Right. It can be left out for now if that's preferred.

No, your patch is correct.  If kvm-stub.c is not complete, the build 
will break the next time someone uses one of those functions.

Paolo